summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorkwilk2012-03-23 14:13:26 (EDT)
committer Roberto E. Escobar2012-03-23 14:13:26 (EDT)
commit05384615002670dc7fb0b967125b6ee88a0b3abd (patch)
treee87655a64a69c111f382a7d1ec98dbd2fbef8467
parent9e618c9fc620e0749027f5dc5a822c47868e5730 (diff)
downloadorg.eclipse.osee-05384615002670dc7fb0b967125b6ee88a0b3abd.zip
org.eclipse.osee-05384615002670dc7fb0b967125b6ee88a0b3abd.tar.gz
org.eclipse.osee-05384615002670dc7fb0b967125b6ee88a0b3abd.tar.bz2
refactor: Code quality changes
-rw-r--r--plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/store/OseeCoverageUnitStore.java15
-rw-r--r--plugins/org.eclipse.osee.executor.admin/src/org/eclipse/osee/executor/admin/CancellableCallable.java1
-rw-r--r--plugins/org.eclipse.osee.framework.core.model/src/org/eclipse/osee/framework/core/model/change/ChangeVersion.java1
3 files changed, 11 insertions, 6 deletions
diff --git a/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/store/OseeCoverageUnitStore.java b/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/store/OseeCoverageUnitStore.java
index a09d0f8..4cd8fdc 100644
--- a/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/store/OseeCoverageUnitStore.java
+++ b/plugins/org.eclipse.osee.coverage/src/org/eclipse/osee/coverage/store/OseeCoverageUnitStore.java
@@ -165,11 +165,18 @@ public class OseeCoverageUnitStore extends OseeCoverageStore {
Pair<String, String> nameGuid = CoverageItem.getNameGuidFromStore((String) attr.getValue());
CoverageChange change =
new CoverageChange(nameGuid.getFirst(), nameGuid.getSecond(), CoverageEventType.Modified);
- if (attr.getModificationType() == ModificationType.NEW || attr.getModificationType() == ModificationType.UNDELETED || attr.getModificationType() == ModificationType.INTRODUCED) {
- change.setEventType(CoverageEventType.Added);
- } else if (attr.getModificationType() == ModificationType.DELETED) {
- change.setEventType(CoverageEventType.Deleted);
+
+ switch (attr.getModificationType()) {
+ case NEW:
+ case UNDELETED:
+ case INTRODUCED:
+ change.setEventType(CoverageEventType.Added);
+ break;
+ case DELETED:
+ change.setEventType(CoverageEventType.Deleted);
+ break;
}
+
coverageEvent.getCoverages().add(change);
} catch (Exception ex) {
OseeLog.log(Activator.class, Level.SEVERE, ex);
diff --git a/plugins/org.eclipse.osee.executor.admin/src/org/eclipse/osee/executor/admin/CancellableCallable.java b/plugins/org.eclipse.osee.executor.admin/src/org/eclipse/osee/executor/admin/CancellableCallable.java
index ebf1e66..74ea3e0 100644
--- a/plugins/org.eclipse.osee.executor.admin/src/org/eclipse/osee/executor/admin/CancellableCallable.java
+++ b/plugins/org.eclipse.osee.executor.admin/src/org/eclipse/osee/executor/admin/CancellableCallable.java
@@ -21,7 +21,6 @@ public abstract class CancellableCallable<T> implements Callable<T>, HasCancella
private volatile boolean cancelled;
protected CancellableCallable() {
- super();
cancelled = false;
}
diff --git a/plugins/org.eclipse.osee.framework.core.model/src/org/eclipse/osee/framework/core/model/change/ChangeVersion.java b/plugins/org.eclipse.osee.framework.core.model/src/org/eclipse/osee/framework/core/model/change/ChangeVersion.java
index 9a9e6b9..2519aba 100644
--- a/plugins/org.eclipse.osee.framework.core.model/src/org/eclipse/osee/framework/core/model/change/ChangeVersion.java
+++ b/plugins/org.eclipse.osee.framework.core.model/src/org/eclipse/osee/framework/core/model/change/ChangeVersion.java
@@ -29,7 +29,6 @@ public final class ChangeVersion {
}
public ChangeVersion(String value, Long gammaId, ModificationType modType) {
- super();
this.value = value;
this.gammaId = gammaId;
this.modType = modType;