resolve code warnings

8 files changed, 50 insertions, 67 deletions

diff --git a/plugins/org.eclipse.osee.coverage.test/src/org/eclipse/osee/coverage/test/CoveragePackageImportTest.java b/plugins/org.eclipse.osee.coverage.test/src/org/eclipse/osee/coverage/test/CoveragePackageImportTest.java
index 43d3da121b1..f9243f52f73 100644
--- a/plugins/org.eclipse.osee.coverage.test/src/org/eclipse/osee/coverage/test/CoveragePackageImportTest.java
+++ b/plugins/org.eclipse.osee.coverage.test/src/org/eclipse/osee/coverage/test/CoveragePackageImportTest.java
@@ -139,22 +139,22 @@ public class CoveragePackageImportTest {
          }
 
          @Override
-         public Result save() throws OseeCoreException {
+         public Result save() {
             return Result.TrueResult;
          }
 
          @Override
-         public Result save(Collection<ICoverage> coverages) throws OseeCoreException {
+         public Result save(Collection<ICoverage> coverages) {
             return Result.TrueResult;
          }
 
          @Override
-         public Result saveImportRecord(SkynetTransaction transaction, CoverageImport coverageImport) throws OseeCoreException {
+         public Result saveImportRecord(SkynetTransaction transaction, CoverageImport coverageImport) {
             return Result.TrueResult;
          }
 
          @Override
-         public Branch getBranch() throws OseeCoreException {
+         public Branch getBranch() {
             return commonBranch;
          }
 
@@ -169,22 +169,22 @@ public class CoveragePackageImportTest {
          }
 
          @Override
-         public Result save() throws OseeCoreException {
+         public Result save() {
             return Result.TrueResult;
          }
 
          @Override
-         public Result save(Collection<ICoverage> coverages) throws OseeCoreException {
+         public Result save(Collection<ICoverage> coverages) {
             return Result.TrueResult;
          }
 
          @Override
-         public Result saveImportRecord(SkynetTransaction transaction, CoverageImport coverageImport) throws OseeCoreException {
+         public Result saveImportRecord(SkynetTransaction transaction, CoverageImport coverageImport) {
             return Result.TrueResult;
          }
 
          @Override
-         public Branch getBranch() throws OseeCoreException {
+         public Branch getBranch() {
             return commonBranch;
          }
 
@@ -297,22 +297,22 @@ public class CoveragePackageImportTest {
          }
 
          @Override
-         public Result save() throws OseeCoreException {
+         public Result save() {
             return Result.TrueResult;
          }
 
          @Override
-         public Result save(Collection<ICoverage> coverages) throws OseeCoreException {
+         public Result save(Collection<ICoverage> coverages) {
             return Result.TrueResult;
          }
 
          @Override
-         public Result saveImportRecord(SkynetTransaction transaction, CoverageImport coverageImport) throws OseeCoreException {
+         public Result saveImportRecord(SkynetTransaction transaction, CoverageImport coverageImport) {
             return Result.TrueResult;
          }
 
          @Override
-         public Branch getBranch() throws OseeCoreException {
+         public Branch getBranch() {
             return commonBranch;
          }
 
@@ -398,22 +398,22 @@ public class CoveragePackageImportTest {
          }
 
          @Override
-         public Result save() throws OseeCoreException {
+         public Result save() {
             return Result.TrueResult;
          }
 
          @Override
-         public Result save(Collection<ICoverage> coverages) throws OseeCoreException {
+         public Result save(Collection<ICoverage> coverages) {
             return Result.TrueResult;
          }
 
          @Override
-         public Result saveImportRecord(SkynetTransaction transaction, CoverageImport coverageImport) throws OseeCoreException {
+         public Result saveImportRecord(SkynetTransaction transaction, CoverageImport coverageImport) {
             return Result.TrueResult;
          }
 
          @Override
-         public Branch getBranch() throws OseeCoreException {
+         public Branch getBranch() {
             return commonBranch;
          }
 
@@ -514,22 +514,22 @@ public class CoveragePackageImportTest {
          }
 
          @Override
-         public Result save() throws OseeCoreException {
+         public Result save() {
             return Result.TrueResult;
          }
 
          @Override
-         public Result save(Collection<ICoverage> coverages) throws OseeCoreException {
+         public Result save(Collection<ICoverage> coverages) {
             return Result.TrueResult;
          }
 
          @Override
-         public Result saveImportRecord(SkynetTransaction transaction, CoverageImport coverageImport) throws OseeCoreException {
+         public Result saveImportRecord(SkynetTransaction transaction, CoverageImport coverageImport) {
             return Result.TrueResult;
          }
 
          @Override
-         public Branch getBranch() throws OseeCoreException {
+         public Branch getBranch() {
             return commonBranch;
          }
 
@@ -637,22 +637,22 @@ public class CoveragePackageImportTest {
          }
 
          @Override
-         public Result save() throws OseeCoreException {
+         public Result save() {
             return Result.TrueResult;
          }
 
          @Override
-         public Result save(Collection<ICoverage> coverages) throws OseeCoreException {
+         public Result save(Collection<ICoverage> coverages) {
             return Result.TrueResult;
          }
 
          @Override
-         public Result saveImportRecord(SkynetTransaction transaction, CoverageImport coverageImport) throws OseeCoreException {
+         public Result saveImportRecord(SkynetTransaction transaction, CoverageImport coverageImport) {
             return Result.TrueResult;
          }
 
          @Override
-         public Branch getBranch() throws OseeCoreException {
+         public Branch getBranch() {
             return commonBranch;
          }
 
@@ -753,22 +753,22 @@ public class CoveragePackageImportTest {
          }
 
          @Override
-         public Result save() throws OseeCoreException {
+         public Result save() {
             return Result.TrueResult;
          }
 
          @Override
-         public Result save(Collection<ICoverage> coverages) throws OseeCoreException {
+         public Result save(Collection<ICoverage> coverages) {
             return Result.TrueResult;
          }
 
          @Override
-         public Result saveImportRecord(SkynetTransaction transaction, CoverageImport coverageImport) throws OseeCoreException {
+         public Result saveImportRecord(SkynetTransaction transaction, CoverageImport coverageImport) {
             return Result.TrueResult;
          }
 
          @Override
-         public Branch getBranch() throws OseeCoreException {
+         public Branch getBranch() {
             return commonBranch;
          }
 
@@ -920,22 +920,22 @@ public class CoveragePackageImportTest {
          }
 
          @Override
-         public Result save() throws OseeCoreException {
+         public Result save() {
             return Result.TrueResult;
          }
 
          @Override
-         public Result save(Collection<ICoverage> coverages) throws OseeCoreException {
+         public Result save(Collection<ICoverage> coverages) {
             return Result.TrueResult;
          }
 
          @Override
-         public Result saveImportRecord(SkynetTransaction transaction, CoverageImport coverageImport) throws OseeCoreException {
+         public Result saveImportRecord(SkynetTransaction transaction, CoverageImport coverageImport) {
             return Result.TrueResult;
          }
 
          @Override
-         public Branch getBranch() throws OseeCoreException {
+         public Branch getBranch() {
             return commonBranch;
          }
 
@@ -1071,22 +1071,22 @@ public class CoveragePackageImportTest {
          }
 
          @Override
-         public Result save() throws OseeCoreException {
+         public Result save() {
             return Result.TrueResult;
          }
 
          @Override
-         public Result save(Collection<ICoverage> coverages) throws OseeCoreException {
+         public Result save(Collection<ICoverage> coverages) {
             return Result.TrueResult;
          }
 
          @Override
-         public Result saveImportRecord(SkynetTransaction transaction, CoverageImport coverageImport) throws OseeCoreException {
+         public Result saveImportRecord(SkynetTransaction transaction, CoverageImport coverageImport) {
             return Result.TrueResult;
          }
 
          @Override
-         public Branch getBranch() throws OseeCoreException {
+         public Branch getBranch() {
             return commonBranch;
          }
 
@@ -1193,22 +1193,22 @@ public class CoveragePackageImportTest {
          }
 
          @Override
-         public Result save() throws OseeCoreException {
+         public Result save() {
             return Result.TrueResult;
          }
 
          @Override
-         public Result save(Collection<ICoverage> coverages) throws OseeCoreException {
+         public Result save(Collection<ICoverage> coverages) {
             return Result.TrueResult;
          }
 
          @Override
-         public Result saveImportRecord(SkynetTransaction transaction, CoverageImport coverageImport) throws OseeCoreException {
+         public Result saveImportRecord(SkynetTransaction transaction, CoverageImport coverageImport) {
             return Result.TrueResult;
          }
 
          @Override
-         public Branch getBranch() throws OseeCoreException {
+         public Branch getBranch() {
             return commonBranch;
          }
 
diff --git a/plugins/org.eclipse.osee.coverage.test/src/org/eclipse/osee/coverage/test/Coverage_Suite.java b/plugins/org.eclipse.osee.coverage.test/src/org/eclipse/osee/coverage/test/Coverage_Suite.java
index d1b53e1a535..7cf5b346b0d 100644
--- a/plugins/org.eclipse.osee.coverage.test/src/org/eclipse/osee/coverage/test/Coverage_Suite.java
+++ b/plugins/org.eclipse.osee.coverage.test/src/org/eclipse/osee/coverage/test/Coverage_Suite.java
@@ -14,7 +14,6 @@ import org.eclipse.osee.coverage.test.model.CoverageItemTest;
 import org.eclipse.osee.coverage.test.model.CoverageOptionManagerTest;
 import org.eclipse.osee.coverage.test.model.CoverageUnitTest;
 import org.eclipse.osee.coverage.test.model.SimpleTestUnitProviderTest;
-import org.junit.BeforeClass;
 import org.junit.runner.RunWith;
 import org.junit.runners.Suite;
 
@@ -25,7 +24,5 @@ import org.junit.runners.Suite;
  * @author Donald G. Dunne
  */
 public class Coverage_Suite {
-   @BeforeClass
-   public static void setUp() throws Exception {
-   }
+   // do nothing
 }
diff --git a/plugins/org.eclipse.osee.coverage.test/src/org/eclipse/osee/coverage/test/VectorCastImportTest.java b/plugins/org.eclipse.osee.coverage.test/src/org/eclipse/osee/coverage/test/VectorCastImportTest.java
index 9e760f68c2e..4361b112025 100644
--- a/plugins/org.eclipse.osee.coverage.test/src/org/eclipse/osee/coverage/test/VectorCastImportTest.java
+++ b/plugins/org.eclipse.osee.coverage.test/src/org/eclipse/osee/coverage/test/VectorCastImportTest.java
@@ -145,17 +145,17 @@ public class VectorCastImportTest {
          }
 
          @Override
-         public Result save() throws OseeCoreException {
+         public Result save() {
             return Result.TrueResult;
          }
 
          @Override
-         public Result save(Collection<ICoverage> coverages) throws OseeCoreException {
+         public Result save(Collection<ICoverage> coverages) {
             return Result.TrueResult;
          }
 
          @Override
-         public Result saveImportRecord(SkynetTransaction transaction, CoverageImport coverageImport) throws OseeCoreException {
+         public Result saveImportRecord(SkynetTransaction transaction, CoverageImport coverageImport) {
             return Result.TrueResult;
          }
 
diff --git a/plugins/org.eclipse.osee.coverage.test/src/org/eclipse/osee/coverage/test/model/CoverageItemTest.java b/plugins/org.eclipse.osee.coverage.test/src/org/eclipse/osee/coverage/test/model/CoverageItemTest.java
index 14471a4925c..014099854a5 100644
--- a/plugins/org.eclipse.osee.coverage.test/src/org/eclipse/osee/coverage/test/model/CoverageItemTest.java
+++ b/plugins/org.eclipse.osee.coverage.test/src/org/eclipse/osee/coverage/test/model/CoverageItemTest.java
@@ -204,7 +204,7 @@ public class CoverageItemTest {
     * @throws OseeCoreException
     */
    @Test
-   public void testSetGetText() throws OseeCoreException {
+   public void testSetGetText() {
       ci1.setName("this is text2");
       Assert.assertEquals("this is text2", ci1.getFileContents());
       ci1.setName("this is text");
@@ -253,7 +253,7 @@ public class CoverageItemTest {
     * Test method for {@link org.eclipse.osee.coverage.model.CoverageItem#getAssignees()}.
     */
    @Test
-   public void testGetAssignees() throws OseeCoreException {
+   public void testGetAssignees() {
       Assert.assertEquals("", ci1.getAssignees());
    }
 
diff --git a/plugins/org.eclipse.osee.coverage.test/src/org/eclipse/osee/coverage/test/model/CoverageOptionManagerStoreTest.java b/plugins/org.eclipse.osee.coverage.test/src/org/eclipse/osee/coverage/test/model/CoverageOptionManagerStoreTest.java
index 7a7e992689d..f5e968e4e1e 100644
--- a/plugins/org.eclipse.osee.coverage.test/src/org/eclipse/osee/coverage/test/model/CoverageOptionManagerStoreTest.java
+++ b/plugins/org.eclipse.osee.coverage.test/src/org/eclipse/osee/coverage/test/model/CoverageOptionManagerStoreTest.java
@@ -22,7 +22,6 @@ import org.eclipse.osee.coverage.store.OseeCoveragePackageStore;
 import org.eclipse.osee.coverage.util.CoverageUtil;
 import org.eclipse.osee.framework.core.enums.CoreArtifactTypes;
 import org.eclipse.osee.framework.core.enums.CoreAttributeTypes;
-import org.eclipse.osee.framework.core.exception.ArtifactDoesNotExist;
 import org.eclipse.osee.framework.core.exception.OseeCoreException;
 import org.eclipse.osee.framework.skynet.core.artifact.Artifact;
 import org.eclipse.osee.framework.skynet.core.artifact.BranchManager;
@@ -56,18 +55,6 @@ public class CoverageOptionManagerStoreTest {
       transaction.execute();
    }
 
-   private static Artifact getCoveragePackageArt() throws OseeCoreException {
-      try {
-         Artifact artifact =
-            ArtifactQuery.getArtifactFromTypeAndName(CoverageArtifactTypes.CoveragePackage,
-               CoverageOptionManagerStoreTest.class.getSimpleName(), BranchManager.getCommonBranch());
-         return artifact;
-      } catch (ArtifactDoesNotExist ex) {
-         // do nothing
-      }
-      return null;
-   }
-
    @Test
    public void testCoverageOptionManagerStore() throws OseeCoreException {
       CoverageUtil.setNavigatorSelectedBranch(BranchManager.getCommonBranch());
diff --git a/plugins/org.eclipse.osee.coverage.test/src/org/eclipse/osee/coverage/test/model/CoverageUnitPersistTest.java b/plugins/org.eclipse.osee.coverage.test/src/org/eclipse/osee/coverage/test/model/CoverageUnitPersistTest.java
index c209d88110d..0c81eebb657 100644
--- a/plugins/org.eclipse.osee.coverage.test/src/org/eclipse/osee/coverage/test/model/CoverageUnitPersistTest.java
+++ b/plugins/org.eclipse.osee.coverage.test/src/org/eclipse/osee/coverage/test/model/CoverageUnitPersistTest.java
@@ -137,12 +137,12 @@ public class CoverageUnitPersistTest {
          }
 
          @Override
-         public Result save(Collection<ICoverage> coverages) throws OseeCoreException {
+         public Result save(Collection<ICoverage> coverages) {
             return Result.TrueResult;
          }
 
          @Override
-         public Result saveImportRecord(SkynetTransaction transaction, CoverageImport coverageImport) throws OseeCoreException {
+         public Result saveImportRecord(SkynetTransaction transaction, CoverageImport coverageImport) {
             return null;
          }
 
diff --git a/plugins/org.eclipse.osee.coverage.test/src/org/eclipse/osee/coverage/test/model/SimpleTestUnitProviderTest.java b/plugins/org.eclipse.osee.coverage.test/src/org/eclipse/osee/coverage/test/model/SimpleTestUnitProviderTest.java
index 4b6e12aa0d0..709fe5dd627 100644
--- a/plugins/org.eclipse.osee.coverage.test/src/org/eclipse/osee/coverage/test/model/SimpleTestUnitProviderTest.java
+++ b/plugins/org.eclipse.osee.coverage.test/src/org/eclipse/osee/coverage/test/model/SimpleTestUnitProviderTest.java
@@ -42,7 +42,7 @@ public class SimpleTestUnitProviderTest {
     * @throws OseeCoreException
     */
    @Test
-   public void testAddGetTestUnits() throws OseeCoreException {
+   public void testAddGetTestUnits() {
       provider.addTestUnit(coverageItem1, "Test Unit 1");
       provider.addTestUnit(coverageItem1, "Test Unit 2");
       provider.addTestUnit(coverageItem1, "Test Unit 3");
diff --git a/plugins/org.eclipse.osee.coverage.test/src/org/eclipse/osee/coverage/test/navigate/CoverageTestNavigateViews.java b/plugins/org.eclipse.osee.coverage.test/src/org/eclipse/osee/coverage/test/navigate/CoverageTestNavigateViews.java
index c7d6b34a75e..9e3218b739e 100644
--- a/plugins/org.eclipse.osee.coverage.test/src/org/eclipse/osee/coverage/test/navigate/CoverageTestNavigateViews.java
+++ b/plugins/org.eclipse.osee.coverage.test/src/org/eclipse/osee/coverage/test/navigate/CoverageTestNavigateViews.java
@@ -24,7 +24,6 @@ import org.eclipse.osee.coverage.test.import7.CoveragePackage1Import7;
 import org.eclipse.osee.coverage.test.import8.CoveragePackage1Import8;
 import org.eclipse.osee.coverage.test.import9.CoveragePackage1Import9;
 import org.eclipse.osee.coverage.test.package1.CoveragePackage1;
-import org.eclipse.osee.framework.core.exception.OseeCoreException;
 import org.eclipse.osee.framework.ui.plugin.OseeUiActivator;
 import org.eclipse.osee.framework.ui.plugin.xnavigate.XNavigateItem;
 
@@ -38,7 +37,7 @@ public class CoverageTestNavigateViews implements ICoverageNavigateItem {
    }
 
    @Override
-   public List<XNavigateItem> getNavigateItems() throws OseeCoreException {
+   public List<XNavigateItem> getNavigateItems() {
 
       List<XNavigateItem> items = new ArrayList<XNavigateItem>();