refactor[ats_ATS284247]: Add missing null checks

Signed-off-by: Morgan E. Cook <Morgan.e.cook@boeing.com>
Change-Id: Ib9f7cd6fac1690741e653c574107a3a010390b44
Signed-off-by: Morgan E. Cook <Morgan.e.cook@boeing.com>

6 files changed, 11 insertions, 0 deletions

diff --git a/plugins/org.eclipse.osee.ats.client.integration.tests/src/org/eclipse/osee/ats/client/integration/tests/ats/column/EstimatedHoursColumnTest.java b/plugins/org.eclipse.osee.ats.client.integration.tests/src/org/eclipse/osee/ats/client/integration/tests/ats/column/EstimatedHoursColumnTest.java
index 296becc8eb7..1056cc09d2a 100644
--- a/plugins/org.eclipse.osee.ats.client.integration.tests/src/org/eclipse/osee/ats/client/integration/tests/ats/column/EstimatedHoursColumnTest.java
+++ b/plugins/org.eclipse.osee.ats.client.integration.tests/src/org/eclipse/osee/ats/client/integration/tests/ats/column/EstimatedHoursColumnTest.java
@@ -87,6 +87,8 @@ public class EstimatedHoursColumnTest {
       Assert.assertEquals(0.0, EstimatedHoursUtil.getEstimatedHours(taskArt2), 0);
       Assert.assertEquals(0.0, EstimatedHoursUtil.getEstimatedHours(peerArt), 0);
 
+      Assert.assertNotNull(taskArt1);
+
       taskArt1.setSoleAttributeValue(AtsAttributeTypes.EstimatedHours, 1.4);
       taskArt1.persist(getClass().getSimpleName());
       Assert.assertEquals(2.8, EstimatedHoursUtil.getEstimatedHours(actionArt), 0);
@@ -114,6 +116,7 @@ public class EstimatedHoursColumnTest {
       Assert.assertEquals(0.0, EstimatedHoursUtil.getEstimatedHours(taskArt2), 0);
       Assert.assertEquals(4.0, EstimatedHoursUtil.getEstimatedHours(peerArt), 0);
 
+      Assert.assertNotNull(taskArt2);
       taskArt2.setSoleAttributeValue(AtsAttributeTypes.EstimatedHours, 0.1);
       taskArt2.persist(getClass().getSimpleName());
       Assert.assertEquals(9.0, EstimatedHoursUtil.getEstimatedHours(actionArt), 0);
diff --git a/plugins/org.eclipse.osee.ats.client.integration.tests/src/org/eclipse/osee/ats/client/integration/tests/ats/config/AtsBranchConfigurationTest.java b/plugins/org.eclipse.osee.ats.client.integration.tests/src/org/eclipse/osee/ats/client/integration/tests/ats/config/AtsBranchConfigurationTest.java
index 460ede334d7..555ea4cdc79 100644
--- a/plugins/org.eclipse.osee.ats.client.integration.tests/src/org/eclipse/osee/ats/client/integration/tests/ats/config/AtsBranchConfigurationTest.java
+++ b/plugins/org.eclipse.osee.ats.client.integration.tests/src/org/eclipse/osee/ats/client/integration/tests/ats/config/AtsBranchConfigurationTest.java
@@ -61,6 +61,7 @@ import org.eclipse.osee.framework.skynet.core.transaction.TransactionManager;
 import org.eclipse.osee.framework.ui.plugin.util.AWorkbench;
 import org.eclipse.osee.support.test.util.TestUtil;
 import org.junit.After;
+import org.junit.Assert;
 import org.junit.Before;
 
 /**
@@ -140,6 +141,8 @@ public class AtsBranchConfigurationTest {
             version2Uuid = vArt.getUuid();
          }
       }
+
+      Assert.assertNotNull(versionToTarget);
       versionToTarget.setBaselineBranchUuid(viaTeamDefBranch.getUuid());
       versionToTarget.setAllowCommitBranch(true);
       versionToTarget.setAllowCreateBranch(true);
diff --git a/plugins/org.eclipse.osee.ats.client.integration.tests/src/org/eclipse/osee/ats/client/integration/tests/ats/util/AtsChangeSetTest.java b/plugins/org.eclipse.osee.ats.client.integration.tests/src/org/eclipse/osee/ats/client/integration/tests/ats/util/AtsChangeSetTest.java
index 88f8dd2fc03..45e0149830b 100644
--- a/plugins/org.eclipse.osee.ats.client.integration.tests/src/org/eclipse/osee/ats/client/integration/tests/ats/util/AtsChangeSetTest.java
+++ b/plugins/org.eclipse.osee.ats.client.integration.tests/src/org/eclipse/osee/ats/client/integration/tests/ats/util/AtsChangeSetTest.java
@@ -173,6 +173,7 @@ public class AtsChangeSetTest {
             break;
          }
       }
+      Assert.assertNotNull(staticIdAttr);
 
       IAtsChangeSet changes = createAtsChangeSet();
       changes.setAttribute(folderArt, staticIdAttr.getId(), "new id");
diff --git a/plugins/org.eclipse.osee.ats.client.integration.tests/src/org/eclipse/osee/ats/client/integration/tests/ats/util/AtsProgramServiceTest.java b/plugins/org.eclipse.osee.ats.client.integration.tests/src/org/eclipse/osee/ats/client/integration/tests/ats/util/AtsProgramServiceTest.java
index 39cf5a84371..f3ff5a96173 100644
--- a/plugins/org.eclipse.osee.ats.client.integration.tests/src/org/eclipse/osee/ats/client/integration/tests/ats/util/AtsProgramServiceTest.java
+++ b/plugins/org.eclipse.osee.ats.client.integration.tests/src/org/eclipse/osee/ats/client/integration/tests/ats/util/AtsProgramServiceTest.java
@@ -103,10 +103,12 @@ public class AtsProgramServiceTest {
          }
       }
 
+      Assert.assertNotNull(commInsertion);
       Collection<IAtsInsertionActivity> activities = programService.getInsertionActivities(commInsertion);
       assertEquals(2, activities.size());
 
       IAtsInsertion insertion = programService.getInsertion(activities.iterator().next());
+
       assertEquals(commInsertion.getUuid(), insertion.getUuid());
 
       Long uuid = activities.iterator().next().getUuid();
diff --git a/plugins/org.eclipse.osee.ats.client.integration.tests/src/org/eclipse/osee/ats/client/integration/tests/ats/util/AtsXWidgetsExampleBlamTest.java b/plugins/org.eclipse.osee.ats.client.integration.tests/src/org/eclipse/osee/ats/client/integration/tests/ats/util/AtsXWidgetsExampleBlamTest.java
index 6ce9a44059d..c783a44b5f4 100644
--- a/plugins/org.eclipse.osee.ats.client.integration.tests/src/org/eclipse/osee/ats/client/integration/tests/ats/util/AtsXWidgetsExampleBlamTest.java
+++ b/plugins/org.eclipse.osee.ats.client.integration.tests/src/org/eclipse/osee/ats/client/integration/tests/ats/util/AtsXWidgetsExampleBlamTest.java
@@ -47,6 +47,7 @@ public class AtsXWidgetsExampleBlamTest {
       }
 
       Assert.assertTrue(String.format("%s not found from list of provided Blams.", NAME_OF_ATS_ITEM), foundBlam);
+      Assert.assertNotNull(item);
       item.run(TableLoadOption.ForcePend, TableLoadOption.NoUI);
 
       Assert.assertTrue(
diff --git a/plugins/org.eclipse.osee.ats.client.integration.tests/src/org/eclipse/osee/ats/client/integration/tests/ats/util/ImportActionsViaSpreadsheetTest.java b/plugins/org.eclipse.osee.ats.client.integration.tests/src/org/eclipse/osee/ats/client/integration/tests/ats/util/ImportActionsViaSpreadsheetTest.java
index bbbf9ff6b01..230aa3d61f2 100644
--- a/plugins/org.eclipse.osee.ats.client.integration.tests/src/org/eclipse/osee/ats/client/integration/tests/ats/util/ImportActionsViaSpreadsheetTest.java
+++ b/plugins/org.eclipse.osee.ats.client.integration.tests/src/org/eclipse/osee/ats/client/integration/tests/ats/util/ImportActionsViaSpreadsheetTest.java
@@ -96,6 +96,7 @@ public class ImportActionsViaSpreadsheetTest {
       Assert.assertEquals(2, codeCount);
       Assert.assertEquals(1, testCount);
 
+      Assert.assertNotNull(testWf);
       Assert.assertEquals("What needs to be done by Test team", testWf.getDescription());
       Assert.assertEquals("5", testWf.getSoleAttributeValue(AtsAttributeTypes.PriorityType, ""));
       Assert.assertTrue(testWf.getSoleAttributeValue(AtsAttributeTypes.EstimatedHours, 0.0) == 4.0);