bug[ats_ATS15373]: Cleanup ats.api dependencies

Change-Id: I5f9331e9a6b7d0f12ff5072299f16a6529571ebd

4 files changed, 13 insertions, 33 deletions

diff --git a/plugins/org.eclipse.osee.ats.api/META-INF/MANIFEST.MF b/plugins/org.eclipse.osee.ats.api/META-INF/MANIFEST.MF
index 8029b2cbf93..7f38c0a5a7f 100644
--- a/plugins/org.eclipse.osee.ats.api/META-INF/MANIFEST.MF
+++ b/plugins/org.eclipse.osee.ats.api/META-INF/MANIFEST.MF
@@ -23,12 +23,8 @@ Export-Package: org.eclipse.osee.ats.api,
  org.eclipse.osee.ats.api.workflow.log,
  org.eclipse.osee.ats.api.workflow.state,
  org.eclipse.osee.ats.api.workflow.transition
-Require-Bundle: org.eclipse.core.runtime
 Import-Package: org.eclipse.osee.framework.core.data,
  org.eclipse.osee.framework.core.enums,
- org.eclipse.osee.framework.core.exception,
  org.eclipse.osee.framework.core.util,
- org.eclipse.osee.framework.database,
  org.eclipse.osee.framework.jdk.core.type,
- org.eclipse.osee.framework.jdk.core.util,
- org.eclipse.osee.framework.logging
+ org.eclipse.osee.framework.jdk.core.util
diff --git a/plugins/org.eclipse.osee.ats.api/src/org/eclipse/osee/ats/api/workdef/IAtsWorkDefinitionAdmin.java b/plugins/org.eclipse.osee.ats.api/src/org/eclipse/osee/ats/api/workdef/IAtsWorkDefinitionAdmin.java
index c0cd643febe..25f78517a3d 100644
--- a/plugins/org.eclipse.osee.ats.api/src/org/eclipse/osee/ats/api/workdef/IAtsWorkDefinitionAdmin.java
+++ b/plugins/org.eclipse.osee.ats.api/src/org/eclipse/osee/ats/api/workdef/IAtsWorkDefinitionAdmin.java
@@ -17,7 +17,6 @@ import org.eclipse.osee.ats.api.ai.IAtsActionableItem;
 import org.eclipse.osee.ats.api.review.IAtsPeerToPeerReview;
 import org.eclipse.osee.ats.api.workflow.IAtsTask;
 import org.eclipse.osee.ats.api.workflow.IAtsTeamWorkflow;
-import org.eclipse.osee.framework.core.exception.MultipleAttributesExist;
 import org.eclipse.osee.framework.core.util.XResultData;
 import org.eclipse.osee.framework.jdk.core.type.OseeCoreException;
 
@@ -54,7 +53,7 @@ public interface IAtsWorkDefinitionAdmin {
 
    IWorkDefinitionMatch getWorkDefinitionForTaskNotYetCreated(IAtsTeamWorkflow teamWf) throws OseeCoreException;
 
-   boolean isTaskOverridingItsWorkDefinition(IAtsTask task) throws MultipleAttributesExist, OseeCoreException;
+   boolean isTaskOverridingItsWorkDefinition(IAtsTask task) throws OseeCoreException;
 
    IAtsWorkDefinition getWorkDef(String id, XResultData resultData) throws Exception;
 
diff --git a/plugins/org.eclipse.osee.ats.api/src/org/eclipse/osee/ats/api/workflow/log/ILogStorageProvider.java b/plugins/org.eclipse.osee.ats.api/src/org/eclipse/osee/ats/api/workflow/log/ILogStorageProvider.java
index 580dcb675f2..5f95cd500e9 100644
--- a/plugins/org.eclipse.osee.ats.api/src/org/eclipse/osee/ats/api/workflow/log/ILogStorageProvider.java
+++ b/plugins/org.eclipse.osee.ats.api/src/org/eclipse/osee/ats/api/workflow/log/ILogStorageProvider.java
@@ -10,8 +10,8 @@
  *******************************************************************************/
 package org.eclipse.osee.ats.api.workflow.log;
 
-import org.eclipse.core.runtime.IStatus;
 import org.eclipse.osee.ats.api.util.IAtsChangeSet;
+import org.eclipse.osee.framework.core.util.Result;
 
 /**
  * @author Donald G. Dunne
@@ -20,7 +20,7 @@ public interface ILogStorageProvider {
 
    String getLogXml();
 
-   IStatus saveLogXml(String xml, IAtsChangeSet changes);
+   Result saveLogXml(String xml, IAtsChangeSet changes);
 
    String getLogTitle();
 
diff --git a/plugins/org.eclipse.osee.ats.api/src/org/eclipse/osee/ats/api/workflow/transition/TransitionResults.java b/plugins/org.eclipse.osee.ats.api/src/org/eclipse/osee/ats/api/workflow/transition/TransitionResults.java
index 540a0373daf..2724bb689c5 100644
--- a/plugins/org.eclipse.osee.ats.api/src/org/eclipse/osee/ats/api/workflow/transition/TransitionResults.java
+++ b/plugins/org.eclipse.osee.ats.api/src/org/eclipse/osee/ats/api/workflow/transition/TransitionResults.java
@@ -14,12 +14,10 @@ import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
-import java.util.logging.Level;
 import org.eclipse.osee.ats.api.IAtsWorkItem;
 import org.eclipse.osee.ats.api.workdef.ITransitionResult;
 import org.eclipse.osee.framework.core.util.XResultData;
 import org.eclipse.osee.framework.jdk.core.util.Strings;
-import org.eclipse.osee.framework.logging.OseeLog;
 
 /**
  * @author Donald G. Dunne
@@ -108,28 +106,6 @@ public class TransitionResults {
       return sb.toString();
    }
 
-   /**
-    * Log exceptions to OseeLog. Don't always want to do this due to testing.
-    */
-   public void logExceptions() {
-      for (ITransitionResult result : results) {
-         Exception ex = result.getException();
-         if (ex != null) {
-            OseeLog.log(TransitionResults.class, Level.SEVERE, result.getDetails(), ex);
-         }
-      }
-      for (IAtsWorkItem workItem : workItemToResults.keySet()) {
-         List<ITransitionResult> results = workItemToResults.get(workItem);
-         for (ITransitionResult result : results) {
-            Exception ex = result.getException();
-            if (ex != null) {
-               String message = workItem.toStringWithId() + " - " + result.getDetails();
-               OseeLog.log(TransitionResults.class, Level.SEVERE, message, ex);
-            }
-         }
-      }
-   }
-
    public void appendResultsString(StringBuffer sb, List<ITransitionResult> results) {
       for (ITransitionResult result : results) {
          sb.append("    - ");
@@ -160,4 +136,13 @@ public class TransitionResults {
    public String toString() {
       return getResultString();
    }
+
+   public List<ITransitionResult> getResults() {
+      return results;
+   }
+
+   public Map<IAtsWorkItem, List<ITransitionResult>> getWorkItemToResults() {
+      return workItemToResults;
+   }
+
 }