summaryrefslogtreecommitdiffstatsabout
diff options
context:
space:
mode:
authorelijahe2013-12-19 13:47:13 (EST)
committer Bogdan Gheorghe2013-12-19 16:30:00 (EST)
commitf422fc81e97c1ba44f356467dd751d9e409dc406 (patch)
tree3c92e4a3ea9e009c66513e2f9832dcde6b3baf5b
parent08bccba61ce37af48fb137b5951d225b3f8aed6b (diff)
downloadorg.eclipse.orion.client-f422fc81e97c1ba44f356467dd751d9e409dc406.zip
org.eclipse.orion.client-f422fc81e97c1ba44f356467dd751d9e409dc406.tar.gz
org.eclipse.orion.client-f422fc81e97c1ba44f356467dd751d9e409dc406.tar.bz2
Bug 421482 - UX: No context menu!
-Got rid of tooltips for all dropdown menu items (includes context menu items) -No longer creating command tooltips which only contain the command's name --Signed-off-by: Elijah El-Haddad <elijahe@ca.ibm.com>
-rw-r--r--bundles/org.eclipse.orion.client.ui/web/orion/commands.js9
1 files changed, 1 insertions, 8 deletions
diff --git a/bundles/org.eclipse.orion.client.ui/web/orion/commands.js b/bundles/org.eclipse.orion.client.ui/web/orion/commands.js
index 77a737e..f251b1f 100644
--- a/bundles/org.eclipse.orion.client.ui/web/orion/commands.js
+++ b/bundles/org.eclipse.orion.client.ui/web/orion/commands.js
@@ -436,13 +436,6 @@ define(['require', 'orion/util', 'orion/webui/littlelib', 'orion/webui/dropdown'
}, false);
}
}
- if (command.tooltip) {
- element.commandTooltip = new Tooltip.Tooltip({
- node: element,
- text: command.tooltip,
- position: ["right", "left", "above", "below"] //$NON-NLS-3$ //$NON-NLS-2$ //$NON-NLS-1$ //$NON-NLS-0$
- });
- }
element.className = "dropdownMenuItem"; //$NON-NLS-0$
element.role = "menuitem"; //$NON-NLS-0$
var li = document.createElement("li"); //$NON-NLS-0$
@@ -587,7 +580,7 @@ define(['require', 'orion/util', 'orion/webui/littlelib', 'orion/webui/dropdown'
_init: function(options) {
this.id = options.id; // unique id
this.name = options.name;
- this.tooltip = options.tooltip || options.name;
+ this.tooltip = options.tooltip;
this.callback = options.callback; // optional callback that should be called when command is activated (clicked)
this.hrefCallback = options.hrefCallback; // optional callback that returns an href for a command link
this.choiceCallback = options.choiceCallback; // optional callback indicating that the command will supply secondary choices.