aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorsfranklin2012-02-22 23:48:21 (EST)
committerSimon Kaegi2012-02-23 10:24:28 (EST)
commite3dd7d656818c9b6df5ac8c86778a5fa009ab025 (patch)
treee494b56a7b64e5817e9c2c44eff47f833bf0626a
parentbf46a750c0dde5f5f405d7c11b9cfe965800f5bc (diff)
downloadorg.eclipse.orion.client-e3dd7d656818c9b6df5ac8c86778a5fa009ab025.zip
org.eclipse.orion.client-e3dd7d656818c9b6df5ac8c86778a5fa009ab025.tar.gz
org.eclipse.orion.client-e3dd7d656818c9b6df5ac8c86778a5fa009ab025.tar.bz2
Bug 372182 - Performance of CommandService.renderCommands needs to be addressed. Hack2
-rw-r--r--bundles/org.eclipse.orion.client.core/web/orion/explorer-table.js14
1 files changed, 11 insertions, 3 deletions
diff --git a/bundles/org.eclipse.orion.client.core/web/orion/explorer-table.js b/bundles/org.eclipse.orion.client.core/web/orion/explorer-table.js
index e76405a..c727bf0 100644
--- a/bundles/org.eclipse.orion.client.core/web/orion/explorer-table.js
+++ b/bundles/org.eclipse.orion.client.core/web/orion/explorer-table.js
@@ -163,10 +163,18 @@ define(['require', 'dojo', 'orion/util', 'orion/explorer', 'orion/explorerNavHan
dojo.place(document.createTextNode(item.Name), link, "last");
}
// see https://bugs.eclipse.org/bugs/show_bug.cgi?id=372182
- // use a timeout so rendering is non-blocking. But we need to set a height on the parent span
- // to reduce ripple everywhere else
- dojo.style(span, {height: "28px", display: "inline-block"});
+ // use a timeout so rendering is non-blocking.
+ // TOTAL HACK...insert a temporary drop down button to get the layout the same, then remove it when
+ // we have the real menu.
+ var menuButton = new dijit.form.DropDownButton({
+ label: "Actions",
+ showLabel: false
+ });
+ dojo.addClass(menuButton.domNode, "commandMenu textless");
+ dojo.destroy(menuButton.valueNode); // the valueNode gets picked up by screen readers; since it's not used, we can get rid of it
+ dojo.place(menuButton.domNode, span, "last");
window.setTimeout(dojo.hitch(this, function() {
+ menuButton.destroyRecursive();
this.commandService.renderCommands(span, "object", item, this.explorer, "tool", false);
}), 0);
return col;