| author | Max Li | 2012-01-25 12:58:11 (EST) |
|---|---|---|
| committer | sfranklin | 2012-01-26 16:21:52 (EST) |
| commit | bc08b83abae87e9b2f0646436b9c43cbc2c89792 (patch) (side-by-side diff) | |
| tree | 26ff8fffbca29f0d4a91a0ca80f26df6ced8ba01 | |
| parent | 1d1150131dacecc9f4d9eb3cdda9103ea1819045 (diff) | |
| download | org.eclipse.orion.client-bc08b83abae87e9b2f0646436b9c43cbc2c89792.zip org.eclipse.orion.client-bc08b83abae87e9b2f0646436b9c43cbc2c89792.tar.gz org.eclipse.orion.client-bc08b83abae87e9b2f0646436b9c43cbc2c89792.tar.bz2 | |
Fix Bug 368869 - Page-specific command link bar is inaccessible
| -rw-r--r-- | bundles/org.eclipse.orion.client.core/web/orion/commands.js | 4 | ||||
| -rw-r--r-- | bundles/org.eclipse.orion.client.core/web/plugin/list.js | 8 |
2 files changed, 6 insertions, 6 deletions
diff --git a/bundles/org.eclipse.orion.client.core/web/orion/commands.js b/bundles/org.eclipse.orion.client.core/web/orion/commands.js index 2946357..520d89b 100644 --- a/bundles/org.eclipse.orion.client.core/web/orion/commands.js +++ b/bundles/org.eclipse.orion.client.core/web/orion/commands.js @@ -903,7 +903,7 @@ define(['require', 'dojo', 'dijit', 'orion/util', 'dijit/Menu', 'dijit/form/Drop }, _addTool: function(parent, forceText, name, context, activeCommandClass, inactiveCommandClass) { context.handler = context.handler || this; - var link = dojo.create("a"); + var link = dojo.create("a", {tabindex: "0", role: "button", href: "javascript:void(0)"}); // the link must have an href for keyboard use link.id = this.name+"link"; var image = null; if (forceText || !this.hasImage()) { @@ -985,7 +985,7 @@ define(['require', 'dojo', 'dijit', 'orion/util', 'dijit/Menu', 'dijit/form/Drop context.handler = context.handler || this; var element; if (this.hrefCallback) { - element = dojo.create("a"); + element = dojo.create("a", {tabindex: "0", role: "button", href: "javascript:void(0)"}); // the link must have an href for keyboard use dojo.addClass(element, "commandLink"); } else { element = dojo.create("button"); diff --git a/bundles/org.eclipse.orion.client.core/web/plugin/list.js b/bundles/org.eclipse.orion.client.core/web/plugin/list.js index 1c04b5d..437f03b 100644 --- a/bundles/org.eclipse.orion.client.core/web/plugin/list.js +++ b/bundles/org.eclipse.orion.client.core/web/plugin/list.js @@ -47,13 +47,13 @@ dojo.addOnLoad(function() { if (pageActions) { dojo.place('<input type="text" id="installUrlTextBox" value="Type a plugin URL here" style="width:16em;"></input>', pageActions, "last"); - dojo.place('<a id="installButton" title="Install the plugin specified in the edit box">Install</a>', + dojo.place('<a id="installButton" title="Install the plugin specified in the edit box" tabindex="0" role="button" href="javascript:void(0)">Install</a>', pageActions, "last"); - dojo.place('<a id="uninstallButton" title="Uninstall the selected plugins">Uninstall</a>', + dojo.place('<a id="uninstallButton" title="Uninstall the selected plugins" tabindex="0" role="button" href="javascript:void(0)">Uninstall</a>', pageActions, "last"); - dojo.place('<a id="reloadButton" title="Reload the selected plugin from its URL">Reload</a>', + dojo.place('<a id="reloadButton" title="Reload the selected plugin from its URL" tabindex="0" role="button" href="javascript:void(0)">Reload</a>', pageActions, "last"); - dojo.place('<a id="copyButton" title="Copy the selected location into the install edit box">Copy Location</a>', + dojo.place('<a id="copyButton" title="Copy the selected location into the install edit box" tabindex="0" role="button" href="javascript:void(0)">Copy Location</a>', pageActions, "last"); |

