aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMax Li2012-01-26 17:23:44 (EST)
committersfranklin2012-01-26 17:23:44 (EST)
commitb35bd19b2e9c12dca973ad4a30613eae2a4b6f1f (patch)
tree070b041ddab42d2df0eeab1d1d4ea5f1b0902b08
parent41d4f9e81fc1bfd3c9adfe25480321088e30549f (diff)
downloadorg.eclipse.orion.client-b35bd19b2e9c12dca973ad4a30613eae2a4b6f1f.zip
org.eclipse.orion.client-b35bd19b2e9c12dca973ad4a30613eae2a4b6f1f.tar.gz
org.eclipse.orion.client-b35bd19b2e9c12dca973ad4a30613eae2a4b6f1f.tar.bz2
Bug 368851 - Help command list inaccessible
-rw-r--r--bundles/org.eclipse.orion.client.core/web/orion/commands.js2
-rw-r--r--bundles/org.eclipse.orion.client.core/web/orion/globalCommands.js5
2 files changed, 4 insertions, 3 deletions
diff --git a/bundles/org.eclipse.orion.client.core/web/orion/commands.js b/bundles/org.eclipse.orion.client.core/web/orion/commands.js
index 520d89b..9434183 100644
--- a/bundles/org.eclipse.orion.client.core/web/orion/commands.js
+++ b/bundles/org.eclipse.orion.client.core/web/orion/commands.js
@@ -363,7 +363,7 @@ define(['require', 'dojo', 'dijit', 'orion/util', 'dijit/Menu', 'dijit/form/Drop
showKeyBindings: function(targetNode) {
for (var binding in this._activeBindings) {
if (this._activeBindings[binding] && this._activeBindings[binding].keyBinding && this._activeBindings[binding].command) {
- dojo.place("<span>"+mUtil.getUserKeyString(this._activeBindings[binding].keyBinding)+" = "+this._activeBindings[binding].command.name+"<br></span>", targetNode, "last");
+ dojo.place("<span role=\"listitem\">"+mUtil.getUserKeyString(this._activeBindings[binding].keyBinding)+" = "+this._activeBindings[binding].command.name+"<br></span>", targetNode, "last");
}
}
},
diff --git a/bundles/org.eclipse.orion.client.core/web/orion/globalCommands.js b/bundles/org.eclipse.orion.client.core/web/orion/globalCommands.js
index e049c62..aebf119 100644
--- a/bundles/org.eclipse.orion.client.core/web/orion/globalCommands.js
+++ b/bundles/org.eclipse.orion.client.core/web/orion/globalCommands.js
@@ -501,7 +501,8 @@ define(['require', 'dojo', 'dijit', 'orion/commands', 'orion/util', 'orion/textv
// place an empty div for keyAssist
- dojo.place('<div id="keyAssist" style="display: none"; class="keyAssistFloat"></div>', document.body, "last");
+ dojo.place('<div id="keyAssist" style="display: none" class="keyAssistFloat" role="list" aria-atomic="true" aria-live="assertive"></div>', document.body, "last");
+
// generate primary nav links.
var primaryNav = dojo.byId("primaryNav");
@@ -664,7 +665,7 @@ define(['require', 'dojo', 'dijit', 'orion/commands', 'orion/util', 'orion/textv
var actionName = editorActions[i];
var bindings = editor.getTextView().getKeyBindings(actionName);
for (var j=0; j<bindings.length; j++) {
- dojo.place("<span>"+mUtil.getUserKeyString(bindings[j])+" = " + actionName + "<br></span>", keyAssistNode, "last");
+ dojo.place("<span role=\"listitem\">"+mUtil.getUserKeyString(bindings[j])+" = " + actionName + "<br></span>", keyAssistNode, "last");
}
}
}