| author | Max Li | 2012-01-26 17:23:44 (EST) |
|---|---|---|
| committer | sfranklin | 2012-01-26 17:23:44 (EST) |
| commit | 35a1d0252d37238f3f024ec1b11e900be7821282 (patch) (side-by-side diff) | |
| tree | 070b041ddab42d2df0eeab1d1d4ea5f1b0902b08 | |
| parent | a82f626fd29cd7252aea95e6a61ac0f7371ab0af (diff) | |
| download | org.eclipse.orion.client-35a1d0252d37238f3f024ec1b11e900be7821282.zip org.eclipse.orion.client-35a1d0252d37238f3f024ec1b11e900be7821282.tar.gz org.eclipse.orion.client-35a1d0252d37238f3f024ec1b11e900be7821282.tar.bz2 | |
Bug 368851 - Help command list inaccessible
| -rw-r--r-- | bundles/org.eclipse.orion.client.core/web/orion/commands.js | 2 | ||||
| -rw-r--r-- | bundles/org.eclipse.orion.client.core/web/orion/globalCommands.js | 5 |
2 files changed, 4 insertions, 3 deletions
diff --git a/bundles/org.eclipse.orion.client.core/web/orion/commands.js b/bundles/org.eclipse.orion.client.core/web/orion/commands.js index 520d89b..9434183 100644 --- a/bundles/org.eclipse.orion.client.core/web/orion/commands.js +++ b/bundles/org.eclipse.orion.client.core/web/orion/commands.js @@ -363,7 +363,7 @@ define(['require', 'dojo', 'dijit', 'orion/util', 'dijit/Menu', 'dijit/form/Drop showKeyBindings: function(targetNode) { for (var binding in this._activeBindings) { if (this._activeBindings[binding] && this._activeBindings[binding].keyBinding && this._activeBindings[binding].command) { - dojo.place("<span>"+mUtil.getUserKeyString(this._activeBindings[binding].keyBinding)+" = "+this._activeBindings[binding].command.name+"<br></span>", targetNode, "last"); + dojo.place("<span role=\"listitem\">"+mUtil.getUserKeyString(this._activeBindings[binding].keyBinding)+" = "+this._activeBindings[binding].command.name+"<br></span>", targetNode, "last"); } } }, diff --git a/bundles/org.eclipse.orion.client.core/web/orion/globalCommands.js b/bundles/org.eclipse.orion.client.core/web/orion/globalCommands.js index e049c62..aebf119 100644 --- a/bundles/org.eclipse.orion.client.core/web/orion/globalCommands.js +++ b/bundles/org.eclipse.orion.client.core/web/orion/globalCommands.js @@ -501,7 +501,8 @@ define(['require', 'dojo', 'dijit', 'orion/commands', 'orion/util', 'orion/textv // place an empty div for keyAssist - dojo.place('<div id="keyAssist" style="display: none"; class="keyAssistFloat"></div>', document.body, "last"); + dojo.place('<div id="keyAssist" style="display: none" class="keyAssistFloat" role="list" aria-atomic="true" aria-live="assertive"></div>', document.body, "last"); + // generate primary nav links. var primaryNav = dojo.byId("primaryNav"); @@ -664,7 +665,7 @@ define(['require', 'dojo', 'dijit', 'orion/commands', 'orion/util', 'orion/textv var actionName = editorActions[i]; var bindings = editor.getTextView().getKeyBindings(actionName); for (var j=0; j<bindings.length; j++) { - dojo.place("<span>"+mUtil.getUserKeyString(bindings[j])+" = " + actionName + "<br></span>", keyAssistNode, "last"); + dojo.place("<span role=\"listitem\">"+mUtil.getUserKeyString(bindings[j])+" = " + actionName + "<br></span>", keyAssistNode, "last"); } } } |