From 0d8225e9483fb56e2a1f86af6d6f89a943553ea5 Mon Sep 17 00:00:00 2001
From: Steffen Pingel
Date: Mon, 8 Apr 2013 14:45:50 +0200
Subject: 394850: add progress monitoring for attachments

Change-Id: I181cccd051a005e4651652af20145a5eda3626a8
Task-Url: https://bugs.eclipse.org/bugs/show_bug.cgi?id=394850
---
 .../src/org/eclipse/mylyn/internal/trac/core/Messages.java            | 2 ++
 .../org/eclipse/mylyn/internal/trac/core/TracAttachmentHandler.java   | 4 ++++
 .../src/org/eclipse/mylyn/internal/trac/core/messages.properties      | 1 +
 3 files changed, 7 insertions(+)

(limited to 'org.eclipse.mylyn.trac.core')

diff --git a/org.eclipse.mylyn.trac.core/src/org/eclipse/mylyn/internal/trac/core/Messages.java b/org.eclipse.mylyn.trac.core/src/org/eclipse/mylyn/internal/trac/core/Messages.java
index 73e3f7045..bbf64894f 100644
--- a/org.eclipse.mylyn.trac.core/src/org/eclipse/mylyn/internal/trac/core/Messages.java
+++ b/org.eclipse.mylyn.trac.core/src/org/eclipse/mylyn/internal/trac/core/Messages.java
@@ -25,6 +25,8 @@ public class Messages extends NLS {
 		NLS.initializeMessages(BUNDLE_NAME, Messages.class);
 	}
 
+	public static String TracAttachmentHandler_Downloading_attachment;
+
 	public static String TracAttachmentHandler_Uploading_attachment;
 
 	public static String TracAttribute_Assigned_to;
diff --git a/org.eclipse.mylyn.trac.core/src/org/eclipse/mylyn/internal/trac/core/TracAttachmentHandler.java b/org.eclipse.mylyn.trac.core/src/org/eclipse/mylyn/internal/trac/core/TracAttachmentHandler.java
index 9fc9352da..4341f8672 100644
--- a/org.eclipse.mylyn.trac.core/src/org/eclipse/mylyn/internal/trac/core/TracAttachmentHandler.java
+++ b/org.eclipse.mylyn.trac.core/src/org/eclipse/mylyn/internal/trac/core/TracAttachmentHandler.java
@@ -51,7 +51,9 @@ public class TracAttachmentHandler extends AbstractTaskAttachmentHandler {
 							+ repository.getRepositoryUrl() + " failed, missing attachment filename.")); //$NON-NLS-1$
 		}
 
+		monitor = Policy.monitorFor(monitor);
 		try {
+			monitor.beginTask(Messages.TracAttachmentHandler_Downloading_attachment, IProgressMonitor.UNKNOWN);
 			ITracClient client = connector.getClientManager().getTracClient(repository);
 			int id = Integer.parseInt(task.getTaskId());
 			return client.getAttachmentData(id, filename, monitor);
@@ -59,6 +61,8 @@ public class TracAttachmentHandler extends AbstractTaskAttachmentHandler {
 			throw e;
 		} catch (Exception e) {
 			throw new CoreException(TracCorePlugin.toStatus(e, repository));
+		} finally {
+			monitor.done();
 		}
 	}
 
diff --git a/org.eclipse.mylyn.trac.core/src/org/eclipse/mylyn/internal/trac/core/messages.properties b/org.eclipse.mylyn.trac.core/src/org/eclipse/mylyn/internal/trac/core/messages.properties
index 5341e46a9..0cf06b02c 100644
--- a/org.eclipse.mylyn.trac.core/src/org/eclipse/mylyn/internal/trac/core/messages.properties
+++ b/org.eclipse.mylyn.trac.core/src/org/eclipse/mylyn/internal/trac/core/messages.properties
@@ -8,6 +8,7 @@
 # Contributors:
 #      Steffen Pingel - initial API and implementation
 ###############################################################################
+TracAttachmentHandler_Downloading_attachment=Downloading attachment
 TracAttachmentHandler_Uploading_attachment=Uploading attachment
 
 TracAttribute_Assigned_to=Assigned to:
-- 
cgit v1.2.3