From acb48310b78598fc0f37ac3bf1b262bc0ee7feb5 Mon Sep 17 00:00:00 2001 From: Frank Becker Date: Sun, 24 Jul 2016 20:47:09 +0200 Subject: 498401: fix ContentAssist for "Add CC:" Change-Id: I6ba24b3272b4015c6976d102d7ef6b107f54c2b2 Task-Url: https://bugs.eclipse.org/bugs/show_bug.cgi?id=498401 --- .../ui/editors/AttributeEditorToolkitTest.java | 24 ++++++++++++++-------- 1 file changed, 16 insertions(+), 8 deletions(-) (limited to 'org.eclipse.mylyn.tasks.ui.tests') diff --git a/org.eclipse.mylyn.tasks.ui.tests/src/org/eclipse/mylyn/tasks/ui/editors/AttributeEditorToolkitTest.java b/org.eclipse.mylyn.tasks.ui.tests/src/org/eclipse/mylyn/tasks/ui/editors/AttributeEditorToolkitTest.java index 1ff7ac11b..44b0183f6 100644 --- a/org.eclipse.mylyn.tasks.ui.tests/src/org/eclipse/mylyn/tasks/ui/editors/AttributeEditorToolkitTest.java +++ b/org.eclipse.mylyn.tasks.ui.tests/src/org/eclipse/mylyn/tasks/ui/editors/AttributeEditorToolkitTest.java @@ -26,6 +26,7 @@ import org.eclipse.jface.fieldassist.IContentProposalProvider; import org.eclipse.mylyn.commons.workbench.WorkbenchUtil; import org.eclipse.mylyn.commons.workbench.editors.CommonTextSupport; import org.eclipse.mylyn.internal.tasks.ui.OptionsProposalProvider; +import org.eclipse.mylyn.internal.tasks.ui.PersonProposalProvider; import org.eclipse.mylyn.internal.tasks.ui.editors.LabelsAttributeEditor; import org.eclipse.mylyn.internal.tasks.ui.editors.MultiSelectionAttributeEditor; import org.eclipse.mylyn.internal.tasks.ui.editors.SingleSelectionAttributeEditor; @@ -109,23 +110,30 @@ public class AttributeEditorToolkitTest { @Test public void testAdaptLabelsAttributeEditor() { - assertOptionsProposalProvider(true); - assertOptionsProposalProvider(false); + assertOptionsProposalProvider(true, false); + assertOptionsProposalProvider(false, false); + assertOptionsProposalProvider(true, true); } - private void assertOptionsProposalProvider(boolean isMultiSelect) { - taskAttribute.getMetaData().setType( - isMultiSelect ? TaskAttribute.TYPE_MULTI_SELECT : TaskAttribute.TYPE_SINGLE_SELECT); + private void assertOptionsProposalProvider(boolean isMultiSelect, boolean isPerson) { + taskAttribute.getMetaData().setKind(isPerson ? TaskAttribute.KIND_PEOPLE : TaskAttribute.KIND_DEFAULT); + taskAttribute.getMetaData() + .setType(isMultiSelect ? TaskAttribute.TYPE_MULTI_SELECT : TaskAttribute.TYPE_SINGLE_SELECT); LabelsAttributeEditor editor = new LabelsAttributeEditor(taskDataModel, taskAttribute); editor.createControl(WorkbenchUtil.getShell(), formToolkit); toolkit.adapt(editor); verify(toolkit).createContentProposalProvider(editor); - ArgumentCaptor providerCaptor = ArgumentCaptor.forClass(IContentProposalProvider.class); + ArgumentCaptor providerCaptor = ArgumentCaptor + .forClass(IContentProposalProvider.class); verify(toolkit).createContentAssistCommandAdapter(eq(editor.getControl()), providerCaptor.capture()); IContentProposalProvider proposalProvider = providerCaptor.getValue(); - assertTrue(proposalProvider instanceof OptionsProposalProvider); - assertEquals(isMultiSelect, ((OptionsProposalProvider) proposalProvider).isMultiSelect()); + if (isPerson) { + assertTrue(proposalProvider instanceof PersonProposalProvider); + } else { + assertTrue(proposalProvider instanceof OptionsProposalProvider); + assertEquals(isMultiSelect, ((OptionsProposalProvider) proposalProvider).isMultiSelect()); + } assertNull(toolkit.commandAdapter.getAutoActivationCharacters()); } -- cgit v1.2.3