From f0a938ef1ecb5be71a68e7203e65bdfcea888d3c Mon Sep 17 00:00:00 2001
From: Steffen Pingel
Date: Fri, 16 Sep 2011 18:36:16 +0200
Subject: bug 309255: unable to open the trac ticket
 https://bugs.eclipse.org/bugs/show_bug.cgi?id=309255

Change-Id: Ie878e68336aa3bcf41c39bfaaac6c38fd11cc2e3
---
 .../org/eclipse/mylyn/internal/trac/core/TracClientFactory.java  | 5 +++--
 .../eclipse/mylyn/trac/tests/client/TracClientFactoryTest.java   | 9 +++------
 2 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/org.eclipse.mylyn.trac.core/src/org/eclipse/mylyn/internal/trac/core/TracClientFactory.java b/org.eclipse.mylyn.trac.core/src/org/eclipse/mylyn/internal/trac/core/TracClientFactory.java
index 1ce976ada..a44433831 100644
--- a/org.eclipse.mylyn.trac.core/src/org/eclipse/mylyn/internal/trac/core/TracClientFactory.java
+++ b/org.eclipse.mylyn.trac.core/src/org/eclipse/mylyn/internal/trac/core/TracClientFactory.java
@@ -16,11 +16,11 @@ import java.net.MalformedURLException;
 import org.eclipse.core.runtime.NullProgressMonitor;
 import org.eclipse.mylyn.commons.net.AbstractWebLocation;
 import org.eclipse.mylyn.internal.trac.core.client.ITracClient;
+import org.eclipse.mylyn.internal.trac.core.client.ITracClient.Version;
 import org.eclipse.mylyn.internal.trac.core.client.TracException;
 import org.eclipse.mylyn.internal.trac.core.client.TracLoginException;
 import org.eclipse.mylyn.internal.trac.core.client.TracWebClient;
 import org.eclipse.mylyn.internal.trac.core.client.TracXmlRpcClient;
-import org.eclipse.mylyn.internal.trac.core.client.ITracClient.Version;
 
 /**
  * @author Steffen Pingel
@@ -34,7 +34,8 @@ public class TracClientFactory {
 			return new TracXmlRpcClient(location, version);
 		}
 
-		throw new RuntimeException("Invalid repository version: " + version); //$NON-NLS-1$
+		// fall-back to XML_RPC in case the repository information is incomplete
+		return new TracXmlRpcClient(location, Version.XML_RPC);
 	}
 
 	/**
diff --git a/org.eclipse.mylyn.trac.tests/src/org/eclipse/mylyn/trac/tests/client/TracClientFactoryTest.java b/org.eclipse.mylyn.trac.tests/src/org/eclipse/mylyn/trac/tests/client/TracClientFactoryTest.java
index 27a7a41db..31a6e5fc1 100644
--- a/org.eclipse.mylyn.trac.tests/src/org/eclipse/mylyn/trac/tests/client/TracClientFactoryTest.java
+++ b/org.eclipse.mylyn.trac.tests/src/org/eclipse/mylyn/trac/tests/client/TracClientFactoryTest.java
@@ -49,12 +49,9 @@ public class TracClientFactoryTest extends TestCase {
 	}
 
 	public void testCreateClientNull() throws Exception {
-		try {
-			WebLocation location = new WebLocation(fixture.getRepositoryUrl(), "user", "password");
-			TracClientFactory.createClient(location, null);
-			fail("Expected Exception");
-		} catch (Exception e) {
-		}
+		WebLocation location = new WebLocation(fixture.getRepositoryUrl(), "user", "password");
+		ITracClient client = TracClientFactory.createClient(location, null);
+		assertEquals(Version.XML_RPC, client.getAccessMode());
 	}
 
 	public void testProbeClient() throws Exception {
-- 
cgit v1.2.3