From 350d50a429b7af1187178228989ed70ccb8951a0 Mon Sep 17 00:00:00 2001 From: spingel Date: Sun, 7 Dec 2008 05:08:27 +0000 Subject: NEW - bug 257651: enable compiler warning for non-externalized strings https://bugs.eclipse.org/bugs/show_bug.cgi?id=257651 --- .../.settings/org.eclipse.jdt.core.prefs | 2 +- .../.settings/org.eclipse.jdt.core.prefs | 2 +- .../.settings/org.eclipse.jdt.core.prefs | 2 +- .../.settings/org.eclipse.jdt.core.prefs | 2 +- .../.settings/org.eclipse.jdt.core.prefs | 2 +- .../.settings/org.eclipse.jdt.core.prefs | 2 +- .../provisional/tasks/core/RepositoryClientManager.java | 4 ++-- .../mylyn/internal/provisional/tasks/core/TasksUtil.java | 10 +++++----- .../mylyn/internal/tasks/core/sync/SynchronizeQueriesJob.java | 2 +- .../mylyn/tasks/core/data/TaskAttachmentPartSource.java | 4 ++-- .../.settings/org.eclipse.jdt.core.prefs | 2 +- .../internal/tasks/ui/editors/TaskEditorAttachmentPart.java | 11 +++++++---- .../internal/tasks/ui/editors/TaskEditorCommentPart.java | 3 ++- .../.settings/org.eclipse.jdt.core.prefs | 2 +- .../.settings/org.eclipse.jdt.core.prefs | 2 +- .../.settings/org.eclipse.jdt.core.prefs | 2 +- 16 files changed, 29 insertions(+), 25 deletions(-) diff --git a/org.eclipse.mylyn-feature/.settings/org.eclipse.jdt.core.prefs b/org.eclipse.mylyn-feature/.settings/org.eclipse.jdt.core.prefs index e0bcb64af..7b0bd0cb5 100644 --- a/org.eclipse.mylyn-feature/.settings/org.eclipse.jdt.core.prefs +++ b/org.eclipse.mylyn-feature/.settings/org.eclipse.jdt.core.prefs @@ -41,7 +41,7 @@ org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotation=ignore org.eclipse.jdt.core.compiler.problem.missingSerialVersion=warning org.eclipse.jdt.core.compiler.problem.noEffectAssignment=warning org.eclipse.jdt.core.compiler.problem.noImplicitStringConversion=warning -org.eclipse.jdt.core.compiler.problem.nonExternalizedStringLiteral=ignore +org.eclipse.jdt.core.compiler.problem.nonExternalizedStringLiteral=warning org.eclipse.jdt.core.compiler.problem.nullReference=error org.eclipse.jdt.core.compiler.problem.overridingPackageDefaultMethod=warning org.eclipse.jdt.core.compiler.problem.parameterAssignment=ignore diff --git a/org.eclipse.mylyn.bugzilla-feature/.settings/org.eclipse.jdt.core.prefs b/org.eclipse.mylyn.bugzilla-feature/.settings/org.eclipse.jdt.core.prefs index e0bcb64af..7b0bd0cb5 100644 --- a/org.eclipse.mylyn.bugzilla-feature/.settings/org.eclipse.jdt.core.prefs +++ b/org.eclipse.mylyn.bugzilla-feature/.settings/org.eclipse.jdt.core.prefs @@ -41,7 +41,7 @@ org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotation=ignore org.eclipse.jdt.core.compiler.problem.missingSerialVersion=warning org.eclipse.jdt.core.compiler.problem.noEffectAssignment=warning org.eclipse.jdt.core.compiler.problem.noImplicitStringConversion=warning -org.eclipse.jdt.core.compiler.problem.nonExternalizedStringLiteral=ignore +org.eclipse.jdt.core.compiler.problem.nonExternalizedStringLiteral=warning org.eclipse.jdt.core.compiler.problem.nullReference=error org.eclipse.jdt.core.compiler.problem.overridingPackageDefaultMethod=warning org.eclipse.jdt.core.compiler.problem.parameterAssignment=ignore diff --git a/org.eclipse.mylyn.help.ui/.settings/org.eclipse.jdt.core.prefs b/org.eclipse.mylyn.help.ui/.settings/org.eclipse.jdt.core.prefs index e0bcb64af..7b0bd0cb5 100644 --- a/org.eclipse.mylyn.help.ui/.settings/org.eclipse.jdt.core.prefs +++ b/org.eclipse.mylyn.help.ui/.settings/org.eclipse.jdt.core.prefs @@ -41,7 +41,7 @@ org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotation=ignore org.eclipse.jdt.core.compiler.problem.missingSerialVersion=warning org.eclipse.jdt.core.compiler.problem.noEffectAssignment=warning org.eclipse.jdt.core.compiler.problem.noImplicitStringConversion=warning -org.eclipse.jdt.core.compiler.problem.nonExternalizedStringLiteral=ignore +org.eclipse.jdt.core.compiler.problem.nonExternalizedStringLiteral=warning org.eclipse.jdt.core.compiler.problem.nullReference=error org.eclipse.jdt.core.compiler.problem.overridingPackageDefaultMethod=warning org.eclipse.jdt.core.compiler.problem.parameterAssignment=ignore diff --git a/org.eclipse.mylyn.sdk-feature/.settings/org.eclipse.jdt.core.prefs b/org.eclipse.mylyn.sdk-feature/.settings/org.eclipse.jdt.core.prefs index e0bcb64af..7b0bd0cb5 100644 --- a/org.eclipse.mylyn.sdk-feature/.settings/org.eclipse.jdt.core.prefs +++ b/org.eclipse.mylyn.sdk-feature/.settings/org.eclipse.jdt.core.prefs @@ -41,7 +41,7 @@ org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotation=ignore org.eclipse.jdt.core.compiler.problem.missingSerialVersion=warning org.eclipse.jdt.core.compiler.problem.noEffectAssignment=warning org.eclipse.jdt.core.compiler.problem.noImplicitStringConversion=warning -org.eclipse.jdt.core.compiler.problem.nonExternalizedStringLiteral=ignore +org.eclipse.jdt.core.compiler.problem.nonExternalizedStringLiteral=warning org.eclipse.jdt.core.compiler.problem.nullReference=error org.eclipse.jdt.core.compiler.problem.overridingPackageDefaultMethod=warning org.eclipse.jdt.core.compiler.problem.parameterAssignment=ignore diff --git a/org.eclipse.mylyn.tasks.bugs/.settings/org.eclipse.jdt.core.prefs b/org.eclipse.mylyn.tasks.bugs/.settings/org.eclipse.jdt.core.prefs index e0bcb64af..7b0bd0cb5 100644 --- a/org.eclipse.mylyn.tasks.bugs/.settings/org.eclipse.jdt.core.prefs +++ b/org.eclipse.mylyn.tasks.bugs/.settings/org.eclipse.jdt.core.prefs @@ -41,7 +41,7 @@ org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotation=ignore org.eclipse.jdt.core.compiler.problem.missingSerialVersion=warning org.eclipse.jdt.core.compiler.problem.noEffectAssignment=warning org.eclipse.jdt.core.compiler.problem.noImplicitStringConversion=warning -org.eclipse.jdt.core.compiler.problem.nonExternalizedStringLiteral=ignore +org.eclipse.jdt.core.compiler.problem.nonExternalizedStringLiteral=warning org.eclipse.jdt.core.compiler.problem.nullReference=error org.eclipse.jdt.core.compiler.problem.overridingPackageDefaultMethod=warning org.eclipse.jdt.core.compiler.problem.parameterAssignment=ignore diff --git a/org.eclipse.mylyn.tasks.core/.settings/org.eclipse.jdt.core.prefs b/org.eclipse.mylyn.tasks.core/.settings/org.eclipse.jdt.core.prefs index 25fbe8dfd..ba09080b3 100644 --- a/org.eclipse.mylyn.tasks.core/.settings/org.eclipse.jdt.core.prefs +++ b/org.eclipse.mylyn.tasks.core/.settings/org.eclipse.jdt.core.prefs @@ -41,7 +41,7 @@ org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotation=ignore org.eclipse.jdt.core.compiler.problem.missingSerialVersion=warning org.eclipse.jdt.core.compiler.problem.noEffectAssignment=warning org.eclipse.jdt.core.compiler.problem.noImplicitStringConversion=warning -org.eclipse.jdt.core.compiler.problem.nonExternalizedStringLiteral=ignore +org.eclipse.jdt.core.compiler.problem.nonExternalizedStringLiteral=warning org.eclipse.jdt.core.compiler.problem.nullReference=error org.eclipse.jdt.core.compiler.problem.overridingPackageDefaultMethod=warning org.eclipse.jdt.core.compiler.problem.parameterAssignment=ignore diff --git a/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/internal/provisional/tasks/core/RepositoryClientManager.java b/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/internal/provisional/tasks/core/RepositoryClientManager.java index ecaaeb0d9..b5330bd4b 100644 --- a/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/internal/provisional/tasks/core/RepositoryClientManager.java +++ b/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/internal/provisional/tasks/core/RepositoryClientManager.java @@ -110,7 +110,7 @@ public abstract class RepositoryClientManager impleme } } catch (Throwable e) { StatusHandler.log(new Status(IStatus.WARNING, ITasksCoreConstants.ID_PLUGIN, - "The respository configuration cache could not be read", e)); + "The respository configuration cache could not be read", e)); //$NON-NLS-1$ } finally { if (in != null) { try { @@ -138,7 +138,7 @@ public abstract class RepositoryClientManager impleme } } catch (IOException e) { StatusHandler.log(new Status(IStatus.WARNING, ITasksCoreConstants.ID_PLUGIN, - "The respository configuration cache could not be written", e)); + "The respository configuration cache could not be written", e)); //$NON-NLS-1$ } finally { if (out != null) { try { diff --git a/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/internal/provisional/tasks/core/TasksUtil.java b/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/internal/provisional/tasks/core/TasksUtil.java index 05cd5d041..b70be4aef 100644 --- a/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/internal/provisional/tasks/core/TasksUtil.java +++ b/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/internal/provisional/tasks/core/TasksUtil.java @@ -30,22 +30,22 @@ public class TasksUtil { } } else if (c == '%') { if (escaped) { - throw new IllegalArgumentException("Unexpected '%' sign in '" + text + "'"); + throw new IllegalArgumentException("Unexpected '%' sign in '" + text + "'"); //$NON-NLS-1$ //$NON-NLS-2$ } escaped = !escaped; } else if (c == '_') { if (!escaped) { - throw new IllegalArgumentException("Unexpected '_' sign in '" + text + "'"); + throw new IllegalArgumentException("Unexpected '_' sign in '" + text + "'"); //$NON-NLS-1$ //$NON-NLS-2$ } try { sb.append((char) Integer.parseInt(escapedText.toString(), 16)); escapedText.setLength(0); } catch (NumberFormatException e) { - throw new IllegalArgumentException("Invalid escape code in '" + text + "'"); + throw new IllegalArgumentException("Invalid escape code in '" + text + "'"); //$NON-NLS-1$ //$NON-NLS-2$ } escaped = !escaped; } else { - throw new IllegalArgumentException("Unexpected character '" + c + "' in '" + text + "'"); + throw new IllegalArgumentException("Unexpected character '" + c + "' in '" + text + "'"); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ } } return sb.toString(); @@ -58,7 +58,7 @@ public class TasksUtil { if (c >= '0' && c <= '9' || c >= 'a' && c <= 'z' || c >= 'A' && c <= 'Z' || c == '.') { sb.append(c); } else { - sb.append("%" + Integer.toHexString(c).toUpperCase() + "_"); + sb.append("%" + Integer.toHexString(c).toUpperCase() + "_"); //$NON-NLS-1$ //$NON-NLS-2$ } } return sb.toString(); diff --git a/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/internal/tasks/core/sync/SynchronizeQueriesJob.java b/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/internal/tasks/core/sync/SynchronizeQueriesJob.java index 1a48b1dbc..b4a75f4fc 100644 --- a/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/internal/tasks/core/sync/SynchronizeQueriesJob.java +++ b/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/internal/tasks/core/sync/SynchronizeQueriesJob.java @@ -142,7 +142,7 @@ public class SynchronizeQueriesJob extends SynchronizationJob { public SynchronizeQueriesJob(TaskList taskList, TaskDataManager taskDataManager, IRepositoryModel tasksModel, AbstractRepositoryConnector connector, TaskRepository repository, Set queries) { - super(Messages.SynchronizeQueriesJob_Synchronizing_Queries + " (" + repository.getRepositoryLabel() + ")"); //$NON-NLS-2$ //$NON-NLS-3$ + super(Messages.SynchronizeQueriesJob_Synchronizing_Queries + " (" + repository.getRepositoryLabel() + ")"); //$NON-NLS-1$//$NON-NLS-2$ this.taskList = taskList; this.taskDataManager = taskDataManager; this.tasksModel = tasksModel; diff --git a/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/tasks/core/data/TaskAttachmentPartSource.java b/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/tasks/core/data/TaskAttachmentPartSource.java index ec6b0dbe9..97287f635 100644 --- a/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/tasks/core/data/TaskAttachmentPartSource.java +++ b/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/tasks/core/data/TaskAttachmentPartSource.java @@ -40,8 +40,8 @@ public class TaskAttachmentPartSource implements PartSource { try { return attachment.createInputStream(null); } catch (CoreException e) { - StatusHandler.log(new Status(IStatus.ERROR, ITasksCoreConstants.ID_PLUGIN, "Error attaching file", e)); - throw new IOException("Failed to create source stream"); + StatusHandler.log(new Status(IStatus.ERROR, ITasksCoreConstants.ID_PLUGIN, "Error attaching file", e)); //$NON-NLS-1$ + throw new IOException("Failed to create source stream"); //$NON-NLS-1$ } } diff --git a/org.eclipse.mylyn.tasks.ui/.settings/org.eclipse.jdt.core.prefs b/org.eclipse.mylyn.tasks.ui/.settings/org.eclipse.jdt.core.prefs index e0bcb64af..7b0bd0cb5 100644 --- a/org.eclipse.mylyn.tasks.ui/.settings/org.eclipse.jdt.core.prefs +++ b/org.eclipse.mylyn.tasks.ui/.settings/org.eclipse.jdt.core.prefs @@ -41,7 +41,7 @@ org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotation=ignore org.eclipse.jdt.core.compiler.problem.missingSerialVersion=warning org.eclipse.jdt.core.compiler.problem.noEffectAssignment=warning org.eclipse.jdt.core.compiler.problem.noImplicitStringConversion=warning -org.eclipse.jdt.core.compiler.problem.nonExternalizedStringLiteral=ignore +org.eclipse.jdt.core.compiler.problem.nonExternalizedStringLiteral=warning org.eclipse.jdt.core.compiler.problem.nullReference=error org.eclipse.jdt.core.compiler.problem.overridingPackageDefaultMethod=warning org.eclipse.jdt.core.compiler.problem.parameterAssignment=ignore diff --git a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskEditorAttachmentPart.java b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskEditorAttachmentPart.java index a85a655ee..f9bf86153 100644 --- a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskEditorAttachmentPart.java +++ b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskEditorAttachmentPart.java @@ -65,7 +65,9 @@ public class TaskEditorAttachmentPart extends AbstractTaskEditorPart { private static final String ID_POPUP_MENU = "org.eclipse.mylyn.tasks.ui.editor.menu.attachments"; //$NON-NLS-1$ - private final String[] attachmentsColumns = { Messages.TaskEditorAttachmentPart_Name, Messages.TaskEditorAttachmentPart_Description, /*"Type", */Messages.TaskEditorAttachmentPart_Size, Messages.TaskEditorAttachmentPart_Creator, Messages.TaskEditorAttachmentPart_Created }; //$NON-NLS-1$ + private final String[] attachmentsColumns = { Messages.TaskEditorAttachmentPart_Name, + Messages.TaskEditorAttachmentPart_Description, /*"Type", */Messages.TaskEditorAttachmentPart_Size, + Messages.TaskEditorAttachmentPart_Creator, Messages.TaskEditorAttachmentPart_Created }; private final int[] attachmentsColumnWidths = { 130, 150, /*100,*/70, 100, 100 }; @@ -160,7 +162,8 @@ public class TaskEditorAttachmentPart extends AbstractTaskEditorPart { attachmentControlsComposite.setLayout(new GridLayout(2, false)); attachmentControlsComposite.setLayoutData(new GridData(GridData.BEGINNING)); - Button attachFileButton = toolkit.createButton(attachmentControlsComposite, Messages.TaskEditorAttachmentPart_Attach_, SWT.PUSH); + Button attachFileButton = toolkit.createButton(attachmentControlsComposite, + Messages.TaskEditorAttachmentPart_Attach_, SWT.PUSH); attachFileButton.setImage(WorkbenchImages.getImage(ISharedImages.IMG_OBJ_FILE)); attachFileButton.addSelectionListener(new SelectionAdapter() { @Override @@ -170,8 +173,8 @@ public class TaskEditorAttachmentPart extends AbstractTaskEditorPart { }); getTaskEditorPage().registerDefaultDropListener(attachFileButton); - Button attachScreenshotButton = toolkit.createButton(attachmentControlsComposite, Messages.TaskEditorAttachmentPart_Attach__Screenshot, - SWT.PUSH); + Button attachScreenshotButton = toolkit.createButton(attachmentControlsComposite, + Messages.TaskEditorAttachmentPart_Attach__Screenshot, SWT.PUSH); attachScreenshotButton.setImage(CommonImages.getImage(CommonImages.IMAGE_CAPTURE)); attachScreenshotButton.addSelectionListener(new SelectionAdapter() { @Override diff --git a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskEditorCommentPart.java b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskEditorCommentPart.java index c7e5f609f..3e1f8b5c7 100644 --- a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskEditorCommentPart.java +++ b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskEditorCommentPart.java @@ -101,7 +101,8 @@ public class TaskEditorCommentPart extends AbstractTaskEditorPart { groupSection.setBackground(getTaskEditorPage().getAttributeEditorToolkit().getColorIncoming()); } groupSection.setForeground(toolkit.getColors().getColor(IFormColors.TITLE)); - groupSection.setText(commentGroup.getGroupName() + Messages.TaskEditorCommentPart_0 + commentGroup.getCommentAttributes().size() + Messages.TaskEditorCommentPart_1); //$NON-NLS-2$ + groupSection.setText(commentGroup.getGroupName() + Messages.TaskEditorCommentPart_0 + + commentGroup.getCommentAttributes().size() + Messages.TaskEditorCommentPart_1); if (groupSection.isExpanded()) { Composite composite = createCommentViewers(groupSection, toolkit); diff --git a/org.eclipse.mylyn.trac-feature/.settings/org.eclipse.jdt.core.prefs b/org.eclipse.mylyn.trac-feature/.settings/org.eclipse.jdt.core.prefs index e0bcb64af..7b0bd0cb5 100644 --- a/org.eclipse.mylyn.trac-feature/.settings/org.eclipse.jdt.core.prefs +++ b/org.eclipse.mylyn.trac-feature/.settings/org.eclipse.jdt.core.prefs @@ -41,7 +41,7 @@ org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotation=ignore org.eclipse.jdt.core.compiler.problem.missingSerialVersion=warning org.eclipse.jdt.core.compiler.problem.noEffectAssignment=warning org.eclipse.jdt.core.compiler.problem.noImplicitStringConversion=warning -org.eclipse.jdt.core.compiler.problem.nonExternalizedStringLiteral=ignore +org.eclipse.jdt.core.compiler.problem.nonExternalizedStringLiteral=warning org.eclipse.jdt.core.compiler.problem.nullReference=error org.eclipse.jdt.core.compiler.problem.overridingPackageDefaultMethod=warning org.eclipse.jdt.core.compiler.problem.parameterAssignment=ignore diff --git a/org.eclipse.mylyn.trac.core/.settings/org.eclipse.jdt.core.prefs b/org.eclipse.mylyn.trac.core/.settings/org.eclipse.jdt.core.prefs index e0bcb64af..7b0bd0cb5 100644 --- a/org.eclipse.mylyn.trac.core/.settings/org.eclipse.jdt.core.prefs +++ b/org.eclipse.mylyn.trac.core/.settings/org.eclipse.jdt.core.prefs @@ -41,7 +41,7 @@ org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotation=ignore org.eclipse.jdt.core.compiler.problem.missingSerialVersion=warning org.eclipse.jdt.core.compiler.problem.noEffectAssignment=warning org.eclipse.jdt.core.compiler.problem.noImplicitStringConversion=warning -org.eclipse.jdt.core.compiler.problem.nonExternalizedStringLiteral=ignore +org.eclipse.jdt.core.compiler.problem.nonExternalizedStringLiteral=warning org.eclipse.jdt.core.compiler.problem.nullReference=error org.eclipse.jdt.core.compiler.problem.overridingPackageDefaultMethod=warning org.eclipse.jdt.core.compiler.problem.parameterAssignment=ignore diff --git a/org.eclipse.mylyn.trac.ui/.settings/org.eclipse.jdt.core.prefs b/org.eclipse.mylyn.trac.ui/.settings/org.eclipse.jdt.core.prefs index e0bcb64af..7b0bd0cb5 100644 --- a/org.eclipse.mylyn.trac.ui/.settings/org.eclipse.jdt.core.prefs +++ b/org.eclipse.mylyn.trac.ui/.settings/org.eclipse.jdt.core.prefs @@ -41,7 +41,7 @@ org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotation=ignore org.eclipse.jdt.core.compiler.problem.missingSerialVersion=warning org.eclipse.jdt.core.compiler.problem.noEffectAssignment=warning org.eclipse.jdt.core.compiler.problem.noImplicitStringConversion=warning -org.eclipse.jdt.core.compiler.problem.nonExternalizedStringLiteral=ignore +org.eclipse.jdt.core.compiler.problem.nonExternalizedStringLiteral=warning org.eclipse.jdt.core.compiler.problem.nullReference=error org.eclipse.jdt.core.compiler.problem.overridingPackageDefaultMethod=warning org.eclipse.jdt.core.compiler.problem.parameterAssignment=ignore -- cgit v1.2.1