Skip to main content
summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorspingel2008-04-21 16:56:04 -0400
committerspingel2008-04-21 16:56:04 -0400
commit379d27c9dd14f4c07e82e5c2961b17857cf93940 (patch)
treea5fbd3198907e836e63d10e4290423df5ee23084 /org.eclipse.mylyn.trac.core
parentd7f51d7a8b904911b2c0d7eb8d30e3d6f166f9ff (diff)
downloadorg.eclipse.mylyn.tasks-379d27c9dd14f4c07e82e5c2961b17857cf93940.tar.gz
org.eclipse.mylyn.tasks-379d27c9dd14f4c07e82e5c2961b17857cf93940.tar.xz
org.eclipse.mylyn.tasks-379d27c9dd14f4c07e82e5c2961b17857cf93940.zip
NEW - bug 225033: [api] ensure consistent naming of API classes and methods
https://bugs.eclipse.org/bugs/show_bug.cgi?id=225033
Diffstat (limited to 'org.eclipse.mylyn.trac.core')
-rw-r--r--org.eclipse.mylyn.trac.core/src/org/eclipse/mylyn/internal/trac/core/TracAttachmentHandler.java4
-rw-r--r--org.eclipse.mylyn.trac.core/src/org/eclipse/mylyn/internal/trac/core/TracClientManager.java3
-rw-r--r--org.eclipse.mylyn.trac.core/src/org/eclipse/mylyn/internal/trac/core/TracRepositoryConnector.java10
-rw-r--r--org.eclipse.mylyn.trac.core/src/org/eclipse/mylyn/internal/trac/core/TracTaskDataHandler.java6
-rw-r--r--org.eclipse.mylyn.trac.core/src/org/eclipse/mylyn/internal/trac/core/TracWikiHandler.java2
5 files changed, 12 insertions, 13 deletions
diff --git a/org.eclipse.mylyn.trac.core/src/org/eclipse/mylyn/internal/trac/core/TracAttachmentHandler.java b/org.eclipse.mylyn.trac.core/src/org/eclipse/mylyn/internal/trac/core/TracAttachmentHandler.java
index 267674d82..f8741b873 100644
--- a/org.eclipse.mylyn.trac.core/src/org/eclipse/mylyn/internal/trac/core/TracAttachmentHandler.java
+++ b/org.eclipse.mylyn.trac.core/src/org/eclipse/mylyn/internal/trac/core/TracAttachmentHandler.java
@@ -44,7 +44,7 @@ public class TracAttachmentHandler extends AbstractAttachmentHandler {
}
try {
- ITracClient client = connector.getClientManager().getRepository(repository);
+ ITracClient client = connector.getClientManager().getTracClient(repository);
int id = Integer.parseInt(attachment.getTaskId());
return client.getAttachmentData(id, filename, monitor);
} catch (Exception e) {
@@ -63,7 +63,7 @@ public class TracAttachmentHandler extends AbstractAttachmentHandler {
monitor.beginTask("Uploading attachment", IProgressMonitor.UNKNOWN);
try {
try {
- ITracClient client = connector.getClientManager().getRepository(repository);
+ ITracClient client = connector.getClientManager().getTracClient(repository);
int id = Integer.parseInt(task.getTaskId());
client.putAttachmentData(id, attachment.getFilename(), attachment.getDescription(),
attachment.createInputStream(), monitor);
diff --git a/org.eclipse.mylyn.trac.core/src/org/eclipse/mylyn/internal/trac/core/TracClientManager.java b/org.eclipse.mylyn.trac.core/src/org/eclipse/mylyn/internal/trac/core/TracClientManager.java
index 0a3edf414..3d0cb0b7d 100644
--- a/org.eclipse.mylyn.trac.core/src/org/eclipse/mylyn/internal/trac/core/TracClientManager.java
+++ b/org.eclipse.mylyn.trac.core/src/org/eclipse/mylyn/internal/trac/core/TracClientManager.java
@@ -48,8 +48,7 @@ public class TracClientManager implements ITaskRepositoryListener {
readCache();
}
- // API 3.0 rename to getTracClient
- public synchronized ITracClient getRepository(TaskRepository taskRepository) {
+ public synchronized ITracClient getTracClient(TaskRepository taskRepository) {
ITracClient repository = clientByUrl.get(taskRepository.getRepositoryUrl());
if (repository == null) {
AbstractWebLocation location = taskRepositoryLocationFactory.createWebLocation(taskRepository);
diff --git a/org.eclipse.mylyn.trac.core/src/org/eclipse/mylyn/internal/trac/core/TracRepositoryConnector.java b/org.eclipse.mylyn.trac.core/src/org/eclipse/mylyn/internal/trac/core/TracRepositoryConnector.java
index 41775499f..c7f2d7909 100644
--- a/org.eclipse.mylyn.trac.core/src/org/eclipse/mylyn/internal/trac/core/TracRepositoryConnector.java
+++ b/org.eclipse.mylyn.trac.core/src/org/eclipse/mylyn/internal/trac/core/TracRepositoryConnector.java
@@ -88,7 +88,7 @@ public class TracRepositoryConnector extends AbstractRepositoryConnector {
public boolean hasWiki(TaskRepository repository) {
// check the access mode to validate Wiki support
- ITracClient client = getClientManager().getRepository(repository);
+ ITracClient client = getClientManager().getTracClient(repository);
if (client instanceof ITracWikiClient) {
return true;
}
@@ -152,7 +152,7 @@ public class TracRepositoryConnector extends AbstractRepositoryConnector {
ITracClient client;
try {
- client = getClientManager().getRepository(repository);
+ client = getClientManager().getTracClient(repository);
if (query instanceof TracRepositoryQuery) {
client.search(((TracRepositoryQuery) query).getTracSearch(), tickets, monitor);
}
@@ -209,7 +209,7 @@ public class TracRepositoryConnector extends AbstractRepositoryConnector {
}
try {
- ITracClient client = getClientManager().getRepository(repository);
+ ITracClient client = getClientManager().getTracClient(repository);
Set<Integer> ids = client.getChangedTickets(since, monitor);
if (ids.isEmpty()) {
// repository is unchanged
@@ -258,7 +258,7 @@ public class TracRepositoryConnector extends AbstractRepositoryConnector {
@Override
public boolean updateTaskFromTaskData(TaskRepository taskRepository, AbstractTask task, RepositoryTaskData taskData) {
TracTask tracTask = (TracTask) task;
- ITracClient client = getClientManager().getRepository(taskRepository);
+ ITracClient client = getClientManager().getTracClient(taskRepository);
task.setSummary(taskData.getSummary());
task.setOwner(taskData.getAttributeValue(RepositoryTaskAttribute.USER_ASSIGNED));
@@ -323,7 +323,7 @@ public class TracRepositoryConnector extends AbstractRepositoryConnector {
@Override
public void updateRepositoryConfiguration(TaskRepository repository, IProgressMonitor monitor) throws CoreException {
try {
- ITracClient client = getClientManager().getRepository(repository);
+ ITracClient client = getClientManager().getTracClient(repository);
client.updateAttributes(monitor, true);
} catch (Exception e) {
throw new CoreException(RepositoryStatus.createStatus(repository.getRepositoryUrl(), IStatus.WARNING,
diff --git a/org.eclipse.mylyn.trac.core/src/org/eclipse/mylyn/internal/trac/core/TracTaskDataHandler.java b/org.eclipse.mylyn.trac.core/src/org/eclipse/mylyn/internal/trac/core/TracTaskDataHandler.java
index b64bb5508..8202932d4 100644
--- a/org.eclipse.mylyn.trac.core/src/org/eclipse/mylyn/internal/trac/core/TracTaskDataHandler.java
+++ b/org.eclipse.mylyn.trac.core/src/org/eclipse/mylyn/internal/trac/core/TracTaskDataHandler.java
@@ -77,7 +77,7 @@ public class TracTaskDataHandler extends AbstractTaskDataHandler {
public RepositoryTaskData downloadTaskData(TaskRepository repository, int taskId, IProgressMonitor monitor)
throws CoreException {
- ITracClient client = connector.getClientManager().getRepository(repository);
+ ITracClient client = connector.getClientManager().getTracClient(repository);
TracTicket ticket;
try {
client.updateAttributes(monitor, false);
@@ -358,7 +358,7 @@ public class TracTaskDataHandler extends AbstractTaskDataHandler {
throws CoreException {
try {
TracTicket ticket = TracRepositoryConnector.getTracTicket(repository, taskData);
- ITracClient server = connector.getClientManager().getRepository(repository);
+ ITracClient server = connector.getClientManager().getTracClient(repository);
if (taskData.isNew()) {
int id = server.createTicket(ticket, monitor);
return id + "";
@@ -378,7 +378,7 @@ public class TracTaskDataHandler extends AbstractTaskDataHandler {
public boolean initializeTaskData(TaskRepository repository, RepositoryTaskData data, IProgressMonitor monitor)
throws CoreException {
try {
- ITracClient client = connector.getClientManager().getRepository(repository);
+ ITracClient client = connector.getClientManager().getTracClient(repository);
client.updateAttributes(monitor, false);
createDefaultAttributes(attributeFactory, data, client, false);
return true;
diff --git a/org.eclipse.mylyn.trac.core/src/org/eclipse/mylyn/internal/trac/core/TracWikiHandler.java b/org.eclipse.mylyn.trac.core/src/org/eclipse/mylyn/internal/trac/core/TracWikiHandler.java
index daf2e5a89..3ff0468b9 100644
--- a/org.eclipse.mylyn.trac.core/src/org/eclipse/mylyn/internal/trac/core/TracWikiHandler.java
+++ b/org.eclipse.mylyn.trac.core/src/org/eclipse/mylyn/internal/trac/core/TracWikiHandler.java
@@ -94,7 +94,7 @@ public class TracWikiHandler extends AbstractWikiHandler {
}
private ITracWikiClient getTracWikiClient(TaskRepository repository) throws TracException {
- ITracClient client = connector.getClientManager().getRepository(repository);
+ ITracClient client = connector.getClientManager().getTracClient(repository);
if (client instanceof ITracWikiClient) {
return (ITracWikiClient) client;
} else {

Back to the top