Revert "ASSIGNED - bug 356986: [patch] auto detect XML-RPC (was: IllegalArgumentException when enabling XML-RPC) https://bugs.eclipse.org/bugs/show_bug.cgi?id=356986"

This reverts commit 97fa0d622ae5d53c449e4050e453cf44b9ea2597.

4 files changed, 1 insertions, 22 deletions

diff --git a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/wizards/EditRepositoryWizard.java b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/wizards/EditRepositoryWizard.java
index 92b840679..f5e76463f 100644
--- a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/wizards/EditRepositoryWizard.java
+++ b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/wizards/EditRepositoryWizard.java
@@ -76,10 +76,7 @@ public class EditRepositoryWizard extends Wizard implements INewWizard {
 			if (!repository.getConnectorKind().equals(LocalRepositoryConnector.CONNECTOR_KIND)) {
 				repository.setRepositoryUrl(newUrl);
 			}
-			boolean result = settingsPage.doPerformFinish(repository);
-			if (!result) {
-				return false;
-			}
+			settingsPage.performFinish(repository);
 			if (oldUrl != null && newUrl != null && !oldUrl.equals(newUrl)) {
 				TasksUiPlugin.getRepositoryManager().notifyRepositoryUrlChanged(repository, oldUrl);
 			}
diff --git a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/wizards/LocalRepositorySettingsPage.java b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/wizards/LocalRepositorySettingsPage.java
index d5395c826..b5f9dd838 100644
--- a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/wizards/LocalRepositorySettingsPage.java
+++ b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/wizards/LocalRepositorySettingsPage.java
@@ -64,9 +64,4 @@ public class LocalRepositorySettingsPage extends AbstractTaskRepositoryPage {
 		}
 	}
 
-	public boolean doPerformFinish(TaskRepository repository) {
-		performFinish(repository);
-		return true;
-	}
-
 }
diff --git a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/wizards/AbstractRepositorySettingsPage.java b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/wizards/AbstractRepositorySettingsPage.java
index a617d7839..85dfd39d3 100644
--- a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/wizards/AbstractRepositorySettingsPage.java
+++ b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/wizards/AbstractRepositorySettingsPage.java
@@ -2017,12 +2017,4 @@ public abstract class AbstractRepositorySettingsPage extends AbstractTaskReposit
 		return null;
 	}
 
-	/**
-	 * @since 3.7
-	 */
-	public boolean doPerformFinish(TaskRepository repository) {
-		performFinish(repository);
-		return true;
-	}
-
 }
diff --git a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/wizards/ITaskRepositoryPage.java b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/wizards/ITaskRepositoryPage.java
index 56ed330a0..343af0c71 100644
--- a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/wizards/ITaskRepositoryPage.java
+++ b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/wizards/ITaskRepositoryPage.java
@@ -49,9 +49,4 @@ public interface ITaskRepositoryPage extends IWizardPage {
 	 */
 	public abstract void performFinish(TaskRepository repository);
 
-	/**
-	 * @since 3.7
-	 */
-	public abstract boolean doPerformFinish(TaskRepository repository);
-
 }
\ No newline at end of file