Skip to main content
summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBenjamin Muskalla2013-06-06 08:22:39 -0400
committerBenjamin Muskalla2013-06-06 08:22:39 -0400
commitab4249689cd86de3880f566b2fe453e20baaf6ba (patch)
treebd2d05994071929827b1e76bff1761f227134fd4 /org.eclipse.mylyn.tasks.ui
parent810a52cbbdadee42693d04d354031bcec400502b (diff)
downloadorg.eclipse.mylyn.tasks-ab4249689cd86de3880f566b2fe453e20baaf6ba.tar.gz
org.eclipse.mylyn.tasks-ab4249689cd86de3880f566b2fe453e20baaf6ba.tar.xz
org.eclipse.mylyn.tasks-ab4249689cd86de3880f566b2fe453e20baaf6ba.zip
410062: settings page constructor should not rely on overridden methods
Change-Id: I56f339de4d58d745af067ea65ba521496c97b885 Task-Url: https://bugs.eclipse.org/bugs/show_bug.cgi?id=410062
Diffstat (limited to 'org.eclipse.mylyn.tasks.ui')
-rw-r--r--org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/wizards/AbstractRepositorySettingsPage.java18
1 files changed, 15 insertions, 3 deletions
diff --git a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/wizards/AbstractRepositorySettingsPage.java b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/wizards/AbstractRepositorySettingsPage.java
index c67a5265e..c9c4dabb2 100644
--- a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/wizards/AbstractRepositorySettingsPage.java
+++ b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/wizards/AbstractRepositorySettingsPage.java
@@ -89,6 +89,7 @@ import org.eclipse.ui.statushandlers.StatusManager;
* @author Frank Becker
* @author David Green
* @author Helen Bershadskaya
+ * @author Benjamin Muskalla
* @since 2.0
*/
public abstract class AbstractRepositorySettingsPage extends AbstractTaskRepositoryPage implements ITaskRepositoryPage,
@@ -244,12 +245,16 @@ public abstract class AbstractRepositorySettingsPage extends AbstractTaskReposit
protected SectionComposite innerComposite;
/**
- * @since 3.0
+ * @since 3.10
*/
- public AbstractRepositorySettingsPage(String title, String description, TaskRepository taskRepository) {
+ public AbstractRepositorySettingsPage(String title, String description, TaskRepository taskRepository,
+ AbstractRepositoryConnector connector) {
super(title, description, taskRepository);
repository = taskRepository;
- this.connector = TasksUi.getRepositoryManager().getRepositoryConnector(getConnectorKind());
+ if (connector == null) {
+ connector = TasksUi.getRepositoryManager().getRepositoryConnector(getConnectorKind());
+ }
+ this.connector = connector;
setNeedsAnonymousLogin(false);
setNeedsEncoding(true);
setNeedsTimeZone(true);
@@ -262,6 +267,13 @@ public abstract class AbstractRepositorySettingsPage extends AbstractTaskReposit
/**
* @since 3.0
*/
+ public AbstractRepositorySettingsPage(String title, String description, TaskRepository taskRepository) {
+ this(title, description, taskRepository, null);
+ }
+
+ /**
+ * @since 3.0
+ */
@Override
public abstract String getConnectorKind();

Back to the top