Skip to main content
summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSam Davis2013-01-16 14:14:38 -0500
committerSteffen Pingel2013-10-07 21:55:47 -0400
commit3b1cb33184c84edfc8a6bba711ab9d47acd648b4 (patch)
treeb49163b64284cfafff81446cfcaac7df5cb32c76 /org.eclipse.mylyn.tasks.ui
parented32420d9f87d18a801caed2caddcfa6901492cb (diff)
downloadorg.eclipse.mylyn.tasks-3b1cb33184c84edfc8a6bba711ab9d47acd648b4.tar.gz
org.eclipse.mylyn.tasks-3b1cb33184c84edfc8a6bba711ab9d47acd648b4.tar.xz
org.eclipse.mylyn.tasks-3b1cb33184c84edfc8a6bba711ab9d47acd648b4.zip
326119: Repository credentials are overwritten during repository
settings validation Change-Id: I0f8becdc0bc2869d67de80401920bf6f7d69bd87 Task-Url: https://bugs.eclipse.org/bugs/show_bug.cgi?id=326119
Diffstat (limited to 'org.eclipse.mylyn.tasks.ui')
-rw-r--r--org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/wizards/AbstractRepositorySettingsPage.java8
1 files changed, 8 insertions, 0 deletions
diff --git a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/wizards/AbstractRepositorySettingsPage.java b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/wizards/AbstractRepositorySettingsPage.java
index 77f824855..fccefa236 100644
--- a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/wizards/AbstractRepositorySettingsPage.java
+++ b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/wizards/AbstractRepositorySettingsPage.java
@@ -1672,10 +1672,18 @@ public abstract class AbstractRepositorySettingsPage extends AbstractTaskReposit
}
/**
+ * Creates a {@link TaskRepository} based on the current settings.
+ * <p>
+ * Note: The credentials of the created repository are not persisted in the platform keystore. When overriding,
+ * subclasses must either call super or call {@link TaskRepository#setShouldPersistCredentials(boolean)
+ * setShouldPersistCredentials(false)} before calling {@link #applyTo(TaskRepository)}.
+ *
* @since 2.0
*/
public TaskRepository createTaskRepository() {
TaskRepository repository = new TaskRepository(connector.getConnectorKind(), getRepositoryUrl());
+ // do not modify the secure storage for a temporary repository
+ repository.setShouldPersistCredentials(false);
applyTo(repository);
return repository;
}

Back to the top