NEW - bug 238006: TaskAttributeMapper.getDefaultOption() is not used

https://bugs.eclipse.org/bugs/show_bug.cgi?id=238006

2 files changed, 18 insertions, 0 deletions

diff --git a/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/tasks/core/data/TaskAttributeMapper.java b/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/tasks/core/data/TaskAttributeMapper.java
index 989efb410..85ee5324c 100644
--- a/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/tasks/core/data/TaskAttributeMapper.java
+++ b/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/tasks/core/data/TaskAttributeMapper.java
@@ -104,6 +104,10 @@ public class TaskAttributeMapper {
 		return null;
 	}
 
+	/**
+	 * @deprecated Not used, see {@link TaskAttributeMetaData#setDefaultOption(String)}
+	 */
+	@Deprecated
 	public String getDefaultOption(TaskAttribute taskAttribute) {
 		return taskAttribute.getMetaData().getDefaultOption();
 	}
diff --git a/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/tasks/core/data/TaskAttributeMetaData.java b/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/tasks/core/data/TaskAttributeMetaData.java
index ab1833a23..6a01d262b 100644
--- a/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/tasks/core/data/TaskAttributeMetaData.java
+++ b/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/tasks/core/data/TaskAttributeMetaData.java
@@ -48,6 +48,10 @@ public class TaskAttributeMetaData {
 		return this;
 	}
 
+	/**
+	 * @deprecated not use, see {@link #setDefaultOption(String)}
+	 */
+	@Deprecated
 	public String getDefaultOption() {
 		return taskAttribute.getMetaDatum(TaskAttribute.META_DEFAULT_OPTION);
 	}
@@ -89,6 +93,16 @@ public class TaskAttributeMetaData {
 		return this;
 	}
 
+	/**
+	 * The default option property is not used. Connectors are expected to set default values in
+	 * {@link AbstractTaskDataHandler#initializeTaskData(org.eclipse.mylyn.tasks.core.TaskRepository, TaskData, org.eclipse.mylyn.tasks.core.ITaskMapping, org.eclipse.core.runtime.IProgressMonitor)}
+	 * .
+	 * 
+	 * @deprecated Not used, set default value in
+	 *             {@link AbstractTaskDataHandler#initializeTaskData(org.eclipse.mylyn.tasks.core.TaskRepository, TaskData, org.eclipse.mylyn.tasks.core.ITaskMapping, org.eclipse.core.runtime.IProgressMonitor)}
+	 *             instead.
+	 */
+	@Deprecated
 	public TaskAttributeMetaData setDefaultOption(String defaultOption) {
 		if (defaultOption != null) {
 			taskAttribute.putMetaDatum(TaskAttribute.META_DEFAULT_OPTION, defaultOption);