Skip to main content
summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorspingel2009-11-18 21:16:31 +0000
committerspingel2009-11-18 21:16:31 +0000
commit63d1ce6c6411334bba819708dec21a8c3a1e7221 (patch)
tree137d2a2fcf43b1308fe0b5b6172925b0995fb428 /org.eclipse.mylyn.tasks.bugs
parent296190c61aaa84a696143dda896fa23eb1ee0aef (diff)
downloadorg.eclipse.mylyn.tasks-63d1ce6c6411334bba819708dec21a8c3a1e7221.tar.gz
org.eclipse.mylyn.tasks-63d1ce6c6411334bba819708dec21a8c3a1e7221.tar.xz
org.eclipse.mylyn.tasks-63d1ce6c6411334bba819708dec21a8c3a1e7221.zip
NEW - bug 294354: IllegalArgumentException when name is not specified for support product
https://bugs.eclipse.org/bugs/show_bug.cgi?id=294354
Diffstat (limited to 'org.eclipse.mylyn.tasks.bugs')
-rw-r--r--org.eclipse.mylyn.tasks.bugs/src/org/eclipse/mylyn/internal/tasks/bugs/SupportProviderManager.java5
-rw-r--r--org.eclipse.mylyn.tasks.bugs/src/org/eclipse/mylyn/internal/tasks/bugs/messages.properties1
2 files changed, 4 insertions, 2 deletions
diff --git a/org.eclipse.mylyn.tasks.bugs/src/org/eclipse/mylyn/internal/tasks/bugs/SupportProviderManager.java b/org.eclipse.mylyn.tasks.bugs/src/org/eclipse/mylyn/internal/tasks/bugs/SupportProviderManager.java
index c28490556..85e7ae176 100644
--- a/org.eclipse.mylyn.tasks.bugs/src/org/eclipse/mylyn/internal/tasks/bugs/SupportProviderManager.java
+++ b/org.eclipse.mylyn.tasks.bugs/src/org/eclipse/mylyn/internal/tasks/bugs/SupportProviderManager.java
@@ -182,12 +182,13 @@ public class SupportProviderManager {
}
// optionally complement data from referenced feature
+ boolean available = true;
String featureId = element.getAttribute(ATTRIBUTE_FEATURE_ID);
if (featureId != null) {
IBundleGroup bundleGroup = getBundleGroup(featureId);
if (bundleGroup == null) {
// indicate that the specified feature was not found
- return false;
+ available = false;
} else {
if (item.getName() == null) {
item.setName(bundleGroup.getName());
@@ -215,7 +216,7 @@ public class SupportProviderManager {
item.setName(Messages.SupportProviderManager_Product_Unknown);
}
- return true;
+ return available;
}
private void readCategory(IConfigurationElement element) {
diff --git a/org.eclipse.mylyn.tasks.bugs/src/org/eclipse/mylyn/internal/tasks/bugs/messages.properties b/org.eclipse.mylyn.tasks.bugs/src/org/eclipse/mylyn/internal/tasks/bugs/messages.properties
index 2fc515e47..7b798dec7 100644
--- a/org.eclipse.mylyn.tasks.bugs/src/org/eclipse/mylyn/internal/tasks/bugs/messages.properties
+++ b/org.eclipse.mylyn.tasks.bugs/src/org/eclipse/mylyn/internal/tasks/bugs/messages.properties
@@ -26,6 +26,7 @@ DefaultTaskContributor_Info=Info
DefaultTaskContributor_OK=OK
DefaultTaskContributor_SESSION_DATA=\nSession Data:\n
DefaultTaskContributor_Warning=Warning
+SupportProviderManager_Product_Unknown=Unknown
TaskErrorReporter_Create_Task_Error_Message=Unexpected error while creating task for error report
TaskErrorReporter_Create_Task_Error_Title=Error Reporting
TaskErrorReporter_Job_Progress_Process_support_request=Processing support request

Back to the top