ASSIGNED - bug 345056: disable the submit button if we know that we get an error

https://bugs.eclipse.org/bugs/show_bug.cgi?id=345056

revert patch V3

1 files changed, 39 insertions, 67 deletions

diff --git a/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/editor/BugzillaTaskEditorPage.java b/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/editor/BugzillaTaskEditorPage.java
index d73f018cb..256693d11 100644
--- a/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/editor/BugzillaTaskEditorPage.java
+++ b/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/editor/BugzillaTaskEditorPage.java
@@ -20,8 +20,6 @@ import java.util.Set;
 import org.eclipse.core.runtime.CoreException;
 import org.eclipse.core.runtime.IStatus;
 import org.eclipse.core.runtime.NullProgressMonitor;
-import org.eclipse.core.runtime.jobs.IJobChangeEvent;
-import org.eclipse.core.runtime.jobs.JobChangeAdapter;
 import org.eclipse.jface.dialogs.IMessageProvider;
 import org.eclipse.mylyn.commons.core.StatusHandler;
 import org.eclipse.mylyn.commons.net.AuthenticationCredentials;
@@ -39,9 +37,6 @@ import org.eclipse.mylyn.internal.bugzilla.core.RepositoryConfiguration;
 import org.eclipse.mylyn.internal.bugzilla.ui.BugzillaUiPlugin;
 import org.eclipse.mylyn.internal.provisional.commons.ui.WorkbenchUtil;
 import org.eclipse.mylyn.internal.tasks.ui.editors.TaskEditorActionPart;
-import org.eclipse.mylyn.internal.tasks.ui.util.TasksUiInternal;
-import org.eclipse.mylyn.tasks.core.AbstractRepositoryConnector;
-import org.eclipse.mylyn.tasks.core.ITask;
 import org.eclipse.mylyn.tasks.core.RepositoryResponse;
 import org.eclipse.mylyn.tasks.core.RepositoryStatus;
 import org.eclipse.mylyn.tasks.core.TaskRepository;
@@ -517,69 +512,46 @@ public class BugzillaTaskEditorPage extends AbstractTaskEditorPage {
 			});
 			return false;
 		}
-		if (!getModel().getTaskData().isNew()) {
-			TaskAttribute urlbase = getModel().getTaskData().getRoot().getAttribute(BugzillaAttribute.URLBASE.getKey());
-			if (urlbase == null) {
-				// refresh the TaskData so we know the value of the new exporter attribute
-				// TODO e3.7: we can remove this see bug 345056
-				PlatformUI.getWorkbench().getDisplay().asyncExec(new Runnable() {
-
-					public void run() {
-						ITask task = getModel().getTask();
-						AbstractRepositoryConnector connector = TasksUi.getRepositoryManager().getRepositoryConnector(
-								task.getConnectorKind());
-						if (connector == null) {
-							return;
-						}
-						TasksUiInternal.synchronizeTask(connector, task, true, null);
-					}
-				});
-			} else {
-				TaskAttribute exporter = getModel().getTaskData()
-						.getRoot()
-						.getAttribute(BugzillaAttribute.EXPORTER_NAME.getKey());
-				if (exporter == null) {
-					PlatformUI.getWorkbench().getDisplay().asyncExec(new Runnable() {
-						public void run() {
-							getTaskEditor().setMessage(Messages.BugzillaTaskEditorPage_submit_disabled_please_refresh,
-									type, new HyperlinkAdapter() {
-										@Override
-										public void linkActivated(HyperlinkEvent e) {
-											ITask task = getModel().getTask();
-											AbstractRepositoryConnector connector = TasksUi.getRepositoryManager()
-													.getRepositoryConnector(task.getConnectorKind());
-											if (connector == null) {
-												return;
-											}
-											TasksUiInternal.synchronizeTask(connector, task, true,
-													new JobChangeAdapter() {
-														@Override
-														public void done(IJobChangeEvent event) {
-															PlatformUI.getWorkbench()
-																	.getDisplay()
-																	.asyncExec(new Runnable() {
-																		public void run() {
-																			try {
-																				getTaskEditor().refreshPages();
-																			} finally {
-																				if (getTaskEditor() != null) {
-																					getTaskEditor().showBusy(false);
-																				}
-																			}
-																		}
-																	});
-														}
-													});
-										}
-									});
-						}
-					});
-					return false;
-				}
+//		if (!getModel().getTaskData().isNew()) {
+//			TaskAttribute exporter = getModel().getTaskData()
+//					.getRoot()
+//					.getAttribute(BugzillaAttribute.EXPORTER_NAME.getKey());
+//			if (exporter == null) {
+//				PlatformUI.getWorkbench().getDisplay().asyncExec(new Runnable() {
+//					public void run() {
+//						getTaskEditor().setMessage(Messages.BugzillaTaskEditorPage_submit_disabled_please_refresh,
+//								type, new HyperlinkAdapter() {
+//									@Override
+//									public void linkActivated(HyperlinkEvent e) {
+//										ITask task = getModel().getTask();
+//										AbstractRepositoryConnector connector = TasksUi.getRepositoryManager()
+//												.getRepositoryConnector(task.getConnectorKind());
+//										if (connector == null) {
+//											return;
+//										}
+//										TasksUiInternal.synchronizeTask(connector, task, true, new JobChangeAdapter() {
+//											@Override
+//											public void done(IJobChangeEvent event) {
+//												PlatformUI.getWorkbench().getDisplay().asyncExec(new Runnable() {
+//													public void run() {
+//														try {
+//															getTaskEditor().refreshPages();
+//														} finally {
+//															if (getTaskEditor() != null) {
+//																getTaskEditor().showBusy(false);
+//															}
+//														}
+//													}
+//												});
+//											}
+//										});
+//									}
+//								});
+//					}
+//				});
+//				return false;
 //			}
-
-			}
-		}
+//		}
 		return true;
 	}
 }