diff options
| author | fbecker | 2011-01-08 22:02:14 +0000 |
|---|---|---|
| committer | fbecker | 2011-01-08 22:02:14 +0000 |
| commit | 2d9b2ed73ddc6ea1cac0494c581a45a1130f889e (patch) | |
| tree | 62a25b9b75e9490cd318abd73da2914affbfa774 /org.eclipse.mylyn.bugzilla.ui | |
| parent | db9744deed061c7bc9b23390a28ea0ba146e451f (diff) | |
| download | org.eclipse.mylyn.tasks-2d9b2ed73ddc6ea1cac0494c581a45a1130f889e.tar.gz org.eclipse.mylyn.tasks-2d9b2ed73ddc6ea1cac0494c581a45a1130f889e.tar.xz org.eclipse.mylyn.tasks-2d9b2ed73ddc6ea1cac0494c581a45a1130f889e.zip | |
ASSIGNED - bug 333779: better way to handle configuration changes
https://bugs.eclipse.org/bugs/show_bug.cgi?id=333779
Fix of some NPE from the previous patch
Diffstat (limited to 'org.eclipse.mylyn.bugzilla.ui')
| -rw-r--r-- | org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/tasklist/BugzillaRepositorySettingsPage.java | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/tasklist/BugzillaRepositorySettingsPage.java b/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/tasklist/BugzillaRepositorySettingsPage.java index 7290249fd..27e4f0f92 100644 --- a/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/tasklist/BugzillaRepositorySettingsPage.java +++ b/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/tasklist/BugzillaRepositorySettingsPage.java @@ -464,14 +464,13 @@ public class BugzillaRepositorySettingsPage extends AbstractRepositorySettingsPa || repository.getSavePassword(AuthenticationType.REPOSITORY) != getSavePassword() || !repositoryAuth.getUserName().equals(getUserName()) || !repositoryAuth.getPassword().equals(getPassword()) - || !repository.getProperty(TaskRepository.PROXY_HOSTNAME).equals(getProxyHostname()) - || !repository.getProperty(TaskRepository.PROXY_PORT).equals(getProxyPort()) || Boolean.parseBoolean(repository.getProperty(IBugzillaConstants.BUGZILLA_USE_XMLRPC)) != useXMLRPCstatusTransitions.getSelection() - || !repository.getProperty(IBugzillaConstants.BUGZILLA_DESCRIPTOR_FILE) - .equals(descriptorFile.getText()); + || descriptorFile.getText().equals(repository.getProperty(IBugzillaConstants.BUGZILLA_DESCRIPTOR_FILE)); if (httpAuth != null) { changed = changed || !httpAuth.getUserName().equals(getHttpAuthUserId()) - || !httpAuth.getPassword().equals(getHttpAuthPassword()); + || !httpAuth.getPassword().equals(getHttpAuthPassword()) + || !repository.getProperty(TaskRepository.PROXY_HOSTNAME).equals(getProxyHostname()) + || !repository.getProperty(TaskRepository.PROXY_PORT).equals(getProxyPort()); } if (proxyAuth != null) { changed = changed || !proxyAuth.getUserName().equals(getProxyUserName()) |