Skip to main content
summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorrelves2007-02-16 23:29:46 -0500
committerrelves2007-02-16 23:29:46 -0500
commit7fab0fd9efac9dadb12939f31fe0cd773e5c342e (patch)
tree5ea268c5fbdcbbac257c63258dcef5b9384ad727
parent33f6481ee2f17bec03387ac8d7019146c5ed9f17 (diff)
downloadorg.eclipse.mylyn.tasks-7fab0fd9efac9dadb12939f31fe0cd773e5c342e.tar.gz
org.eclipse.mylyn.tasks-7fab0fd9efac9dadb12939f31fe0cd773e5c342e.tar.xz
org.eclipse.mylyn.tasks-7fab0fd9efac9dadb12939f31fe0cd773e5c342e.zip
NEW - bug 158921: improve task editor information density
https://bugs.eclipse.org/bugs/show_bug.cgi?id=158921
-rw-r--r--org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/editor/BugzillaTaskEditor.java4
-rw-r--r--org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskPlanningEditor.java22
-rw-r--r--org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/editors/AbstractRepositoryTaskEditor.java4
3 files changed, 16 insertions, 14 deletions
diff --git a/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/editor/BugzillaTaskEditor.java b/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/editor/BugzillaTaskEditor.java
index d92559700..70d9d851d 100644
--- a/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/editor/BugzillaTaskEditor.java
+++ b/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/editor/BugzillaTaskEditor.java
@@ -388,7 +388,7 @@ public class BugzillaTaskEditor extends AbstractRepositoryTaskEditor {
}
Label label = toolkit.createLabel(timeComposite, "Current Estimate:");
- label.setForeground(toolkit.getColors().getColor(IFormColors.TB_TOGGLE));
+ label.setForeground(toolkit.getColors().getColor(IFormColors.TITLE));
Text currentEstimate = toolkit.createText(timeComposite,
""
@@ -537,7 +537,7 @@ public class BugzillaTaskEditor extends AbstractRepositoryTaskEditor {
protected void addVoting(Composite attributesComposite) {
Label label = toolkit.createLabel(attributesComposite, "Votes:");
- label.setForeground(toolkit.getColors().getColor(IFormColors.TB_TOGGLE));
+ label.setForeground(toolkit.getColors().getColor(IFormColors.TITLE));
GridDataFactory.fillDefaults().align(SWT.RIGHT, SWT.CENTER).applyTo(label);
Composite votingComposite = toolkit.createComposite(attributesComposite);
GridLayout layout = new GridLayout(3, false);
diff --git a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskPlanningEditor.java b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskPlanningEditor.java
index b50a00032..73550a4a8 100644
--- a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskPlanningEditor.java
+++ b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskPlanningEditor.java
@@ -57,6 +57,7 @@ import org.eclipse.swt.widgets.Label;
import org.eclipse.swt.widgets.Spinner;
import org.eclipse.swt.widgets.Text;
import org.eclipse.ui.PlatformUI;
+import org.eclipse.ui.forms.IFormColors;
import org.eclipse.ui.forms.IManagedForm;
import org.eclipse.ui.forms.editor.FormEditor;
import org.eclipse.ui.forms.events.ExpansionEvent;
@@ -345,7 +346,7 @@ public class TaskPlanningEditor extends TaskFormPage {
});
}
- toolkit.createLabel(container, "Status:");
+ toolkit.createLabel(container, "Status:").setForeground(toolkit.getColors().getColor(IFormColors.TITLE));;
Composite statusComposite = toolkit.createComposite(container);
statusComposite.setLayout(new GridLayout(6, false));
statusComposite.setLayoutData(new GridData(GridData.FILL_HORIZONTAL));
@@ -410,8 +411,9 @@ public class TaskPlanningEditor extends TaskFormPage {
});
}
- toolkit.createLabel(statusComposite, "URL:");
- issueReportURL = toolkit.createText(statusComposite, task.getTaskUrl(), SWT.NONE);
+ Label label = toolkit.createLabel(statusComposite, "URL:");
+ label.setForeground(toolkit.getColors().getColor(IFormColors.TITLE));
+ issueReportURL = toolkit.createText(statusComposite, task.getTaskUrl(), SWT.FLAT);
GridDataFactory.fillDefaults().span(2, SWT.DEFAULT).grab(true, false).applyTo(issueReportURL);
if (task instanceof AbstractRepositoryTask) {
@@ -447,6 +449,7 @@ public class TaskPlanningEditor extends TaskFormPage {
public void widgetDefaultSelected(SelectionEvent e) {
}
});
+ toolkit.paintBordersFor(statusComposite);
}
/**
@@ -520,7 +523,7 @@ public class TaskPlanningEditor extends TaskFormPage {
// Reminder
Label label = toolkit.createLabel(sectionClient, LABEL_SCHEDULE);
- // label.setForeground(toolkit.getColors().getColor(FormColors.TITLE));
+ label.setForeground(toolkit.getColors().getColor(IFormColors.TITLE));
datePicker = new DatePicker(sectionClient, SWT.NONE, DatePicker.LABEL_CHOOSE);
@@ -562,7 +565,7 @@ public class TaskPlanningEditor extends TaskFormPage {
// Creation date
label = toolkit.createLabel(sectionClient, "Creation date:");
- // label.setForeground(toolkit.getColors().getColor(FormColors.TITLE));
+ label.setForeground(toolkit.getColors().getColor(IFormColors.TITLE));
String creationDateString = "";
try {
@@ -581,7 +584,7 @@ public class TaskPlanningEditor extends TaskFormPage {
// Estimated time
label = toolkit.createLabel(sectionClient, "Estimated time:");
- // label.setForeground(toolkit.getColors().getColor(FormColors.TITLE));
+ label.setForeground(toolkit.getColors().getColor(IFormColors.TITLE));
estimated = new Spinner(sectionClient, SWT.NONE);
estimated.setSelection(task.getEstimateTimeHours());
@@ -601,7 +604,7 @@ public class TaskPlanningEditor extends TaskFormPage {
estimated.setLayoutData(estimatedDataLayout);
label = toolkit.createLabel(sectionClient, "hours ");
- // label.setForeground(toolkit.getColors().getColor(FormColors.TITLE));
+ label.setForeground(toolkit.getColors().getColor(IFormColors.TITLE));
// 1 Blank column
Label blankLabel2 = toolkit.createLabel(sectionClient, "");
@@ -612,7 +615,7 @@ public class TaskPlanningEditor extends TaskFormPage {
// Completion date
label = toolkit.createLabel(sectionClient, "Completion date:");
- // label.setForeground(toolkit.getColors().getColor(FormColors.TITLE));
+ label.setForeground(toolkit.getColors().getColor(IFormColors.TITLE));
String completionDateString = "";
if (task.isCompleted()) {
@@ -630,7 +633,7 @@ public class TaskPlanningEditor extends TaskFormPage {
// Elapsed Time
label = toolkit.createLabel(sectionClient, "Active time:");
- // label.setForeground(toolkit.getColors().getColor(FormColors.TITLE));
+ label.setForeground(toolkit.getColors().getColor(IFormColors.TITLE));
label.setToolTipText(DESCRIPTION_ESTIMATED);
Composite elapsedComposite = toolkit.createComposite(sectionClient);
@@ -777,7 +780,6 @@ public class TaskPlanningEditor extends TaskFormPage {
container.setLayoutData(new GridData(GridData.FILL_HORIZONTAL));
toolkit.createLabel(container, "Task context file:");
- // l2.setForeground(toolkit.getColors().getColor(FormColors.TITLE));
File contextFile = ContextCorePlugin.getContextManager().getFileForContext(task.getHandleIdentifier());
if (contextFile != null) {
pathText = toolkit.createText(container, contextFile.getAbsolutePath(), SWT.NONE);
diff --git a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/editors/AbstractRepositoryTaskEditor.java b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/editors/AbstractRepositoryTaskEditor.java
index 338b38132..170284576 100644
--- a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/editors/AbstractRepositoryTaskEditor.java
+++ b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/editors/AbstractRepositoryTaskEditor.java
@@ -880,7 +880,7 @@ public abstract class AbstractRepositoryTaskEditor extends TaskFormPage {
} else {
label = toolkit.createLabel(composite, attribute.getName());
}
- label.setForeground(toolkit.getColors().getColor(IFormColors.TB_TOGGLE));
+ label.setForeground(toolkit.getColors().getColor(IFormColors.TITLE));
return label;
}
@@ -1733,7 +1733,7 @@ public abstract class AbstractRepositoryTaskEditor extends TaskFormPage {
foundNew = true;
}
- expandableComposite.setTitleBarForeground(toolkit.getColors().getColor(IFormColors.TB_TOGGLE));
+ expandableComposite.setTitleBarForeground(toolkit.getColors().getColor(IFormColors.TITLE));
expandableComposite.setText(taskComment.getNumber() + ": " + taskComment.getAuthorName() + ", "
+ taskComment.getCreated());

Back to the top