ASSIGNED - bug 168204: support bugzilla's usermatchmode for matching

names to email addresses 
https://bugs.eclipse.org/bugs/show_bug.cgi?id=168204

3 files changed, 9 insertions, 5 deletions

diff --git a/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/editor/BugzillaTaskEditorPage.java b/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/editor/BugzillaTaskEditorPage.java
index 65587f50f..9385adb09 100644
--- a/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/editor/BugzillaTaskEditorPage.java
+++ b/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/editor/BugzillaTaskEditorPage.java
@@ -670,7 +670,7 @@ public class BugzillaTaskEditorPage extends AbstractTaskEditorPage {
 				resultString = MessageFormat.format(Messages.BugzillaTaskEditorPage_Message_more,
 						Messages.BugzillaTaskEditorPage_Confirm, fieldString);
 			}
-			titleString = Messages.BugzillaTaskEditorPage_Confirm + Messages.BugzillaTaskEditorPage_match_Detail;
+			titleString = Messages.BugzillaTaskEditorPage_ConfirmDetailTitle;
 			break;
 		case BugzillaStatus.ERROR_MATCH_FAILED:
 			if (oneError) {
@@ -680,12 +680,10 @@ public class BugzillaTaskEditorPage extends AbstractTaskEditorPage {
 				resultString = MessageFormat.format(Messages.BugzillaTaskEditorPage_Message_more,
 						Messages.BugzillaTaskEditorPage_Error, fieldString);
 			}
-			titleString = Messages.BugzillaTaskEditorPage_Confirm + Messages.BugzillaTaskEditorPage_match_Detail;
+			titleString = Messages.BugzillaTaskEditorPage_ErrorDetailTitle;
 			break;
 		default:
-			resultString = ""; //$NON-NLS-1$
-			titleString = ""; //$NON-NLS-1$
-			break;
+			throw new RuntimeException("unexpected BugzillaStatus: " + bugzillaStatus.getCode()); //$NON-NLS-1$
 		}
 
 		final String resultDetailString = resultDetail;
diff --git a/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/editor/Messages.java b/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/editor/Messages.java
index d4d047040..3ca6ddef1 100644
--- a/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/editor/Messages.java
+++ b/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/editor/Messages.java
@@ -71,6 +71,8 @@ public class Messages extends NLS {
 
 	public static String BugzillaTaskEditorPage_Confirm;
 
+	public static String BugzillaTaskEditorPage_ConfirmDetailTitle;
+
 	public static String BugzillaTaskEditorPage_Content_Assist_for_Error_Available;
 
 	public static String BugzillaTaskEditorPage_DetailLine;
@@ -81,6 +83,8 @@ public class Messages extends NLS {
 
 	public static String BugzillaTaskEditorPage_Error_Label_N;
 
+	public static String BugzillaTaskEditorPage_ErrorDetailTitle;
+
 	public static String BugzillaTaskEditorPage_Legal_Value_1;
 
 	public static String BugzillaTaskEditorPage_Legal_Value_N;
diff --git a/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/editor/messages.properties b/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/editor/messages.properties
index 2eea51162..a65175a89 100644
--- a/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/editor/messages.properties
+++ b/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/editor/messages.properties
@@ -33,11 +33,13 @@ BugzillaTaskEditorNewCommentPart_publicComment=public Comment
 BugzillaTaskEditorPage_Anonymous_can_not_submit_Tasks=Anonymous can not submit Tasks\!
 BugzillaTaskEditorPage_Changes_Submitted_Message=Changes submitted
 BugzillaTaskEditorPage_Confirm=Confirm
+BugzillaTaskEditorPage_ConfirmDetailTitle=Confirm match Detail
 BugzillaTaskEditorPage_Content_Assist_for_Error_Available=Content Assist for Error Available ({0})
 BugzillaTaskEditorPage_DetailLine=\t\t{0}\n
 BugzillaTaskEditorPage_Error=Error
 BugzillaTaskEditorPage_Error_Label_1="{0}"
 BugzillaTaskEditorPage_Error_Label_N=, "{0}"
+BugzillaTaskEditorPage_ErrorDetailTitle=Error match Detail
 BugzillaTaskEditorPage_Legal_Value_1={0}
 BugzillaTaskEditorPage_Legal_Value_N=, \n{0}
 BugzillaTaskEditorPage_Legal_Values_More=legal values are:\n{0}