NEW - bug 280811: [editor] border is cut off if type of summary is not SHORT_RICH_TEXT

https://bugs.eclipse.org/bugs/show_bug.cgi?id=280811

1 files changed, 10 insertions, 3 deletions

diff --git a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskEditorSummaryPart.java b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskEditorSummaryPart.java
index 542390238..59414d58f 100644
--- a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskEditorSummaryPart.java
+++ b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskEditorSummaryPart.java
@@ -13,6 +13,7 @@
 package org.eclipse.mylyn.internal.tasks.ui.editors;
 
 import org.eclipse.jface.layout.GridDataFactory;
+import org.eclipse.jface.layout.GridLayoutFactory;
 import org.eclipse.mylyn.internal.provisional.commons.ui.CommonImages;
 import org.eclipse.mylyn.internal.tasks.ui.util.TasksUiInternal;
 import org.eclipse.mylyn.tasks.core.ITaskMapping;
@@ -121,15 +122,21 @@ public class TaskEditorSummaryPart extends AbstractTaskEditorPart {
 	private void addSummaryText(Composite composite, final FormToolkit toolkit) {
 		summaryEditor = createAttributeEditor(getTaskData().getRoot().getMappedAttribute(TaskAttribute.SUMMARY));
 		if (summaryEditor != null) {
-			// create composite to hold rounded border
 			if (summaryEditor instanceof RichTextAttributeEditor) {
+				// create composite to hold rounded border
 				Composite roundedBorder = EditorUtil.createBorder(composite, toolkit, !summaryEditor.isReadOnly());
 				summaryEditor.createControl(roundedBorder, toolkit);
 				EditorUtil.setHeaderFontSizeAndStyle(summaryEditor.getControl());
 			} else {
-				summaryEditor.createControl(composite, toolkit);
+				final Composite border = toolkit.createComposite(composite);
 				GridDataFactory.fillDefaults().align(SWT.FILL, SWT.BEGINNING).hint(EditorUtil.MAXIMUM_WIDTH,
-						SWT.DEFAULT).grab(true, false).applyTo(summaryEditor.getControl());
+						SWT.DEFAULT).grab(true, false).applyTo(border);
+				// leave some padding for the border of the attribute editor
+				border.setLayout(GridLayoutFactory.fillDefaults().margins(1, 4).create());
+				summaryEditor.createControl(border, toolkit);
+				GridDataFactory.fillDefaults().align(SWT.FILL, SWT.CENTER).grab(true, false).applyTo(
+						summaryEditor.getControl());
+				toolkit.paintBordersFor(border);
 			}
 			getTaskEditorPage().getAttributeEditorToolkit().adapt(summaryEditor);
 		}