Skip to main content
summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorrelves2009-02-27 20:06:32 -0500
committerrelves2009-02-27 20:06:32 -0500
commit73bee21d3e2c23524369d257bf04d0f3a4d33837 (patch)
tree1f55775d1784f6d3d4760bfe6ebb77f3dd0b792e
parentca484bd017f26d47ff341c135a44f43521162146 (diff)
downloadorg.eclipse.mylyn.tasks-73bee21d3e2c23524369d257bf04d0f3a4d33837.tar.gz
org.eclipse.mylyn.tasks-73bee21d3e2c23524369d257bf04d0f3a4d33837.tar.xz
org.eclipse.mylyn.tasks-73bee21d3e2c23524369d257bf04d0f3a4d33837.zip
NEW - bug 247571: [externalization] participant may miss save
https://bugs.eclipse.org/bugs/show_bug.cgi?id=247571
-rw-r--r--org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/internal/tasks/core/RepositoryExternalizationParticipant.java2
-rw-r--r--org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/internal/tasks/core/externalization/TaskListExternalizationParticipant.java2
-rw-r--r--org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/ActivityExternalizationParticipant.java4
3 files changed, 4 insertions, 4 deletions
diff --git a/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/internal/tasks/core/RepositoryExternalizationParticipant.java b/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/internal/tasks/core/RepositoryExternalizationParticipant.java
index 9aa6603b4..5b92741f1 100644
--- a/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/internal/tasks/core/RepositoryExternalizationParticipant.java
+++ b/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/internal/tasks/core/RepositoryExternalizationParticipant.java
@@ -71,10 +71,10 @@ public class RepositoryExternalizationParticipant extends AbstractExternalizatio
@Override
public void save(File targetFile, IProgressMonitor monitor) throws CoreException {
- repositoryManager.saveRepositories(targetFile.getAbsolutePath());
synchronized (RepositoryExternalizationParticipant.this) {
dirty = false;
}
+ repositoryManager.saveRepositories(targetFile.getAbsolutePath());
}
@Override
diff --git a/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/internal/tasks/core/externalization/TaskListExternalizationParticipant.java b/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/internal/tasks/core/externalization/TaskListExternalizationParticipant.java
index ac4fbf906..2c90dadcc 100644
--- a/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/internal/tasks/core/externalization/TaskListExternalizationParticipant.java
+++ b/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/internal/tasks/core/externalization/TaskListExternalizationParticipant.java
@@ -123,10 +123,10 @@ public class TaskListExternalizationParticipant extends AbstractExternalizationP
public void save(final File targetFile, IProgressMonitor monitor) throws CoreException {
ITaskListRunnable saveRunnable = new ITaskListRunnable() {
public void execute(IProgressMonitor monitor) throws CoreException {
- taskListWriter.writeTaskList(taskList, targetFile);
synchronized (TaskListExternalizationParticipant.this) {
dirty = false;
}
+ taskListWriter.writeTaskList(taskList, targetFile);
}
};
diff --git a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/ActivityExternalizationParticipant.java b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/ActivityExternalizationParticipant.java
index ad2482b5c..f424ca7a1 100644
--- a/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/ActivityExternalizationParticipant.java
+++ b/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/ActivityExternalizationParticipant.java
@@ -28,6 +28,7 @@ import org.eclipse.mylyn.tasks.core.ITaskActivityListener;
/**
* @author Rob Elves
*/
+@SuppressWarnings("restriction")
public class ActivityExternalizationParticipant extends AbstractExternalizationParticipant implements
ITaskActivityListener {
@@ -41,15 +42,14 @@ public class ActivityExternalizationParticipant extends AbstractExternalizationP
this.manager = manager;
}
- @SuppressWarnings("restriction")
@Override
public void execute(IExternalizationContext context, IProgressMonitor monitor) throws CoreException {
Assert.isNotNull(context);
switch (context.getKind()) {
case SAVE:
if (ContextCorePlugin.getDefault() != null && ContextCorePlugin.getContextManager() != null) {
- ContextCorePlugin.getContextManager().saveActivityMetaContext();
setDirty(false);
+ ContextCorePlugin.getContextManager().saveActivityMetaContext();
}
break;
case LOAD:

Back to the top