NEW - bug 315921: fix attachment details nits

https://bugs.eclipse.org/bugs/show_bug.cgi?id=315921

5 files changed, 20 insertions, 13 deletions

diff --git a/org.eclipse.mylyn.bugzilla.ui/plugin.properties b/org.eclipse.mylyn.bugzilla.ui/plugin.properties
index 41aa6bc12..60635e8be 100644
--- a/org.eclipse.mylyn.bugzilla.ui/plugin.properties
+++ b/org.eclipse.mylyn.bugzilla.ui/plugin.properties
@@ -15,3 +15,11 @@ Bundle-Name = Mylyn Bugzilla Connector UI
 bugzilla.repository.name=Bugzilla Repository
 BugzillaRepositoryConnector.name=Bugzilla Repository Connector 
 tasklist.BugzillaConnectorUi.name=Bugzilla Repository UI
+
+Mark_not_obsolete_Action_Label = Mark not obsolete
+Mark_not_obsolete_Action_Tooltip = Mark attachment as not obsolete
+Mark_obsolete_Action_Label = Mark obsolete
+Mark_obsolete_Action_Tooltip = Mark attachment as obsolete
+Details_Action_Label = Details...
+Details_Action_Tooltip = Attachment Details
+Mark_as_Menu_Label = Mark as
\ No newline at end of file
diff --git a/org.eclipse.mylyn.bugzilla.ui/plugin.xml b/org.eclipse.mylyn.bugzilla.ui/plugin.xml
index 6b4f00a39..29d438f41 100644
--- a/org.eclipse.mylyn.bugzilla.ui/plugin.xml
+++ b/org.eclipse.mylyn.bugzilla.ui/plugin.xml
@@ -95,29 +95,29 @@
                class="org.eclipse.mylyn.internal.bugzilla.ui.action.BugzillaNotObsoleteAttachmentAction"
                enablesFor="*"
                id="org.eclipse.mylyn.bugzilla.ui.contribution.attachment.notobsolete"
-               label="Mark not obsolete"
+               label="%Mark_not_obsolete_Action_Label"
                menubarPath="org.eclipse.mylyn.bugzilla.ui.attachments.mark/markadditions"
-               tooltip="Mark attachment as not obsolete">
+               tooltip="%Mark_not_obsolete_Action_Tooltip">
          </action>
          <action
                class="org.eclipse.mylyn.internal.bugzilla.ui.action.BugzillaObsoleteAttachmentAction"
                enablesFor="*"
                id="org.eclipse.mylyn.bugzilla.ui.contribution.attachment.obsolete"
-               label="Mark obsolete"
+               label="%Mark_obsolete_Action_Label"
                menubarPath="org.eclipse.mylyn.bugzilla.ui.attachments.mark/markadditions"
-               tooltip="Mark attachment as obsolete">
+               tooltip="%Mark_obsolete_Action_Tooltip">
          </action>
          <action
                class="org.eclipse.mylyn.internal.bugzilla.ui.action.BugzillaAttachmentUpdateAction"
                enablesFor="*"
                id="org.eclipse.mylyn.bugzilla.ui.contribution.attachment.update"
-               label="Detail..."
+               label="%Details_Action_Label"
                menubarPath="org.eclipse.mylyn.bugzilla.ui.attachments.mark"
-               tooltip="Attachment Details">
+               tooltip="%Details_Action_Tooltip">
          </action>
           <menu
                 id="org.eclipse.mylyn.bugzilla.ui.attachments.mark"
-                label="Mark as"
+                label="%Mark_as_Menu_Label"
                 path="markadditions">
           </menu>
       </objectContribution>
diff --git a/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/wizard/BugzillaAttachmentWizard.java b/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/wizard/BugzillaAttachmentWizard.java
index 29192b08c..98e753261 100644
--- a/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/wizard/BugzillaAttachmentWizard.java
+++ b/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/wizard/BugzillaAttachmentWizard.java
@@ -16,20 +16,16 @@ import java.lang.reflect.InvocationTargetException;
 import org.eclipse.core.runtime.IProgressMonitor;
 import org.eclipse.core.runtime.IStatus;
 import org.eclipse.core.runtime.Status;
-import org.eclipse.jface.dialogs.IMessageProvider;
 import org.eclipse.jface.operation.IRunnableWithProgress;
 import org.eclipse.jface.wizard.Wizard;
 import org.eclipse.mylyn.commons.core.StatusHandler;
 import org.eclipse.mylyn.internal.bugzilla.ui.BugzillaUiPlugin;
 import org.eclipse.mylyn.internal.bugzilla.ui.action.ChangeAttachmentJob;
-import org.eclipse.mylyn.internal.bugzilla.ui.editor.BugzillaTaskEditorPage;
 import org.eclipse.mylyn.tasks.core.ITaskAttachment;
 import org.eclipse.mylyn.tasks.core.data.TaskAttribute;
 import org.eclipse.mylyn.tasks.ui.editors.AttributeEditorFactory;
 import org.eclipse.mylyn.tasks.ui.editors.TaskEditor;
 import org.eclipse.swt.widgets.Shell;
-import org.eclipse.ui.PlatformUI;
-import org.eclipse.ui.forms.editor.IFormPage;
 
 public class BugzillaAttachmentWizard extends Wizard {
 
@@ -56,7 +52,7 @@ public class BugzillaAttachmentWizard extends Wizard {
 		this.taskEditor = taskEditor;
 		this.attachment = attachment;
 		setNeedsProgressMonitor(true);
-
+		setWindowTitle(Messages.BugzillaAttachmentWizard_Attachment_Details_Dialog_Title);
 	}
 
 	@Override
@@ -107,7 +103,7 @@ public class BugzillaAttachmentWizard extends Wizard {
 		}
 	}
 */
-	
+
 	private boolean runInWizard(final ChangeAttachmentJob job) {
 		try {
 			getContainer().run(true, true, new IRunnableWithProgress() {
diff --git a/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/wizard/Messages.java b/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/wizard/Messages.java
index c49f0f4de..62372b3a7 100644
--- a/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/wizard/Messages.java
+++ b/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/wizard/Messages.java
@@ -16,6 +16,8 @@ import org.eclipse.osgi.util.NLS;
 public class Messages extends NLS {
 	private static final String BUNDLE_NAME = "org.eclipse.mylyn.internal.bugzilla.ui.wizard.messages"; //$NON-NLS-1$
 
+	public static String BugzillaAttachmentWizard_Attachment_Details_Dialog_Title;
+
 	public static String BugzillaAttachmentWizard_Now_synchronize_the_Task;
 
 	public static String BugzillaAttachmentWizardPage_Advanced;
diff --git a/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/wizard/messages.properties b/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/wizard/messages.properties
index aa7cea206..12587af45 100644
--- a/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/wizard/messages.properties
+++ b/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/wizard/messages.properties
@@ -1,3 +1,4 @@
+BugzillaAttachmentWizard_Attachment_Details_Dialog_Title=Attachment Details
 BugzillaAttachmentWizard_Now_synchronize_the_Task=Updating Attachment: Now synchronize the Task
 BugzillaAttachmentWizardPage_Advanced=Advanced
 BugzillaAttachmentWizardPage_Description=Show Attachment {0} Details for Bug {1}