1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
|
/*******************************************************************************
* Copyright (c) 2015 Blaine Lewis
* All rights reserved. This program and the accompanying materials
* are made available under the terms of the Eclipse Public License v1.0
* which accompanies this distribution, and is available at
* http://www.eclipse.org/legal/epl-v10.html
*
* Contributors:
* Blaine Lewis
*******************************************************************************/
package org.eclipse.mylyn.reviews.internal.core;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;
import java.util.Collection;
import org.eclipse.core.runtime.CoreException;
import org.eclipse.mylyn.internal.tasks.core.TaskContainerDelta;
import org.eclipse.mylyn.internal.tasks.core.TaskContainerDelta.Kind;
import org.eclipse.mylyn.internal.tasks.core.TaskList;
import org.eclipse.mylyn.internal.tasks.core.TaskRepositoryManager;
import org.eclipse.mylyn.internal.tasks.core.TaskTask;
import org.eclipse.mylyn.internal.tasks.core.data.TaskDataManager;
import org.eclipse.mylyn.reviews.core.spi.ReviewsConnector;
import org.eclipse.mylyn.tasks.core.AbstractRepositoryConnector;
import org.eclipse.mylyn.tasks.core.ITask;
import org.eclipse.mylyn.tasks.core.TaskRepository;
import org.eclipse.mylyn.tasks.core.data.TaskAttribute;
import org.eclipse.mylyn.tasks.core.data.TaskAttributeMapper;
import org.eclipse.mylyn.tasks.core.data.TaskData;
import org.junit.Before;
import org.junit.Test;
import org.mockito.Matchers;
import com.google.common.collect.ImmutableSet;
@SuppressWarnings("restriction")
public class TaskReviewMappingStoreTest {
final String taskUrl1 = "https://bugs.eclipse.org/bugs/show_bug.cgi?id=477635";
final String taskUrl2 = "https://bugs.eclipse.org/bugs/show_bug.cgi?id=345343";
final String notATaskUrl = "www.hello.com";
ITask task1;
ITask task2;
final String reviewUrl1 = "https://git.eclipse.org/r/#/c/56269/";
final String reviewUrl2 = "https://git.eclipse.org/r/#/c/43534/";
final String reviewUrlNoTask = "https://git.eclipse.org/r/#/c/12333/";
final String descriptionWithTaskUrl1 = "477635: [UCOSP] contribute reviews section to task editor showing"
+ " associated reviews Change-Id: I3a38d375688aad7be36bfd58c3311d692eb51ed Task-Url: " + taskUrl1
+ " Signed-off-by: Blaine Lewis <Blaine1@ualberta.ca>";
final String descriptionWithTaskUrl2 = "477635: [UCOSP] contribute reviews section to task editor showing"
+ " associated reviews Change-Id: I3a38d375688aad7be36bfd58c3311d692eb51ed Task-Url: " + taskUrl2
+ " Signed-off-by: Blaine Lewis <Blaine1@ualberta.ca>";
final String descriptionWithReviewAndTaskUrl = "477635: [UCOSP] contribute reviews section to task editor showing"
+ " associated reviews " + reviewUrl2 + " Change-Id: I3a38d375688aad7be36bfd58c3311d692eb51ed Task-Url: "
+ taskUrl1 + " Signed-off-by: Blaine Lewis <Blaine1@ualberta.ca>";
final String descriptionWithNoTaskUrl = "477635: [UCOSP] contribute reviews section to task editor showing"
+ " associated reviews Change-Id: I3a38d375688aad7be36bfd58c3311d692eb51ed "
+ " Signed-off-by: Blaine Lewis <Blaine1@ualberta.ca>";
final String descriptionWithNotATaskUrl = "477635: [UCOSP] contribute reviews section to task editor showing"
+ " associated reviews Change-Id: I3a38d375688aad7be36bfd58c3311d692eb51ed " + notATaskUrl
+ " Signed-off-by: Blaine Lewis <Blaine1@ualberta.ca>";
ITask review1;
ITask review2;
ITask reviewNoTask;
private TaskDataManager taskDataManager;
@Before
public void setup() {
review1 = new TaskTask("reviewKind", reviewUrl1, "3");
review1.setUrl(reviewUrl1);
review2 = new TaskTask("reviewKind", reviewUrl2, "4");
review2.setUrl(reviewUrl2);
reviewNoTask = new TaskTask("reviewKind", reviewUrlNoTask, "5");
reviewNoTask.setUrl(reviewUrlNoTask);
task1 = new TaskTask("taskKind", taskUrl1, "1");
task1.setUrl(taskUrl1);
task2 = new TaskTask("taskKind", taskUrl2, "2");
task2.setUrl(taskUrl2);
}
public TaskReviewsMappingsStore getEmptyTaskReviewStore() {
TaskRepositoryManager repositoryManager = mock(TaskRepositoryManager.class);
ReviewsConnector reviewConnector = mock(ReviewsConnector.class);
AbstractRepositoryConnector taskConnector = mock(AbstractRepositoryConnector.class);
taskDataManager = mock(TaskDataManager.class);
when(repositoryManager.getConnectorForRepositoryTaskUrl(Matchers.anyString())).thenReturn(reviewConnector);
when(repositoryManager.getRepositoryConnector("reviewKind")).thenReturn(reviewConnector);
when(repositoryManager.getRepositoryConnector("taskKind")).thenReturn(taskConnector);
TaskReviewsMappingsStore taskReviewsMappingStore = new MockTaskReviewsMappingsStore(mock(TaskList.class),
repositoryManager);
return taskReviewsMappingStore;
}
public TaskData addReviewData(ITask review, String description) throws CoreException {
TaskData reviewData = new TaskData(new TaskAttributeMapper(new TaskRepository("", "")), "", review.getUrl(),
review.getTaskId());
reviewData.getRoot().createMappedAttribute(TaskAttribute.DESCRIPTION).setValue(description);
when(taskDataManager.getTaskData(review)).thenReturn(reviewData);
return reviewData;
}
@Test
public void testAdd() throws CoreException {
TaskReviewsMappingsStore taskReviewsMappingStore = getEmptyTaskReviewStore();
TaskData reviewData1 = addReviewData(review1, descriptionWithTaskUrl1);
TaskContainerDelta delta = new TaskContainerDelta(review1, Kind.ADDED);
taskReviewsMappingStore.addTaskAssocation(review1, reviewData1);
taskReviewsMappingStore.containersChanged(ImmutableSet.of(delta));
assertTrue(taskReviewsMappingStore.getReviewUrls(taskUrl1).contains(reviewUrl1));
assertTrue(taskReviewsMappingStore.getTaskUrl(review1).equals(taskUrl1));
}
@Test
public void testAddTwice() throws CoreException {
TaskReviewsMappingsStore taskReviewsMappingStore = getEmptyTaskReviewStore();
TaskData reviewData1 = addReviewData(review1, descriptionWithTaskUrl1);
TaskContainerDelta delta = new TaskContainerDelta(review1, Kind.ADDED);
taskReviewsMappingStore.addTaskAssocation(review1, reviewData1);
taskReviewsMappingStore.containersChanged(ImmutableSet.of(delta));
taskReviewsMappingStore.addTaskAssocation(review1, reviewData1);
taskReviewsMappingStore.containersChanged(ImmutableSet.of(delta));
Collection<String> reviewUrls = taskReviewsMappingStore.getReviewUrls(taskUrl1);
assertTrue(reviewUrls.contains(reviewUrl1));
assertTrue(reviewUrls.size() == 1);
assertTrue(taskReviewsMappingStore.getTaskUrl(review1).equals(taskUrl1));
}
@Test
public void testAddMultiple() throws CoreException {
TaskReviewsMappingsStore taskReviewsMappingStore = getEmptyTaskReviewStore();
TaskData reviewData1 = addReviewData(review1, descriptionWithTaskUrl1);
TaskData reviewData2 = addReviewData(review2, descriptionWithTaskUrl2);
TaskContainerDelta delta1 = new TaskContainerDelta(review1, Kind.ADDED);
TaskContainerDelta delta2 = new TaskContainerDelta(review2, Kind.ADDED);
taskReviewsMappingStore.addTaskAssocation(review1, reviewData1);
taskReviewsMappingStore.addTaskAssocation(review2, reviewData2);
taskReviewsMappingStore.containersChanged(ImmutableSet.of(delta1, delta2));
assertTrue(taskReviewsMappingStore.getReviewUrls(taskUrl1).contains(reviewUrl1));
assertTrue(taskReviewsMappingStore.getTaskUrl(review1).equals(taskUrl1));
assertTrue(taskReviewsMappingStore.getReviewUrls(taskUrl2).contains(reviewUrl2));
assertTrue(taskReviewsMappingStore.getTaskUrl(review2).equals(taskUrl2));
}
@Test
public void testReviewNotLinkedToReview() throws CoreException {
TaskReviewsMappingsStore taskReviewsMappingStore = getEmptyTaskReviewStore();
TaskData reviewData1 = addReviewData(review1, descriptionWithReviewAndTaskUrl);
TaskContainerDelta delta = new TaskContainerDelta(review1, Kind.ADDED);
taskReviewsMappingStore.addTaskAssocation(review1, reviewData1);
taskReviewsMappingStore.containersChanged(ImmutableSet.of(delta));
assertFalse(taskReviewsMappingStore.getReviewUrls(reviewUrl2).contains(reviewUrl1));
assertTrue(taskReviewsMappingStore.getReviewUrls(taskUrl1).contains(reviewUrl1));
assertTrue(taskReviewsMappingStore.getTaskUrl(review1).equals(taskUrl1));
}
@Test
public void testRemove() throws CoreException {
TaskReviewsMappingsStore taskReviewsMappingStore = getEmptyTaskReviewStore();
TaskData reviewData1 = addReviewData(review1, descriptionWithTaskUrl1);
TaskContainerDelta delta = new TaskContainerDelta(review1, Kind.ADDED);
taskReviewsMappingStore.addTaskAssocation(review1, reviewData1);
taskReviewsMappingStore.containersChanged(ImmutableSet.of(delta));
assertTrue(taskReviewsMappingStore.getReviewUrls(taskUrl1).contains(reviewUrl1));
delta = new TaskContainerDelta(review1, Kind.DELETED);
taskReviewsMappingStore.containersChanged(ImmutableSet.of(delta));
assertFalse(taskReviewsMappingStore.getReviewUrls(taskUrl1).contains(reviewUrl1));
assertTrue(taskReviewsMappingStore.getTaskUrl(review1) == null);
}
@Test
public void testUpdate() throws CoreException {
TaskReviewsMappingsStore taskReviewsMappingStore = getEmptyTaskReviewStore();
TaskData reviewData1 = addReviewData(review1, descriptionWithTaskUrl1);
TaskContainerDelta delta = new TaskContainerDelta(review1, Kind.ADDED);
taskReviewsMappingStore.addTaskAssocation(review1, reviewData1);
taskReviewsMappingStore.containersChanged(ImmutableSet.of(delta));
assertTrue(taskReviewsMappingStore.getReviewUrls(taskUrl1).contains(reviewUrl1));
reviewData1 = addReviewData(review1, descriptionWithTaskUrl2);
delta = new TaskContainerDelta(review1, Kind.CONTENT);
taskReviewsMappingStore.addTaskAssocation(review1, reviewData1);
taskReviewsMappingStore.containersChanged(ImmutableSet.of(delta));
assertFalse(taskReviewsMappingStore.getReviewUrls(taskUrl1).contains(reviewUrl1));
assertTrue(taskReviewsMappingStore.getReviewUrls(taskUrl2).contains(reviewUrl1));
assertEquals(taskUrl2, taskReviewsMappingStore.getTaskUrl(review1));
}
@Test
public void testUpdateNoTask() throws CoreException {
TaskReviewsMappingsStore taskReviewsMappingStore = getEmptyTaskReviewStore();
TaskData reviewData1 = addReviewData(review1, descriptionWithTaskUrl1);
TaskContainerDelta delta = new TaskContainerDelta(review1, Kind.ADDED);
taskReviewsMappingStore.addTaskAssocation(review1, reviewData1);
taskReviewsMappingStore.containersChanged(ImmutableSet.of(delta));
assertTrue(taskReviewsMappingStore.getReviewUrls(taskUrl1).contains(reviewUrl1));
reviewData1 = addReviewData(review1, descriptionWithNoTaskUrl);
delta = new TaskContainerDelta(review1, Kind.CONTENT);
taskReviewsMappingStore.addTaskAssocation(review1, reviewData1);
taskReviewsMappingStore.containersChanged(ImmutableSet.of(delta));
assertFalse(taskReviewsMappingStore.getReviewUrls(taskUrl1).contains(reviewUrl1));
assertTrue(taskReviewsMappingStore.getTaskUrl(review1) == null);
}
@Test
public void testAddNoTask() throws CoreException {
TaskReviewsMappingsStore taskReviewsMappingStore = getEmptyTaskReviewStore();
TaskData reviewData1 = addReviewData(review1, descriptionWithNoTaskUrl);
TaskContainerDelta delta = new TaskContainerDelta(review1, Kind.ADDED);
taskReviewsMappingStore.addTaskAssocation(review1, reviewData1);
taskReviewsMappingStore.containersChanged(ImmutableSet.of(delta));
assertTrue(taskReviewsMappingStore.getTaskUrl(review1) == null);
}
@Test
public void testAddANonTaskUrl() throws CoreException {
TaskReviewsMappingsStore taskReviewsMappingStore = getEmptyTaskReviewStore();
TaskData reviewData1 = addReviewData(review1, descriptionWithNotATaskUrl);
TaskContainerDelta delta = new TaskContainerDelta(review1, Kind.ADDED);
taskReviewsMappingStore.addTaskAssocation(review1, reviewData1);
taskReviewsMappingStore.containersChanged(ImmutableSet.of(delta));
assertTrue(taskReviewsMappingStore.getTaskUrl(review1) == null);
}
class MockTaskReviewsMappingsStore extends TaskReviewsMappingsStore {
public MockTaskReviewsMappingsStore(TaskList taskList, TaskRepositoryManager repositoryManager) {
super(taskList, repositoryManager);
}
@Override
ITask getTaskByUrl(String url) {
switch (url) {
case taskUrl1:
return task1;
case taskUrl2:
return task2;
case reviewUrl1:
return review1;
case reviewUrl2:
return review2;
}
return null;
}
}
}
|
