summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTomasz Zarna2013-07-24 08:46:31 (EDT)
committerTomasz Zarna2013-10-04 05:44:24 (EDT)
commit25fe9c6a7437139d7112da3f4aa9767cd2bc1e3c (patch)
treee4deb3774494fbde41f5ee05d0e7cc6691332c77
parent74a322d3803459426605448868a8fa38eb1873f9 (diff)
downloadorg.eclipse.mylyn.reviews-25fe9c6a7437139d7112da3f4aa9767cd2bc1e3c.zip
org.eclipse.mylyn.reviews-25fe9c6a7437139d7112da3f4aa9767cd2bc1e3c.tar.gz
org.eclipse.mylyn.reviews-25fe9c6a7437139d7112da3f4aa9767cd2bc1e3c.tar.bz2
413630: delete methods in GerritClient that are not called by anyonerefs/changes/92/14692/4
Bug: 413630 Change-Id: I239b77440eb50063f9bc49b69fa0b30676555758 Task-Url: https://bugs.eclipse.org/bugs/show_bug.cgi?id=413630 Signed-off-by: Tomasz Zarna <tomasz.zarna@tasktop.com>
-rw-r--r--org.eclipse.mylyn.gerrit.core/src/org/eclipse/mylyn/internal/gerrit/core/client/GerritClient.java56
1 files changed, 1 insertions, 55 deletions
diff --git a/org.eclipse.mylyn.gerrit.core/src/org/eclipse/mylyn/internal/gerrit/core/client/GerritClient.java b/org.eclipse.mylyn.gerrit.core/src/org/eclipse/mylyn/internal/gerrit/core/client/GerritClient.java
index 985fec5..7afa4e3 100644
--- a/org.eclipse.mylyn.gerrit.core/src/org/eclipse/mylyn/internal/gerrit/core/client/GerritClient.java
+++ b/org.eclipse.mylyn.gerrit.core/src/org/eclipse/mylyn/internal/gerrit/core/client/GerritClient.java
@@ -4,7 +4,7 @@
* are made available under the terms of the Eclipse Public License v1.0
* which accompanies this distribution, and is available at
* http://www.eclipse.org/legal/epl-v10.html
- *
+ *
* Contributors:
* Sony Ericsson/ST Ericsson - initial API and implementation
* Tasktop Technologies - improvements
@@ -203,8 +203,6 @@ public class GerritClient extends ReviewsClient {
private Account myAcount;
- private AccountDiffPreference myDiffPreference;
-
private Version myVersion;
private final Map<Class<? extends RemoteJsonService>, RemoteJsonService> serviceByClass;
@@ -362,29 +360,6 @@ public class GerritClient extends ReviewsClient {
return config;
}
- /**
- * @deprecated Do not use, this method is going to be removed in 2.1. See bug 413630.
- */
- @Deprecated
- public AccountDiffPreference getDiffPreference(IProgressMonitor monitor) throws GerritException {
- synchronized (this) {
- if (myDiffPreference != null) {
- return myDiffPreference;
- }
- }
- AccountDiffPreference diffPreference = execute(monitor, new Operation<AccountDiffPreference>() {
- @Override
- public void execute(IProgressMonitor monitor) throws GerritException {
- getAccountService(monitor).myDiffPreferences(this);
- }
- });
-
- synchronized (this) {
- myDiffPreference = diffPreference;
- }
- return myDiffPreference;
- }
-
public GerritSystemInfo getInfo(IProgressMonitor monitor) throws GerritException {
Version version = getCachedVersion(monitor);
List<ContributorAgreement> contributorAgreements = null;
@@ -797,20 +772,6 @@ public class GerritClient extends ReviewsClient {
return getConfiguration();
}
- /**
- * @deprecated Do not use, this method is going to be removed in 2.1. See bug 413630.
- */
- @Deprecated
- public ChangeDetail publish(String reviewId, int patchSetId, IProgressMonitor monitor) throws GerritException {
- final PatchSet.Id id = new PatchSet.Id(new Change.Id(id(reviewId)), patchSetId);
- return execute(monitor, new Operation<ChangeDetail>() {
- @Override
- public void execute(IProgressMonitor monitor) throws GerritException {
- getChangeManageService(monitor).publish(id, this);
- }
- });
- }
-
public ChangeDetail rebase(String reviewId, int patchSetId, IProgressMonitor monitor) throws GerritException {
final PatchSet.Id id = new PatchSet.Id(new Change.Id(id(reviewId)), patchSetId);
return execute(monitor, new Operation<ChangeDetail>() {
@@ -845,21 +806,6 @@ public class GerritClient extends ReviewsClient {
}
}
- /**
- * @deprecated Do not use, this method is going to be removed in 2.1. See bug 413630.
- */
- @Deprecated
- public ChangeDetail revert(String reviewId, int patchSetId, final String message, IProgressMonitor monitor)
- throws GerritException {
- final PatchSet.Id id = new PatchSet.Id(new Change.Id(id(reviewId)), patchSetId);
- return execute(monitor, new Operation<ChangeDetail>() {
- @Override
- public void execute(IProgressMonitor monitor) throws GerritException {
- getChangeManageService(monitor).revertChange(id, message, this);
- }
- });
- }
-
public ChangeDetail submit(String reviewId, int patchSetId, IProgressMonitor monitor) throws GerritException {
final PatchSet.Id id = new PatchSet.Id(new Change.Id(id(reviewId)), patchSetId);
if (hasJsonRpcApi(monitor)) {