Skip to main content
summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBrandon Dong2016-08-17 18:20:03 -0400
committerBrandon Dong2016-08-19 18:06:51 -0400
commit86309eec9023bb718e54ccf9f2603b9d4fe0d0b1 (patch)
tree1199a81e623565186e8641263db36e0af4c8bc91 /org.eclipse.mylyn.reviews.ui/src
parentd60702e301a7b144965ed031fa46ad10679d4775 (diff)
downloadorg.eclipse.mylyn.reviews-86309eec9023bb718e54ccf9f2603b9d4fe0d0b1.tar.gz
org.eclipse.mylyn.reviews-86309eec9023bb718e54ccf9f2603b9d4fe0d0b1.tar.xz
org.eclipse.mylyn.reviews-86309eec9023bb718e54ccf9f2603b9d4fe0d0b1.zip
494678: Patch Set UI does not properly refresh for new inline comments
Change-Id: I801415e45fb8c387c3f25ffa6fa7ca05513692cb Task-Url: https://bugs.eclipse.org/bugs/show_bug.cgi?id=494678 Signed-off-by: Brandon Dong <brandon.dong@tasktop.com>
Diffstat (limited to 'org.eclipse.mylyn.reviews.ui/src')
-rw-r--r--org.eclipse.mylyn.reviews.ui/src/org/eclipse/mylyn/reviews/ui/spi/editor/ReviewSetContentSection.java14
1 files changed, 9 insertions, 5 deletions
diff --git a/org.eclipse.mylyn.reviews.ui/src/org/eclipse/mylyn/reviews/ui/spi/editor/ReviewSetContentSection.java b/org.eclipse.mylyn.reviews.ui/src/org/eclipse/mylyn/reviews/ui/spi/editor/ReviewSetContentSection.java
index de4b2260..8fc415df 100644
--- a/org.eclipse.mylyn.reviews.ui/src/org/eclipse/mylyn/reviews/ui/spi/editor/ReviewSetContentSection.java
+++ b/org.eclipse.mylyn.reviews.ui/src/org/eclipse/mylyn/reviews/ui/spi/editor/ReviewSetContentSection.java
@@ -135,10 +135,13 @@ public class ReviewSetContentSection {
reviewObserver = new RemoteEmfObserver<IRepository, IReview, String, Date>() {
@Override
public void updated(boolean modified) {
- if (reviewConsumer.getRemoteObject() != null && section.isExpanded() && modified) {
- itemSetConsumer.retrieve(false);
- updateMessage();
- createButtons();
+ if (reviewConsumer.getRemoteObject() != null && modified) {
+ if (section.isExpanded()) {
+ itemSetConsumer.retrieve(false);
+ updateMessage();
+ createButtons();
+ }
+ set.setInNeedOfRetrieval(!section.isExpanded());
}
}
};
@@ -148,8 +151,9 @@ public class ReviewSetContentSection {
@Override
public void expansionStateChanged(ExpansionEvent e) {
if (e.getState()) {
- if (set.getItems().isEmpty()) {
+ if (set.getItems().isEmpty() || set.isInNeedOfRetrieval()) {
itemSetConsumer.retrieve(false);
+ set.setInNeedOfRetrieval(false);
}
updateMessage();
createButtons();

Back to the top