diff options
author | Sam Davis | 2016-02-10 21:53:32 +0000 |
---|---|---|
committer | Sam Davis | 2016-02-10 21:53:32 +0000 |
commit | ef18549e60b7a94fb55d6da76ef3c8262ef06268 (patch) | |
tree | c7bc96b93cbf4e5094d922e9f082188ddc62edac | |
parent | 1d7abde3373d15617b69b0b0f2b6dc3cf2d10c7f (diff) | |
download | org.eclipse.mylyn.reviews-ef18549e60b7a94fb55d6da76ef3c8262ef06268.tar.gz org.eclipse.mylyn.reviews-ef18549e60b7a94fb55d6da76ef3c8262ef06268.tar.xz org.eclipse.mylyn.reviews-ef18549e60b7a94fb55d6da76ef3c8262ef06268.zip |
improve error message when parsing short ID fails
Change-Id: Ie36d1279a55cdad56a95cac44c49079264da0c5f
-rw-r--r-- | org.eclipse.mylyn.gerrit.tests/src/org/eclipse/mylyn/internal/gerrit/core/remote/ReviewHarness.java | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/org.eclipse.mylyn.gerrit.tests/src/org/eclipse/mylyn/internal/gerrit/core/remote/ReviewHarness.java b/org.eclipse.mylyn.gerrit.tests/src/org/eclipse/mylyn/internal/gerrit/core/remote/ReviewHarness.java index a6ac5e8a6..3d5f3683b 100644 --- a/org.eclipse.mylyn.gerrit.tests/src/org/eclipse/mylyn/internal/gerrit/core/remote/ReviewHarness.java +++ b/org.eclipse.mylyn.gerrit.tests/src/org/eclipse/mylyn/internal/gerrit/core/remote/ReviewHarness.java @@ -152,20 +152,20 @@ class ReviewHarness { } String parseShortId(String commitMessage) { - String shortId = StringUtils.trimToEmpty(StringUtils.substringAfterLast(commitMessage, "/")); - shortId = StringUtils.substringBefore(shortId, " "); + String tail = StringUtils.trimToEmpty(StringUtils.substringAfterLast(commitMessage, "/")); + String shortId = StringUtils.substringBefore(tail, " "); try { Integer.parseInt(shortId); } catch (NumberFormatException e) { - fail("ShortId could not be parsed: " + e.getMessage()); + fail("ShortId could not be parsed from \"" + tail + "\". Commit message was: " + commitMessage); } return shortId; } void assertIsRecent(Date date) { long timeDelta = System.currentTimeMillis() - date.getTime(); - assertThat("Creation delta out of range : " + timeDelta + " ms", timeDelta > -CREATION_TIME_DELTA - && timeDelta < CREATION_TIME_DELTA, is(true)); + assertThat("Creation delta out of range : " + timeDelta + " ms", + timeDelta > -CREATION_TIME_DELTA && timeDelta < CREATION_TIME_DELTA, is(true)); } public void dispose() throws GerritException { @@ -241,8 +241,8 @@ class ReviewHarness { } }); - TaskRepository repository = TasksUiPlugin.getRepositoryManager().getRepository( - GerritFixture.current().getRepositoryUrl()); + TaskRepository repository = TasksUiPlugin.getRepositoryManager() + .getRepository(GerritFixture.current().getRepositoryUrl()); adminClient = GerritClient.create(repository, location); } return adminClient; |