summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTomasz Zarna2013-10-04 06:43:01 (EDT)
committerGerrit Code Review @ Eclipse.org2013-10-05 20:35:55 (EDT)
commit71fd97d78249b405a2f655d6520105dacfb41d59 (patch)
treea0255fd031ad1c6976ae7ec0e81e6fce82c6a558
parent14b36fd19c1479406b41094299fa0c7be6110a5a (diff)
downloadorg.eclipse.mylyn.incubator-71fd97d78249b405a2f655d6520105dacfb41d59.zip
org.eclipse.mylyn.incubator-71fd97d78249b405a2f655d6520105dacfb41d59.tar.gz
org.eclipse.mylyn.incubator-71fd97d78249b405a2f655d6520105dacfb41d59.tar.bz2
fix StatisticsReportingTest in Incubatorrefs/changes/25/17025/2
Change-Id: Ibe1b71fc15f79ff2d23241a9c7d38bacf06a0225 Signed-off-by: Tomasz Zarna <tomasz.zarna@tasktop.com>
-rw-r--r--org.eclipse.mylyn.sandbox.tests/src/org/eclipse/mylyn/sandbox/tests/StatisticsReportingTest.java9
-rw-r--r--org.eclipse.mylyn.web.tasks/src/org/eclipse/mylyn/internal/web/tasks/WebRepositorySettingsPage.java2
2 files changed, 6 insertions, 5 deletions
diff --git a/org.eclipse.mylyn.sandbox.tests/src/org/eclipse/mylyn/sandbox/tests/StatisticsReportingTest.java b/org.eclipse.mylyn.sandbox.tests/src/org/eclipse/mylyn/sandbox/tests/StatisticsReportingTest.java
index 9a69256..b724f25 100644
--- a/org.eclipse.mylyn.sandbox.tests/src/org/eclipse/mylyn/sandbox/tests/StatisticsReportingTest.java
+++ b/org.eclipse.mylyn.sandbox.tests/src/org/eclipse/mylyn/sandbox/tests/StatisticsReportingTest.java
@@ -18,6 +18,7 @@ import java.util.List;
import junit.framework.TestCase;
+import org.eclipse.core.runtime.jobs.IJobChangeEvent;
import org.eclipse.core.runtime.jobs.JobChangeAdapter;
import org.eclipse.jdt.internal.ui.packageview.PackageExplorerPart;
import org.eclipse.jdt.ui.JavaUI;
@@ -129,11 +130,11 @@ public class StatisticsReportingTest extends TestCase {
assertEquals(2f, editRatioCollector.getMylynRatio(-1));
}
- @SuppressWarnings("unused")
public void testSimpleSelection() {
mockExplorerSelection("A.java");
report.getStatisticsFromInteractionHistory(logger.getOutputFile(), new JobChangeAdapter() {
- public void done() {
+ @Override
+ public void done(IJobChangeEvent event) {
UsageStatisticsSummary summary = report.getLastParsedSummary();
assertTrue(summary.getSingleSummaries().size() > 0);
}
@@ -141,7 +142,6 @@ public class StatisticsReportingTest extends TestCase {
}
- @SuppressWarnings("unused")
public void testFilteredModeDetection() throws IOException {
UiUsageMonitorPlugin.getDefault().addMonitoredPreferences(ContextUiPlugin.getDefault().getPreferenceStore());
@@ -177,7 +177,8 @@ public class StatisticsReportingTest extends TestCase {
logger.stopMonitoring();
report.getStatisticsFromInteractionHistory(logger.getOutputFile(), new JobChangeAdapter() {
- public void done() {
+ @Override
+ public void done(IJobChangeEvent event) {
int normal = viewCollector.getNormalViewSelections().get(JavaUI.ID_PACKAGES);
assertEquals(5, normal);
diff --git a/org.eclipse.mylyn.web.tasks/src/org/eclipse/mylyn/internal/web/tasks/WebRepositorySettingsPage.java b/org.eclipse.mylyn.web.tasks/src/org/eclipse/mylyn/internal/web/tasks/WebRepositorySettingsPage.java
index 711ed38..094f578 100644
--- a/org.eclipse.mylyn.web.tasks/src/org/eclipse/mylyn/internal/web/tasks/WebRepositorySettingsPage.java
+++ b/org.eclipse.mylyn.web.tasks/src/org/eclipse/mylyn/internal/web/tasks/WebRepositorySettingsPage.java
@@ -307,7 +307,7 @@ public class WebRepositorySettingsPage extends AbstractRepositorySettingsPage im
public void propertyChange(PropertyChangeEvent event) {
Object source = event.getSource();
- if (source == taskUrlText || source == taskUrlText) {
+ if (source == taskUrlText) {
getWizard().getContainer().updateButtons();
}
}