summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTomasz Zarna2013-05-27 13:51:18 (EDT)
committerGerrit Code Review @ Eclipse.org2013-06-28 17:48:10 (EDT)
commitc12147918a2ecf16d03c22f643527bdbd6d77c07 (patch)
tree95416b263bbc080a69f6ee7785c06285f54d5e7e
parent84fa058b13eccfb52980f8a6d62ea98fffd750b9 (diff)
downloadorg.eclipse.mylyn.commons-c12147918a2ecf16d03c22f643527bdbd6d77c07.zip
org.eclipse.mylyn.commons-c12147918a2ecf16d03c22f643527bdbd6d77c07.tar.gz
org.eclipse.mylyn.commons-c12147918a2ecf16d03c22f643527bdbd6d77c07.tar.bz2
remove redundant StatusHandler#log call when reading ext pointsrefs/changes/37/13237/2
ExtensionPointReader#read already logs status if it's not ok, see #handleResult Change-Id: I8e2b436ede85f6fec35f87dc86580bd39c9dbb94
-rw-r--r--org.eclipse.mylyn.commons.repositories.core/src/org/eclipse/mylyn/internal/commons/repositories/core/LocationService.java8
-rw-r--r--org.eclipse.mylyn.commons.workbench/src/org/eclipse/mylyn/commons/workbench/browser/BrowserUtil.java6
2 files changed, 2 insertions, 12 deletions
diff --git a/org.eclipse.mylyn.commons.repositories.core/src/org/eclipse/mylyn/internal/commons/repositories/core/LocationService.java b/org.eclipse.mylyn.commons.repositories.core/src/org/eclipse/mylyn/internal/commons/repositories/core/LocationService.java
index ff544c5..ebb64a6 100644
--- a/org.eclipse.mylyn.commons.repositories.core/src/org/eclipse/mylyn/internal/commons/repositories/core/LocationService.java
+++ b/org.eclipse.mylyn.commons.repositories.core/src/org/eclipse/mylyn/internal/commons/repositories/core/LocationService.java
@@ -16,9 +16,7 @@ import java.net.Proxy;
import javax.net.ssl.X509TrustManager;
import org.eclipse.core.runtime.IProgressMonitor;
-import org.eclipse.core.runtime.IStatus;
import org.eclipse.mylyn.commons.core.ExtensionPointReader;
-import org.eclipse.mylyn.commons.core.StatusHandler;
import org.eclipse.mylyn.commons.core.net.NetUtil;
import org.eclipse.mylyn.commons.core.net.ProxyProvider;
import org.eclipse.mylyn.commons.repositories.core.ILocationService;
@@ -39,11 +37,7 @@ public class LocationService implements ILocationService {
static {
ExtensionPointReader<ILocationService> reader = new ExtensionPointReader<ILocationService>(
RepositoriesCoreInternal.ID_PLUGIN, "locationServices", "service", ILocationService.class); //$NON-NLS-1$ //$NON-NLS-2$
-
- IStatus status = reader.read();
- if (!status.isOK()) {
- StatusHandler.log(status);
- }
+ reader.read();
if (reader.getItem() != null) {
service = reader.getItem();
diff --git a/org.eclipse.mylyn.commons.workbench/src/org/eclipse/mylyn/commons/workbench/browser/BrowserUtil.java b/org.eclipse.mylyn.commons.workbench/src/org/eclipse/mylyn/commons/workbench/browser/BrowserUtil.java
index 76e1669..429faa2 100644
--- a/org.eclipse.mylyn.commons.workbench/src/org/eclipse/mylyn/commons/workbench/browser/BrowserUtil.java
+++ b/org.eclipse.mylyn.commons.workbench/src/org/eclipse/mylyn/commons/workbench/browser/BrowserUtil.java
@@ -26,7 +26,6 @@ import org.eclipse.jface.dialogs.MessageDialog;
import org.eclipse.jface.util.SafeRunnable;
import org.eclipse.mylyn.commons.core.CoreUtil;
import org.eclipse.mylyn.commons.core.ExtensionPointReader;
-import org.eclipse.mylyn.commons.core.StatusHandler;
import org.eclipse.mylyn.commons.workbench.EditorHandle;
import org.eclipse.mylyn.commons.workbench.WorkbenchUtil;
import org.eclipse.mylyn.internal.commons.workbench.CommonsWorkbenchPlugin;
@@ -84,10 +83,7 @@ public class BrowserUtil {
static {
ExtensionPointReader<AbstractUrlHandler> reader = new ExtensionPointReader<AbstractUrlHandler>(
CommonsWorkbenchPlugin.ID_PLUGIN, "urlHandlers", "handler", AbstractUrlHandler.class); //$NON-NLS-1$ //$NON-NLS-2$
- IStatus status = reader.read();
- if (!status.isOK()) {
- StatusHandler.log(status);
- }
+ reader.read();
handlers = reader.getItems();