RESOLVED - bug 367789: review parameters for HttpClient

https://bugs.eclipse.org/bugs/show_bug.cgi?id=367789

Change-Id: I7f80cecfc56d9152171e1c01f60d96600c1e70c3

1 files changed, 7 insertions, 2 deletions

diff --git a/org.eclipse.mylyn.commons.repositories.http.core/src/org/eclipse/mylyn/commons/repositories/http/core/HttpUtil.java b/org.eclipse.mylyn.commons.repositories.http.core/src/org/eclipse/mylyn/commons/repositories/http/core/HttpUtil.java
index 6aa9f8a..2c06006 100644
--- a/org.eclipse.mylyn.commons.repositories.http.core/src/org/eclipse/mylyn/commons/repositories/http/core/HttpUtil.java
+++ b/org.eclipse.mylyn.commons.repositories.http.core/src/org/eclipse/mylyn/commons/repositories/http/core/HttpUtil.java
@@ -74,8 +74,10 @@ public class HttpUtil {
 		CoreUtil.initializeLoggingSettings();
 	}
 
+	@SuppressWarnings("unused")
 	private static final int BUFFER_SIZE = 4096;
 
+	@SuppressWarnings("unused")
 	private static final long CLOSE_TIMEOUT = -1;
 
 	/**
@@ -93,6 +95,7 @@ public class HttpUtil {
 
 	private static final int SOCKET_TIMEOUT = 3 * 60 * 1000;
 
+	@SuppressWarnings("unused")
 	private static final int POLL_ATTEMPTS = SOCKET_TIMEOUT / POLL_INTERVAL;
 
 	private static SchemeSocketFactory socketFactory = new PollingProtocolSocketFactory();
@@ -112,6 +115,8 @@ public class HttpUtil {
 
 		HttpConnectionParams.setConnectionTimeout(client.getParams(), CONNNECT_TIMEOUT);
 		HttpConnectionParams.setSoTimeout(client.getParams(), SOCKET_TIMEOUT);
+
+		//AuthParams.setCredentialCharset(client.getParams(), "UTF-8");
 	}
 
 	public static void configureAuthentication(AbstractHttpClient client, RepositoryLocation location) {
@@ -127,7 +132,7 @@ public class HttpUtil {
 		Assert.isNotNull(location);
 		Assert.isNotNull(credentials);
 		String url = location.getUrl();
-		Assert.isNotNull("The location url must not be null", url);
+		Assert.isNotNull("The location url must not be null", url); //$NON-NLS-1$
 
 		String host = NetUtil.getHost(url);
 		int port = NetUtil.getPort(url);
@@ -217,7 +222,7 @@ public class HttpUtil {
 		Assert.isNotNull(client);
 		Assert.isNotNull(location);
 		String url = location.getUrl();
-		Assert.isNotNull("The location url must not be null", url);
+		Assert.isNotNull("The location url must not be null", url); //$NON-NLS-1$
 
 		String host = NetUtil.getHost(url);
 		Proxy proxy;