399302: reduce the number of warnings

Change-Id: Ifa9e04533af120592171a3c4b3970c29b24f632a
Task-Url: https://bugs.eclipse.org/bugs/show_bug.cgi?id=399302

11 files changed, 83 insertions, 169 deletions

diff --git a/org.eclipse.mylyn.commons.core/src/org/eclipse/mylyn/commons/core/HtmlUtil.java b/org.eclipse.mylyn.commons.core/src/org/eclipse/mylyn/commons/core/HtmlUtil.java
index c24e6f99..23a595cb 100644
--- a/org.eclipse.mylyn.commons.core/src/org/eclipse/mylyn/commons/core/HtmlUtil.java
+++ b/org.eclipse.mylyn.commons.core/src/org/eclipse/mylyn/commons/core/HtmlUtil.java
@@ -35,12 +35,16 @@ public class HtmlUtil {
 	 */
 	public static String toText(String htmlText) throws IOException {
 		Html2TextReader reader = new Html2TextReader(new StringReader(htmlText));
-		int c;
-		StringBuffer sb = new StringBuffer(htmlText.length());
-		while ((c = reader.read()) != -1) {
-			sb.append((char) c);
+		try {
+			int c;
+			StringBuffer sb = new StringBuffer(htmlText.length());
+			while ((c = reader.read()) != -1) {
+				sb.append((char) c);
+			}
+			return sb.toString();
+		} finally {
+			reader.close();
 		}
-		return sb.toString();
 	}
 
 	/**
diff --git a/org.eclipse.mylyn.commons.core/src/org/eclipse/mylyn/commons/core/XmlMemento.java b/org.eclipse.mylyn.commons.core/src/org/eclipse/mylyn/commons/core/XmlMemento.java
index 50986016..d5e427b5 100644
--- a/org.eclipse.mylyn.commons.core/src/org/eclipse/mylyn/commons/core/XmlMemento.java
+++ b/org.eclipse.mylyn.commons.core/src/org/eclipse/mylyn/commons/core/XmlMemento.java
@@ -276,6 +276,7 @@ public final class XmlMemento {
 	/* (non-Javadoc)
 	 * Method declared in XMLMemento.
 	 */
+	@SuppressWarnings({ "rawtypes", "unchecked" })
 	public XmlMemento[] getChildren(String type) {
 
 		// Get the nodes.
diff --git a/org.eclipse.mylyn.commons.net/src/org/eclipse/mylyn/internal/commons/net/CommonsNetPlugin.java b/org.eclipse.mylyn.commons.net/src/org/eclipse/mylyn/internal/commons/net/CommonsNetPlugin.java
index eb1db2ec..b22aec2d 100644
--- a/org.eclipse.mylyn.commons.net/src/org/eclipse/mylyn/internal/commons/net/CommonsNetPlugin.java
+++ b/org.eclipse.mylyn.commons.net/src/org/eclipse/mylyn/internal/commons/net/CommonsNetPlugin.java
@@ -20,7 +20,6 @@ import org.eclipse.core.runtime.Plugin;
 import org.eclipse.core.runtime.Status;
 import org.eclipse.mylyn.internal.commons.core.CommonsCorePlugin;
 import org.osgi.framework.BundleContext;
-import org.osgi.util.tracker.ServiceTracker;
 
 /**
  * Provides an entry point for the proxy service and potentially other web facilities
@@ -62,14 +61,10 @@ public class CommonsNetPlugin extends Plugin {
 		CommonsCorePlugin.setProxyService(proxyService);
 	}
 
-	@SuppressWarnings("rawtypes")
-	private ServiceTracker tracker;
-
 	public CommonsNetPlugin() {
 		INSTANCE = this;
 	}
 
-	@SuppressWarnings({ "unchecked", "rawtypes" })
 	@Override
 	public void start(BundleContext context) throws Exception {
 		super.start(context);
diff --git a/org.eclipse.mylyn.commons.repositories.http.core/src/org/eclipse/mylyn/commons/repositories/http/core/CommonHttpOperation.java b/org.eclipse.mylyn.commons.repositories.http.core/src/org/eclipse/mylyn/commons/repositories/http/core/CommonHttpOperation.java
index 2d7d6178..831e5d3b 100644
--- a/org.eclipse.mylyn.commons.repositories.http.core/src/org/eclipse/mylyn/commons/repositories/http/core/CommonHttpOperation.java
+++ b/org.eclipse.mylyn.commons.repositories.http.core/src/org/eclipse/mylyn/commons/repositories/http/core/CommonHttpOperation.java
@@ -86,7 +86,7 @@ public abstract class CommonHttpOperation<T> {
 		return executeOnce(request, monitor);
 	}
 
-	@SuppressWarnings("unchecked")
+	@SuppressWarnings({ "unchecked", "rawtypes" })
 	private void handleAuthenticationError(HttpRequestBase request, AuthenticationException e,
 			IOperationMonitor monitor, boolean requestCredentials) throws AuthenticationException {
 		invalidateAuthentication(e, monitor);
diff --git a/org.eclipse.mylyn.commons.repositories.ui/.settings/org.eclipse.pde.prefs b/org.eclipse.mylyn.commons.repositories.ui/.settings/org.eclipse.pde.prefs
index e8f2d562..4600c120 100644
--- a/org.eclipse.mylyn.commons.repositories.ui/.settings/org.eclipse.pde.prefs
+++ b/org.eclipse.mylyn.commons.repositories.ui/.settings/org.eclipse.pde.prefs
@@ -1,10 +1,24 @@
-#Tue Apr 15 11:07:59 PDT 2008
+compilers.f.unresolved-features=1
+compilers.f.unresolved-plugins=1
 compilers.incompatible-environment=1
 compilers.p.build=1
+compilers.p.build.bin.includes=1
+compilers.p.build.encodings=2
+compilers.p.build.java.compiler=2
+compilers.p.build.java.compliance=1
+compilers.p.build.missing.output=2
+compilers.p.build.output.library=1
+compilers.p.build.source.library=1
+compilers.p.build.src.includes=1
 compilers.p.deprecated=1
 compilers.p.discouraged-class=2
+compilers.p.internal=2
+compilers.p.matching-pom-version=2
 compilers.p.missing-bundle-classpath-entries=1
 compilers.p.missing-packages=1
+compilers.p.missing-version-export-package=2
+compilers.p.missing-version-import-package=2
+compilers.p.missing-version-require-bundle=2
 compilers.p.no-required-att=0
 compilers.p.not-externalized-att=2
 compilers.p.unknown-attribute=0
@@ -14,5 +28,8 @@ compilers.p.unknown-identifier=1
 compilers.p.unknown-resource=0
 compilers.p.unresolved-ex-points=0
 compilers.p.unresolved-import=0
+compilers.s.create-docs=false
+compilers.s.doc-folder=doc
+compilers.s.open-tags=1
 compilers.use-project=true
 eclipse.preferences.version=1
diff --git a/org.eclipse.mylyn.commons.tests/META-INF/MANIFEST.MF b/org.eclipse.mylyn.commons.tests/META-INF/MANIFEST.MF
index 15c91f84..af75226c 100644
--- a/org.eclipse.mylyn.commons.tests/META-INF/MANIFEST.MF
+++ b/org.eclipse.mylyn.commons.tests/META-INF/MANIFEST.MF
@@ -20,6 +20,7 @@ Require-Bundle: org.eclipse.core.runtime,
 Export-Package: org.eclipse.mylyn.commons.core;x-internal:=true,
  org.eclipse.mylyn.commons.tests;x-internal:=true,
  org.eclipse.mylyn.commons.tests.core;x-internal:=true,
+ org.eclipse.mylyn.commons.tests.core.storage,
  org.eclipse.mylyn.commons.tests.manual;x-internal:=true,
  org.eclipse.mylyn.commons.tests.net;x-internal:=true,
  org.eclipse.mylyn.commons.tests.operations;x-internal:=true,
diff --git a/org.eclipse.mylyn.commons.ui/.settings/.api_filters b/org.eclipse.mylyn.commons.ui/.settings/.api_filters
deleted file mode 100644
index 70af3501..00000000
--- a/org.eclipse.mylyn.commons.ui/.settings/.api_filters
+++ /dev/null
@@ -1,139 +0,0 @@
-<?xml version="1.0" encoding="UTF-8" standalone="no"?>
-<component id="org.eclipse.mylyn.commons.ui" version="2">
-    <resource path="src/org/eclipse/mylyn/commons/ui/AbstractColumnViewerSorter.java" type="org.eclipse.mylyn.commons.ui.AbstractColumnViewerSorter">
-        <filter id="305365105">
-            <message_arguments>
-                <message_argument value="org.eclipse.mylyn.commons.ui.AbstractColumnViewerSorter"/>
-                <message_argument value="org.eclipse.mylyn.commons.ui_3.9.0"/>
-            </message_arguments>
-        </filter>
-    </resource>
-    <resource path="src/org/eclipse/mylyn/commons/ui/AbstractColumnViewerSupport.java" type="org.eclipse.mylyn.commons.ui.AbstractColumnViewerSupport">
-        <filter id="305365105">
-            <message_arguments>
-                <message_argument value="org.eclipse.mylyn.commons.ui.AbstractColumnViewerSupport"/>
-                <message_argument value="org.eclipse.mylyn.commons.ui_3.9.0"/>
-            </message_arguments>
-        </filter>
-    </resource>
-    <resource path="src/org/eclipse/mylyn/commons/ui/ClipboardCopier.java" type="org.eclipse.mylyn.commons.ui.ClipboardCopier">
-        <filter id="305365105">
-            <message_arguments>
-                <message_argument value="org.eclipse.mylyn.commons.ui.ClipboardCopier"/>
-                <message_argument value="org.eclipse.mylyn.commons.ui_3.9.0"/>
-            </message_arguments>
-        </filter>
-    </resource>
-    <resource path="src/org/eclipse/mylyn/commons/ui/CommonImages.java" type="org.eclipse.mylyn.commons.ui.CommonImages">
-        <filter id="305365105">
-            <message_arguments>
-                <message_argument value="org.eclipse.mylyn.commons.ui.CommonImages"/>
-                <message_argument value="org.eclipse.mylyn.commons.ui_3.9.0"/>
-            </message_arguments>
-        </filter>
-    </resource>
-    <resource path="src/org/eclipse/mylyn/commons/ui/CommonUiUtil.java" type="org.eclipse.mylyn.commons.ui.CommonUiUtil">
-        <filter id="305365105">
-            <message_arguments>
-                <message_argument value="org.eclipse.mylyn.commons.ui.CommonUiUtil"/>
-                <message_argument value="org.eclipse.mylyn.commons.ui_3.9.0"/>
-            </message_arguments>
-        </filter>
-    </resource>
-    <resource path="src/org/eclipse/mylyn/commons/ui/ControlListItem.java" type="org.eclipse.mylyn.commons.ui.ControlListItem">
-        <filter id="305365105">
-            <message_arguments>
-                <message_argument value="org.eclipse.mylyn.commons.ui.ControlListItem"/>
-                <message_argument value="org.eclipse.mylyn.commons.ui_3.9.0"/>
-            </message_arguments>
-        </filter>
-    </resource>
-    <resource path="src/org/eclipse/mylyn/commons/ui/ControlListViewer.java" type="org.eclipse.mylyn.commons.ui.ControlListViewer">
-        <filter id="305365105">
-            <message_arguments>
-                <message_argument value="org.eclipse.mylyn.commons.ui.ControlListViewer"/>
-                <message_argument value="org.eclipse.mylyn.commons.ui_3.9.0"/>
-            </message_arguments>
-        </filter>
-    </resource>
-    <resource path="src/org/eclipse/mylyn/commons/ui/GradientCanvas.java" type="org.eclipse.mylyn.commons.ui.GradientCanvas">
-        <filter id="305365105">
-            <message_arguments>
-                <message_argument value="org.eclipse.mylyn.commons.ui.GradientCanvas"/>
-                <message_argument value="org.eclipse.mylyn.commons.ui_3.9.0"/>
-            </message_arguments>
-        </filter>
-    </resource>
-    <resource path="src/org/eclipse/mylyn/commons/ui/GradientColors.java" type="org.eclipse.mylyn.commons.ui.GradientColors">
-        <filter id="305365105">
-            <message_arguments>
-                <message_argument value="org.eclipse.mylyn.commons.ui.GradientColors"/>
-                <message_argument value="org.eclipse.mylyn.commons.ui_3.9.0"/>
-            </message_arguments>
-        </filter>
-    </resource>
-    <resource path="src/org/eclipse/mylyn/commons/ui/GradientToolTip.java" type="org.eclipse.mylyn.commons.ui.GradientToolTip">
-        <filter id="305365105">
-            <message_arguments>
-                <message_argument value="org.eclipse.mylyn.commons.ui.GradientToolTip"/>
-                <message_argument value="org.eclipse.mylyn.commons.ui_3.9.0"/>
-            </message_arguments>
-        </filter>
-    </resource>
-    <resource path="src/org/eclipse/mylyn/commons/ui/PlatformUiUtil.java" type="org.eclipse.mylyn.commons.ui.PlatformUiUtil">
-        <filter id="305365105">
-            <message_arguments>
-                <message_argument value="org.eclipse.mylyn.commons.ui.PlatformUiUtil"/>
-                <message_argument value="org.eclipse.mylyn.commons.ui_3.9.0"/>
-            </message_arguments>
-        </filter>
-    </resource>
-    <resource path="src/org/eclipse/mylyn/commons/ui/ProgressContainer.java" type="org.eclipse.mylyn.commons.ui.ProgressContainer">
-        <filter id="305365105">
-            <message_arguments>
-                <message_argument value="org.eclipse.mylyn.commons.ui.ProgressContainer"/>
-                <message_argument value="org.eclipse.mylyn.commons.ui_3.9.0"/>
-            </message_arguments>
-        </filter>
-    </resource>
-    <resource path="src/org/eclipse/mylyn/commons/ui/SelectionProviderAdapter.java" type="org.eclipse.mylyn.commons.ui.SelectionProviderAdapter">
-        <filter id="305365105">
-            <message_arguments>
-                <message_argument value="org.eclipse.mylyn.commons.ui.SelectionProviderAdapter"/>
-                <message_argument value="org.eclipse.mylyn.commons.ui_3.9.0"/>
-            </message_arguments>
-        </filter>
-    </resource>
-    <resource path="src/org/eclipse/mylyn/commons/ui/TableSorter.java" type="org.eclipse.mylyn.commons.ui.TableSorter">
-        <filter id="305365105">
-            <message_arguments>
-                <message_argument value="org.eclipse.mylyn.commons.ui.TableSorter"/>
-                <message_argument value="org.eclipse.mylyn.commons.ui_3.9.0"/>
-            </message_arguments>
-        </filter>
-    </resource>
-    <resource path="src/org/eclipse/mylyn/commons/ui/TableViewerSupport.java" type="org.eclipse.mylyn.commons.ui.TableViewerSupport">
-        <filter id="305365105">
-            <message_arguments>
-                <message_argument value="org.eclipse.mylyn.commons.ui.TableViewerSupport"/>
-                <message_argument value="org.eclipse.mylyn.commons.ui_3.9.0"/>
-            </message_arguments>
-        </filter>
-    </resource>
-    <resource path="src/org/eclipse/mylyn/commons/ui/TreeSorter.java" type="org.eclipse.mylyn.commons.ui.TreeSorter">
-        <filter id="305365105">
-            <message_arguments>
-                <message_argument value="org.eclipse.mylyn.commons.ui.TreeSorter"/>
-                <message_argument value="org.eclipse.mylyn.commons.ui_3.9.0"/>
-            </message_arguments>
-        </filter>
-    </resource>
-    <resource path="src/org/eclipse/mylyn/commons/ui/TreeViewerSupport.java" type="org.eclipse.mylyn.commons.ui.TreeViewerSupport">
-        <filter id="305365105">
-            <message_arguments>
-                <message_argument value="org.eclipse.mylyn.commons.ui.TreeViewerSupport"/>
-                <message_argument value="org.eclipse.mylyn.commons.ui_3.9.0"/>
-            </message_arguments>
-        </filter>
-    </resource>
-</component>
diff --git a/org.eclipse.mylyn.commons.workbench/.settings/.api_filters b/org.eclipse.mylyn.commons.workbench/.settings/.api_filters
index 073a28c2..088c2e59 100644
--- a/org.eclipse.mylyn.commons.workbench/.settings/.api_filters
+++ b/org.eclipse.mylyn.commons.workbench/.settings/.api_filters
@@ -9,17 +9,4 @@
             </message_arguments>
         </filter>
     </resource>
-    <resource path="src/org/eclipse/mylyn/commons/workbench/forms/RichToolTip.java" type="org.eclipse.mylyn.commons.workbench.forms.RichToolTip">
-        <filter id="338849923">
-            <message_arguments>
-                <message_argument value="org.eclipse.mylyn.commons.workbench.forms.RichToolTip"/>
-            </message_arguments>
-        </filter>
-        <filter id="576720909">
-            <message_arguments>
-                <message_argument value="GradientToolTip"/>
-                <message_argument value="RichToolTip"/>
-            </message_arguments>
-        </filter>
-    </resource>
 </component>
diff --git a/stubs/org.eclipse.mylyn.commons.team/.settings/org.eclipse.jdt.core.prefs b/stubs/org.eclipse.mylyn.commons.team/.settings/org.eclipse.jdt.core.prefs
index 26168197..6c44e969 100644
--- a/stubs/org.eclipse.mylyn.commons.team/.settings/org.eclipse.jdt.core.prefs
+++ b/stubs/org.eclipse.mylyn.commons.team/.settings/org.eclipse.jdt.core.prefs
@@ -1,4 +1,3 @@
-#Wed Mar 02 16:00:58 PST 2011
 eclipse.preferences.version=1
 org.eclipse.jdt.core.codeComplete.argumentPrefixes=
 org.eclipse.jdt.core.codeComplete.argumentSuffixes=
@@ -8,6 +7,14 @@ org.eclipse.jdt.core.codeComplete.localPrefixes=
 org.eclipse.jdt.core.codeComplete.localSuffixes=
 org.eclipse.jdt.core.codeComplete.staticFieldPrefixes=
 org.eclipse.jdt.core.codeComplete.staticFieldSuffixes=
+org.eclipse.jdt.core.codeComplete.staticFinalFieldPrefixes=
+org.eclipse.jdt.core.codeComplete.staticFinalFieldSuffixes=
+org.eclipse.jdt.core.compiler.annotation.inheritNullAnnotations=disabled
+org.eclipse.jdt.core.compiler.annotation.missingNonNullByDefaultAnnotation=ignore
+org.eclipse.jdt.core.compiler.annotation.nonnull=org.eclipse.jdt.annotation.NonNull
+org.eclipse.jdt.core.compiler.annotation.nonnullbydefault=org.eclipse.jdt.annotation.NonNullByDefault
+org.eclipse.jdt.core.compiler.annotation.nullable=org.eclipse.jdt.annotation.Nullable
+org.eclipse.jdt.core.compiler.annotation.nullanalysis=disabled
 org.eclipse.jdt.core.compiler.codegen.inlineJsrBytecode=enabled
 org.eclipse.jdt.core.compiler.codegen.targetPlatform=1.5
 org.eclipse.jdt.core.compiler.codegen.unusedLocal=preserve
@@ -18,12 +25,15 @@ org.eclipse.jdt.core.compiler.debug.sourceFile=generate
 org.eclipse.jdt.core.compiler.problem.annotationSuperInterface=warning
 org.eclipse.jdt.core.compiler.problem.assertIdentifier=error
 org.eclipse.jdt.core.compiler.problem.autoboxing=ignore
+org.eclipse.jdt.core.compiler.problem.comparingIdentical=warning
+org.eclipse.jdt.core.compiler.problem.deadCode=warning
 org.eclipse.jdt.core.compiler.problem.deprecation=warning
 org.eclipse.jdt.core.compiler.problem.deprecationInDeprecatedCode=disabled
 org.eclipse.jdt.core.compiler.problem.deprecationWhenOverridingDeprecatedMethod=enabled
 org.eclipse.jdt.core.compiler.problem.discouragedReference=warning
 org.eclipse.jdt.core.compiler.problem.emptyStatement=ignore
 org.eclipse.jdt.core.compiler.problem.enumIdentifier=error
+org.eclipse.jdt.core.compiler.problem.explicitlyClosedAutoCloseable=ignore
 org.eclipse.jdt.core.compiler.problem.fallthroughCase=ignore
 org.eclipse.jdt.core.compiler.problem.fatalOptionalError=enabled
 org.eclipse.jdt.core.compiler.problem.fieldHiding=ignore
@@ -31,31 +41,50 @@ org.eclipse.jdt.core.compiler.problem.finalParameterBound=warning
 org.eclipse.jdt.core.compiler.problem.finallyBlockNotCompletingNormally=warning
 org.eclipse.jdt.core.compiler.problem.forbiddenReference=error
 org.eclipse.jdt.core.compiler.problem.hiddenCatchBlock=warning
+org.eclipse.jdt.core.compiler.problem.includeNullInfoFromAsserts=disabled
 org.eclipse.jdt.core.compiler.problem.incompatibleNonInheritedInterfaceMethod=warning
 org.eclipse.jdt.core.compiler.problem.incompleteEnumSwitch=ignore
 org.eclipse.jdt.core.compiler.problem.indirectStaticAccess=ignore
 org.eclipse.jdt.core.compiler.problem.localVariableHiding=ignore
 org.eclipse.jdt.core.compiler.problem.methodWithConstructorName=warning
+org.eclipse.jdt.core.compiler.problem.missingDefaultCase=ignore
 org.eclipse.jdt.core.compiler.problem.missingDeprecatedAnnotation=ignore
+org.eclipse.jdt.core.compiler.problem.missingEnumCaseDespiteDefault=disabled
+org.eclipse.jdt.core.compiler.problem.missingHashCodeMethod=ignore
 org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotation=ignore
+org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotationForInterfaceMethodImplementation=enabled
 org.eclipse.jdt.core.compiler.problem.missingSerialVersion=warning
+org.eclipse.jdt.core.compiler.problem.missingSynchronizedOnInheritedMethod=ignore
 org.eclipse.jdt.core.compiler.problem.noEffectAssignment=warning
 org.eclipse.jdt.core.compiler.problem.noImplicitStringConversion=warning
 org.eclipse.jdt.core.compiler.problem.nonExternalizedStringLiteral=warning
+org.eclipse.jdt.core.compiler.problem.nonnullParameterAnnotationDropped=warning
+org.eclipse.jdt.core.compiler.problem.nullAnnotationInferenceConflict=error
 org.eclipse.jdt.core.compiler.problem.nullReference=error
+org.eclipse.jdt.core.compiler.problem.nullSpecViolation=error
+org.eclipse.jdt.core.compiler.problem.nullUncheckedConversion=warning
 org.eclipse.jdt.core.compiler.problem.overridingPackageDefaultMethod=warning
 org.eclipse.jdt.core.compiler.problem.parameterAssignment=ignore
 org.eclipse.jdt.core.compiler.problem.possibleAccidentalBooleanAssignment=ignore
 org.eclipse.jdt.core.compiler.problem.potentialNullReference=warning
-org.eclipse.jdt.core.compiler.problem.rawTypeReference=warning
+org.eclipse.jdt.core.compiler.problem.potentiallyUnclosedCloseable=ignore
+org.eclipse.jdt.core.compiler.problem.rawTypeReference=ignore
+org.eclipse.jdt.core.compiler.problem.redundantNullAnnotation=warning
 org.eclipse.jdt.core.compiler.problem.redundantNullCheck=ignore
+org.eclipse.jdt.core.compiler.problem.redundantSpecificationOfTypeArguments=ignore
 org.eclipse.jdt.core.compiler.problem.redundantSuperinterface=ignore
+org.eclipse.jdt.core.compiler.problem.reportMethodCanBePotentiallyStatic=ignore
+org.eclipse.jdt.core.compiler.problem.reportMethodCanBeStatic=ignore
 org.eclipse.jdt.core.compiler.problem.specialParameterHidingField=disabled
 org.eclipse.jdt.core.compiler.problem.staticAccessReceiver=warning
+org.eclipse.jdt.core.compiler.problem.suppressOptionalErrors=disabled
 org.eclipse.jdt.core.compiler.problem.suppressWarnings=enabled
+org.eclipse.jdt.core.compiler.problem.syntacticNullAnalysisForFields=disabled
 org.eclipse.jdt.core.compiler.problem.syntheticAccessEmulation=ignore
 org.eclipse.jdt.core.compiler.problem.typeParameterHiding=warning
-org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=warning
+org.eclipse.jdt.core.compiler.problem.unavoidableGenericTypeProblems=enabled
+org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=ignore
+org.eclipse.jdt.core.compiler.problem.unclosedCloseable=warning
 org.eclipse.jdt.core.compiler.problem.undocumentedEmptyBlock=ignore
 org.eclipse.jdt.core.compiler.problem.unhandledWarningToken=warning
 org.eclipse.jdt.core.compiler.problem.unnecessaryElse=ignore
@@ -68,11 +97,13 @@ org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownExceptionWhenOverridin
 org.eclipse.jdt.core.compiler.problem.unusedImport=warning
 org.eclipse.jdt.core.compiler.problem.unusedLabel=warning
 org.eclipse.jdt.core.compiler.problem.unusedLocal=warning
+org.eclipse.jdt.core.compiler.problem.unusedObjectAllocation=ignore
 org.eclipse.jdt.core.compiler.problem.unusedParameter=ignore
 org.eclipse.jdt.core.compiler.problem.unusedParameterIncludeDocCommentReference=enabled
 org.eclipse.jdt.core.compiler.problem.unusedParameterWhenImplementingAbstract=disabled
 org.eclipse.jdt.core.compiler.problem.unusedParameterWhenOverridingConcrete=disabled
 org.eclipse.jdt.core.compiler.problem.unusedPrivateMember=warning
+org.eclipse.jdt.core.compiler.problem.unusedTypeParameter=ignore
 org.eclipse.jdt.core.compiler.problem.unusedWarningToken=warning
 org.eclipse.jdt.core.compiler.problem.varargsArgumentNeedCast=warning
 org.eclipse.jdt.core.compiler.source=1.5
diff --git a/stubs/org.eclipse.mylyn.commons.team/.settings/org.eclipse.pde.prefs b/stubs/org.eclipse.mylyn.commons.team/.settings/org.eclipse.pde.prefs
index e8f2d562..962066e2 100644
--- a/stubs/org.eclipse.mylyn.commons.team/.settings/org.eclipse.pde.prefs
+++ b/stubs/org.eclipse.mylyn.commons.team/.settings/org.eclipse.pde.prefs
@@ -1,10 +1,24 @@
-#Tue Apr 15 11:07:59 PDT 2008
+compilers.f.unresolved-features=1
+compilers.f.unresolved-plugins=1
 compilers.incompatible-environment=1
 compilers.p.build=1
+compilers.p.build.bin.includes=1
+compilers.p.build.encodings=2
+compilers.p.build.java.compiler=2
+compilers.p.build.java.compliance=1
+compilers.p.build.missing.output=2
+compilers.p.build.output.library=1
+compilers.p.build.source.library=1
+compilers.p.build.src.includes=1
 compilers.p.deprecated=1
 compilers.p.discouraged-class=2
+compilers.p.internal=1
+compilers.p.matching-pom-version=2
 compilers.p.missing-bundle-classpath-entries=1
 compilers.p.missing-packages=1
+compilers.p.missing-version-export-package=2
+compilers.p.missing-version-import-package=2
+compilers.p.missing-version-require-bundle=2
 compilers.p.no-required-att=0
 compilers.p.not-externalized-att=2
 compilers.p.unknown-attribute=0
@@ -14,5 +28,8 @@ compilers.p.unknown-identifier=1
 compilers.p.unknown-resource=0
 compilers.p.unresolved-ex-points=0
 compilers.p.unresolved-import=0
+compilers.s.create-docs=false
+compilers.s.doc-folder=doc
+compilers.s.open-tags=1
 compilers.use-project=true
 eclipse.preferences.version=1
diff --git a/stubs/org.eclipse.mylyn.commons.team/src/org/eclipse/mylyn/internal/commons/ui/team/RepositoriesView.java b/stubs/org.eclipse.mylyn.commons.team/src/org/eclipse/mylyn/internal/commons/ui/team/RepositoriesView.java
index 043294f5..c53c9d7b 100644
--- a/stubs/org.eclipse.mylyn.commons.team/src/org/eclipse/mylyn/internal/commons/ui/team/RepositoriesView.java
+++ b/stubs/org.eclipse.mylyn.commons.team/src/org/eclipse/mylyn/internal/commons/ui/team/RepositoriesView.java
@@ -45,6 +45,7 @@ public class RepositoriesView extends CommonNavigator {
 	@Override
 	protected CommonViewer createCommonViewer(Composite aParent) {
 		CommonViewer viewer = super.createCommonViewer(aParent);
+		@SuppressWarnings("unused")
 		IThemeManager themeManager = getSite().getWorkbenchWindow().getWorkbench().getThemeManager();
 		return viewer;
 	}
@@ -52,7 +53,6 @@ public class RepositoriesView extends CommonNavigator {
 	@Override
 	public Object getAdapter(@SuppressWarnings("rawtypes")
 	Class adapter) {
-		// FIXME read targets from extension point?
 		if (adapter == IShowInTargetList.class) {
 			return new IShowInTargetList() {
 				public String[] getShowInTargetIds() {