summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorjkohnlein2008-03-07 03:47:20 (EST)
committerjkohnlein2008-03-07 03:47:20 (EST)
commit07b635bc183f4b6c6603ef7c4eed2778524f69fd (patch)
treea8469d30051b23014d8d3cd134a571228d1e356c
parent7ff3700543831ed7689b736415af35a354bd3ee0 (diff)
downloadorg.eclipse.xpand-07b635bc183f4b6c6603ef7c4eed2778524f69fd.zip
org.eclipse.xpand-07b635bc183f4b6c6603ef7c4eed2778524f69fd.tar.gz
org.eclipse.xpand-07b635bc183f4b6c6603ef7c4eed2778524f69fd.tar.bz2
Added todo file
-rw-r--r--plugins/org.eclipse.xpand3.parser/model/Xpand3Node.ecore11
-rw-r--r--plugins/org.eclipse.xpand3.parser/model/Xpand3Node.tmf15
-rw-r--r--plugins/org.eclipse.xpand3.parser/model/criticism.txt13
3 files changed, 23 insertions, 16 deletions
diff --git a/plugins/org.eclipse.xpand3.parser/model/Xpand3Node.ecore b/plugins/org.eclipse.xpand3.parser/model/Xpand3Node.ecore
index f68b732..8c3656f 100644
--- a/plugins/org.eclipse.xpand3.parser/model/Xpand3Node.ecore
+++ b/plugins/org.eclipse.xpand3.parser/model/Xpand3Node.ecore
@@ -140,18 +140,15 @@
</eClassifiers>
<eClassifiers xsi:type="ecore:EClass" name="RelationalExpressionNode">
<eSuperTypes href="platform:/resource/org.eclipse.tmf.common/src/org/eclipse/tmf/common/node/node.ecore#//CompositeNode"/>
- <eStructuralFeatures xsi:type="ecore:EReference" name="leftOperand">
- <eType xsi:type="ecore:EClass" href="platform:/resource/org.eclipse.tmf.common/src/org/eclipse/tmf/common/node/node.ecore#//CompositeNode"/>
- </eStructuralFeatures>
<eStructuralFeatures xsi:type="ecore:EReference" name="operator">
- <eType xsi:type="ecore:EClass" href="platform:/resource/org.eclipse.tmf.common/src/org/eclipse/tmf/common/node/node.ecore#//CompositeNode"/>
+ <eType xsi:type="ecore:EClass" href="platform:/resource/org.eclipse.tmf.common/src/org/eclipse/tmf/common/node/node.ecore#//LeafNode"/>
</eStructuralFeatures>
<eStructuralFeatures xsi:type="ecore:EReference" name="rightOperand">
<eType xsi:type="ecore:EClass" href="platform:/resource/org.eclipse.tmf.common/src/org/eclipse/tmf/common/node/node.ecore#//CompositeNode"/>
</eStructuralFeatures>
- </eClassifiers>
- <eClassifiers xsi:type="ecore:EClass" name="BooleanOperatorNode">
- <eSuperTypes href="platform:/resource/org.eclipse.tmf.common/src/org/eclipse/tmf/common/node/node.ecore#//CompositeNode"/>
+ <eStructuralFeatures xsi:type="ecore:EReference" name="leftOperand">
+ <eType xsi:type="ecore:EClass" href="platform:/resource/org.eclipse.tmf.common/src/org/eclipse/tmf/common/node/node.ecore#//CompositeNode"/>
+ </eStructuralFeatures>
</eClassifiers>
<eClassifiers xsi:type="ecore:EClass" name="AdditiveExpressionNode">
<eSuperTypes href="platform:/resource/org.eclipse.tmf.common/src/org/eclipse/tmf/common/node/node.ecore#//CompositeNode"/>
diff --git a/plugins/org.eclipse.xpand3.parser/model/Xpand3Node.tmf b/plugins/org.eclipse.xpand3.parser/model/Xpand3Node.tmf
index 4893ff4..23d8424 100644
--- a/plugins/org.eclipse.xpand3.parser/model/Xpand3Node.tmf
+++ b/plugins/org.eclipse.xpand3.parser/model/Xpand3Node.tmf
@@ -211,16 +211,13 @@ normalizable impliesExpression :
normalizable relationalExpression :
leftOperand=additiveExpression
- (operator=booleanOperator rightOperand=additiveExpression )*
+ ((operator='=='
+ | operator='!='
+ | operator='>='
+ | operator='<='
+ | operator='>'
+ | operator='<') rightOperand=additiveExpression )*
;
-
-booleanOperator :
- '=='
- | '!='
- | '>='
- | '<='
- | '>'
- | '<';
normalizable additiveExpression :
multiplicativeExpression
diff --git a/plugins/org.eclipse.xpand3.parser/model/criticism.txt b/plugins/org.eclipse.xpand3.parser/model/criticism.txt
new file mode 100644
index 0000000..a9253ef
--- /dev/null
+++ b/plugins/org.eclipse.xpand3.parser/model/criticism.txt
@@ -0,0 +1,13 @@
+TMF common critics:
+
+- default label
+- no labels for keywords (template l:105)
+- label for parenthesized expr
+ rule: visibility=('public' | 'private' );
+ Check: parenthesized element with feature must only contain groups with keywords
+
+TODO
+
+DONE
+- generate prefix for rulenames
+ \ No newline at end of file