From 5cfff20bc109ee73ba4dc399662eab5df5797943 Mon Sep 17 00:00:00 2001 From: Igor Fedorenko Date: Tue, 5 Apr 2011 15:57:49 -0400 Subject: Introduced IPluginExecutionMetadata interface Replaced references to generated PluginExecutionMetadata class with IPluginExecutionMetadata interface in all public non-internal classes. Marked IPluginExecutionMetadata as @noimplement/@noextend to make it clear that m2e does not expect external implementations. IPluginExecutionMetadata is almost empty at this point, but we'll be able to introduce new methods as we need then without breaking existing clients. Signed-off-by: Igor Fedorenko --- .../eclipse/m2e/internal/discovery/MavenDiscoveryService.java | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) (limited to 'org.eclipse.m2e.discovery') diff --git a/org.eclipse.m2e.discovery/src/org/eclipse/m2e/internal/discovery/MavenDiscoveryService.java b/org.eclipse.m2e.discovery/src/org/eclipse/m2e/internal/discovery/MavenDiscoveryService.java index 47055288..70259539 100644 --- a/org.eclipse.m2e.discovery/src/org/eclipse/m2e/internal/discovery/MavenDiscoveryService.java +++ b/org.eclipse.m2e.discovery/src/org/eclipse/m2e/internal/discovery/MavenDiscoveryService.java @@ -53,8 +53,9 @@ import org.eclipse.m2e.core.internal.lifecyclemapping.discovery.MojoExecutionMap import org.eclipse.m2e.core.internal.lifecyclemapping.discovery.PackagingTypeMappingConfiguration; import org.eclipse.m2e.core.internal.lifecyclemapping.model.LifecycleMappingMetadata; import org.eclipse.m2e.core.internal.lifecyclemapping.model.LifecycleMappingMetadataSource; -import org.eclipse.m2e.core.internal.lifecyclemapping.model.PluginExecutionAction; import org.eclipse.m2e.core.internal.lifecyclemapping.model.PluginExecutionMetadata; +import org.eclipse.m2e.core.lifecyclemapping.model.IPluginExecutionMetadata; +import org.eclipse.m2e.core.lifecyclemapping.model.PluginExecutionAction; import org.eclipse.m2e.core.project.configurator.MojoExecutionKey; import org.eclipse.m2e.core.ui.internal.wizards.IImportWizardPageFactory; import org.eclipse.m2e.internal.discovery.operation.MavenDiscoveryInstallOperation; @@ -200,11 +201,11 @@ public class MavenDiscoveryService implements IImportWizardPageFactory, IMavenDi } } - for(Map.Entry> entry : mappingResult.getMojoExecutionMapping() + for(Map.Entry> entry : mappingResult.getMojoExecutionMapping() .entrySet()) { if(entry.getValue() != null) { - for(PluginExecutionMetadata executionMapping : entry.getValue()) { - IMavenDiscoveryProposal proposal = getProposal(executionMapping.getSource()); + for(IPluginExecutionMetadata executionMapping : entry.getValue()) { + IMavenDiscoveryProposal proposal = getProposal(((PluginExecutionMetadata)executionMapping).getSource()); if(proposal != null) { // assumes installation of mapping proposal installs all required project configurators put(proposals, new MojoExecutionMappingConfiguration.MojoExecutionMappingRequirement(entry.getKey()), -- cgit v1.2.3