Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMickael Istria2018-11-15 09:18:44 -0500
committerFred Bricon2018-11-21 18:39:36 -0500
commit25b27d33879c2f15692cfe89e76d5e06d97dd19c (patch)
tree5ce5927d6c50c549bd6bf94ea855eb67205da22f
parent3286bf1719a34397c694ad67e9353913cb888865 (diff)
downloadm2e-core-25b27d33879c2f15692cfe89e76d5e06d97dd19c.tar.gz
m2e-core-25b27d33879c2f15692cfe89e76d5e06d97dd19c.tar.xz
m2e-core-25b27d33879c2f15692cfe89e76d5e06d97dd19c.zip
Bug 515668 - [Preliminary] Remove useless parameter
The DependencyResolutionContext contains a lot of important state. If it's not used by the methods, let's just remove it to clarify that those methods do not depend on nor change the state of the DependencyResolutionContext. Change-Id: I8e4cd4a5a59adc3c00c310e8899b63df41732cde Signed-off-by: Mickael Istria <mistria@redhat.com>
-rw-r--r--org.eclipse.m2e.core/src/org/eclipse/m2e/core/internal/project/registry/ProjectRegistryManager.java8
1 files changed, 4 insertions, 4 deletions
diff --git a/org.eclipse.m2e.core/src/org/eclipse/m2e/core/internal/project/registry/ProjectRegistryManager.java b/org.eclipse.m2e.core/src/org/eclipse/m2e/core/internal/project/registry/ProjectRegistryManager.java
index 3c979609..05e5444d 100644
--- a/org.eclipse.m2e.core/src/org/eclipse/m2e/core/internal/project/registry/ProjectRegistryManager.java
+++ b/org.eclipse.m2e.core/src/org/eclipse/m2e/core/internal/project/registry/ProjectRegistryManager.java
@@ -393,7 +393,7 @@ public class ProjectRegistryManager {
context.forcePomFiles(newState.getVersionedDependents(mavenArtifactImportCapability, true));
}
- newFacade = readMavenProjectFacade(pom, context, newState, monitor);
+ newFacade = readMavenProjectFacade(pom, newState, monitor);
} else {
// refresh children of deleted/closed parent
if(oldFacade != null) {
@@ -470,7 +470,7 @@ public class ProjectRegistryManager {
MavenProject mavenProject = getMavenProject(newFacade);
if(mavenProject == null) {
// facade from workspace state that has not been refreshed yet
- newFacade = readMavenProjectFacade(pom, context, newState, monitor);
+ newFacade = readMavenProjectFacade(pom, newState, monitor);
} else {
// recreate facade instance to trigger project changed event
// this is only necessary for facades that are refreshed because their dependencies changed
@@ -684,8 +684,8 @@ public class ProjectRegistryManager {
return new DefaultMavenDependencyResolver(this, markerManager);
}
- private MavenProjectFacade readMavenProjectFacade(final IFile pom, DependencyResolutionContext context,
- final MutableProjectRegistry state, final IProgressMonitor monitor) throws CoreException {
+ private MavenProjectFacade readMavenProjectFacade(final IFile pom, final MutableProjectRegistry state,
+ final IProgressMonitor monitor) throws CoreException {
markerManager.deleteMarkers(pom, IMavenConstants.MARKER_POM_LOADING_ID);
final ResolverConfiguration resolverConfiguration = ResolverConfigurationIO

Back to the top