Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFred Bricon2013-09-02 03:36:45 -0400
committerFred Bricon2013-09-02 03:42:32 -0400
commitb3871a00a6a1f1f11cf58db9a2b212fcdb5f3a89 (patch)
treec4bb21afbf4ff97fc2d6361493201fffef931130
parentd110837ec9414a49ea4cddc46ddfa5037784676a (diff)
downloadm2e-core-b3871a00a6a1f1f11cf58db9a2b212fcdb5f3a89.tar.gz
m2e-core-b3871a00a6a1f1f11cf58db9a2b212fcdb5f3a89.tar.xz
m2e-core-b3871a00a6a1f1f11cf58db9a2b212fcdb5f3a89.zip
Fix memory leak in MavenImportWizard.java
mappingConfiguration is not dereferenced after displaying the projects of a directory. This leads to an important memory leak once the wizard is closed (even if the projects haven't been imported, e.g. 350MB for 130 projects) Fixing this leak until https://bugs.eclipse.org/bugs/show_bug.cgi?id=409732 is properly fixed. Signed-off-by: Fred Bricon <fbricon@gmail.com>
-rw-r--r--org.eclipse.m2e.core.ui/src/org/eclipse/m2e/core/ui/internal/wizards/MavenImportWizard.java6
1 files changed, 6 insertions, 0 deletions
diff --git a/org.eclipse.m2e.core.ui/src/org/eclipse/m2e/core/ui/internal/wizards/MavenImportWizard.java b/org.eclipse.m2e.core.ui/src/org/eclipse/m2e/core/ui/internal/wizards/MavenImportWizard.java
index 1f6942c3..76641dfe 100644
--- a/org.eclipse.m2e.core.ui/src/org/eclipse/m2e/core/ui/internal/wizards/MavenImportWizard.java
+++ b/org.eclipse.m2e.core.ui/src/org/eclipse/m2e/core/ui/internal/wizards/MavenImportWizard.java
@@ -372,4 +372,10 @@ public class MavenImportWizard extends AbstractMavenProjectWizard implements IIm
}
return true;
}
+
+ @Override
+ public void dispose() {
+ mappingConfiguration = null;
+ super.dispose();
+ }
}

Back to the top