From db181a7a294d9904f36178f513fc151185fafde6 Mon Sep 17 00:00:00 2001 From: Jeff Johnston Date: Fri, 17 Aug 2018 18:17:59 -0400 Subject: Bug 538050 - NullPointerException in SpecfileParser.parse - add null check in SpecfileReconcilingStrategy.updateEditor() Change-Id: I2593db659b8970560718a32ca96aa3aba8cd7870 Reviewed-on: https://git.eclipse.org/r/127624 Tested-by: CI Bot Reviewed-by: Jeff Johnston --- .../internal/rpm/ui/editor/SpecfileReconcilingStrategy.java | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/rpm/org.eclipse.linuxtools.rpm.ui.editor/src/org/eclipse/linuxtools/internal/rpm/ui/editor/SpecfileReconcilingStrategy.java b/rpm/org.eclipse.linuxtools.rpm.ui.editor/src/org/eclipse/linuxtools/internal/rpm/ui/editor/SpecfileReconcilingStrategy.java index f438f850fb..7069177447 100644 --- a/rpm/org.eclipse.linuxtools.rpm.ui.editor/src/org/eclipse/linuxtools/internal/rpm/ui/editor/SpecfileReconcilingStrategy.java +++ b/rpm/org.eclipse.linuxtools.rpm.ui.editor/src/org/eclipse/linuxtools/internal/rpm/ui/editor/SpecfileReconcilingStrategy.java @@ -79,8 +79,11 @@ public class SpecfileReconcilingStrategy implements IReconcilingStrategy, IRecon private void updateEditor() { Shell shell = editor.getSite().getShell(); if (!(shell == null || shell.isDisposed())) { - shell.getDisplay().asyncExec(() -> editor - .setSpecfile(editor.getParser().parse(documentProvider.getDocument(editor.getEditorInput())))); + // Bug 538050 + if (documentProvider != null && documentProvider.getDocument(editor.getEditorInput()) != null) { + shell.getDisplay().asyncExec(() -> editor + .setSpecfile(editor.getParser().parse(documentProvider.getDocument(editor.getEditorInput())))); + } } } -- cgit v1.2.3