From c6ed71641f265641283a790fb500db4ce893eccb Mon Sep 17 00:00:00 2001 From: Jeff Johnston Date: Tue, 31 Jul 2018 18:12:58 -0400 Subject: Bug 515699 - NPE in Staging View - GNUHyperlinkDetector.detectHyperlinks - add null check after calling getLocation() in detectHyperlinks Change-Id: I4a86500383d8483287583fb28d4797b03d090afb Reviewed-on: https://git.eclipse.org/r/126854 Tested-by: CI Bot Reviewed-by: Jeff Johnston (cherry picked from commit f3ffb7ff20d666fac24227f2a37d02d1e4516dc9) Reviewed-on: https://git.eclipse.org/r/126858 --- .../internal/changelog/core/editors/GNUHyperlinkDetector.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/changelog/org.eclipse.linuxtools.changelog.core/src/org/eclipse/linuxtools/internal/changelog/core/editors/GNUHyperlinkDetector.java b/changelog/org.eclipse.linuxtools.changelog.core/src/org/eclipse/linuxtools/internal/changelog/core/editors/GNUHyperlinkDetector.java index b032078a9a..00c4068418 100644 --- a/changelog/org.eclipse.linuxtools.changelog.core/src/org/eclipse/linuxtools/internal/changelog/core/editors/GNUHyperlinkDetector.java +++ b/changelog/org.eclipse.linuxtools.changelog.core/src/org/eclipse/linuxtools/internal/changelog/core/editors/GNUHyperlinkDetector.java @@ -45,7 +45,11 @@ public class GNUHyperlinkDetector extends AbstractHyperlinkDetector { if (buffer == null) { return null; } - documentLocation = buffer.getLocation().removeLastSegments(1); + IPath p = buffer.getLocation(); + if (p == null) { + return null; + } + documentLocation = p.removeLastSegments(1); } IDocument thisDoc = textViewer.getDocument(); -- cgit v1.2.3