From 21757defc733806d44a8bcda9eac29e889f12b4b Mon Sep 17 00:00:00 2001 From: Florian Wininger Date: Mon, 10 Mar 2014 15:35:19 -0400 Subject: TMF: Add XML state system view definition to the XSD Change-Id: I3cad7bd42b2b263837b62392b5169781c5f9b26a Signed-off-by: Geneviève Bastien Signed-off-by: Florian Wininger Reviewed-on: https://git.eclipse.org/r/23159 Tested-by: Hudson CI --- .../xml/core/tests/common/TmfXmlTestFiles.java | 2 +- .../xml/core/tests/module/XmlUtilsTest.java | 15 +++++ .../test_xml_files/test_invalid.xml | 7 -- .../test_invalid/invalid_view_multipledisplays.xml | 35 ++++++++++ .../test_xml_files/test_invalid/test_invalid.xml | 7 ++ .../test_xml_files/test_valid.xml | 29 +++++++++ .../tmf/analysis/xml/core/module/xmlDefinition.xsd | 2 + .../xml/core/module/xmlStateSystemView.xsd | 76 ++++++++++++++++++++++ 8 files changed, 165 insertions(+), 8 deletions(-) delete mode 100644 lttng/org.eclipse.linuxtools.tmf.analysis.xml.core.tests/test_xml_files/test_invalid.xml create mode 100644 lttng/org.eclipse.linuxtools.tmf.analysis.xml.core.tests/test_xml_files/test_invalid/invalid_view_multipledisplays.xml create mode 100644 lttng/org.eclipse.linuxtools.tmf.analysis.xml.core.tests/test_xml_files/test_invalid/test_invalid.xml create mode 100644 lttng/org.eclipse.linuxtools.tmf.analysis.xml.core/src/org/eclipse/linuxtools/tmf/analysis/xml/core/module/xmlStateSystemView.xsd diff --git a/lttng/org.eclipse.linuxtools.tmf.analysis.xml.core.tests/common/org/eclipse/linuxtools/tmf/analysis/xml/core/tests/common/TmfXmlTestFiles.java b/lttng/org.eclipse.linuxtools.tmf.analysis.xml.core.tests/common/org/eclipse/linuxtools/tmf/analysis/xml/core/tests/common/TmfXmlTestFiles.java index 2274bd80f0..5a48ce3a04 100644 --- a/lttng/org.eclipse.linuxtools.tmf.analysis.xml.core.tests/common/org/eclipse/linuxtools/tmf/analysis/xml/core/tests/common/TmfXmlTestFiles.java +++ b/lttng/org.eclipse.linuxtools.tmf.analysis.xml.core.tests/common/org/eclipse/linuxtools/tmf/analysis/xml/core/tests/common/TmfXmlTestFiles.java @@ -23,7 +23,7 @@ public enum TmfXmlTestFiles { /** A valid XML test file */ VALID_FILE("../org.eclipse.linuxtools.tmf.analysis.xml.core.tests/test_xml_files/test_valid.xml"), /** An invalid test file */ - INVALID_FILE("../org.eclipse.linuxtools.tmf.analysis.xml.core.tests/test_xml_files/test_invalid.xml"); + INVALID_FILE("../org.eclipse.linuxtools.tmf.analysis.xml.core.tests/test_xml_files/test_invalid/test_invalid.xml"); private final String fPath; diff --git a/lttng/org.eclipse.linuxtools.tmf.analysis.xml.core.tests/src/org/eclipse/linuxtools/tmf/analysis/xml/core/tests/module/XmlUtilsTest.java b/lttng/org.eclipse.linuxtools.tmf.analysis.xml.core.tests/src/org/eclipse/linuxtools/tmf/analysis/xml/core/tests/module/XmlUtilsTest.java index fffe192e21..5867aa580b 100644 --- a/lttng/org.eclipse.linuxtools.tmf.analysis.xml.core.tests/src/org/eclipse/linuxtools/tmf/analysis/xml/core/tests/module/XmlUtilsTest.java +++ b/lttng/org.eclipse.linuxtools.tmf.analysis.xml.core.tests/src/org/eclipse/linuxtools/tmf/analysis/xml/core/tests/module/XmlUtilsTest.java @@ -40,6 +40,8 @@ import org.w3c.dom.Element; */ public class XmlUtilsTest { + private static final String pathname = "test_xml_files/test_invalid"; + /** * Empty the XML directory after the test */ @@ -91,8 +93,21 @@ public class XmlUtilsTest { fail("XML test file does not exist"); } assertFalse(XmlUtils.xmlValidate(testXmlFile).isOK()); + } + /** + * Test various invalid files and make sure they are invalid + */ + @Test + public void testXmlValidateInvalid() { + File[] validFiles = (new File(pathname)).listFiles(); + for (File f : validFiles) { + assertFalse("File " + f.getName(), XmlUtils.xmlValidate(f).isOK()); + } + } + + /** * test the {@link XmlUtils#addXmlFile(File)} method */ diff --git a/lttng/org.eclipse.linuxtools.tmf.analysis.xml.core.tests/test_xml_files/test_invalid.xml b/lttng/org.eclipse.linuxtools.tmf.analysis.xml.core.tests/test_xml_files/test_invalid.xml deleted file mode 100644 index dcd5512c07..0000000000 --- a/lttng/org.eclipse.linuxtools.tmf.analysis.xml.core.tests/test_xml_files/test_invalid.xml +++ /dev/null @@ -1,7 +0,0 @@ - - - - - - \ No newline at end of file diff --git a/lttng/org.eclipse.linuxtools.tmf.analysis.xml.core.tests/test_xml_files/test_invalid/invalid_view_multipledisplays.xml b/lttng/org.eclipse.linuxtools.tmf.analysis.xml.core.tests/test_xml_files/test_invalid/invalid_view_multipledisplays.xml new file mode 100644 index 0000000000..bf820eaa0e --- /dev/null +++ b/lttng/org.eclipse.linuxtools.tmf.analysis.xml.core.tests/test_xml_files/test_invalid/invalid_view_multipledisplays.xml @@ -0,0 +1,35 @@ + + + + + + + + + \ No newline at end of file diff --git a/lttng/org.eclipse.linuxtools.tmf.analysis.xml.core.tests/test_xml_files/test_invalid/test_invalid.xml b/lttng/org.eclipse.linuxtools.tmf.analysis.xml.core.tests/test_xml_files/test_invalid/test_invalid.xml new file mode 100644 index 0000000000..dcd5512c07 --- /dev/null +++ b/lttng/org.eclipse.linuxtools.tmf.analysis.xml.core.tests/test_xml_files/test_invalid/test_invalid.xml @@ -0,0 +1,7 @@ + + + + + + \ No newline at end of file diff --git a/lttng/org.eclipse.linuxtools.tmf.analysis.xml.core.tests/test_xml_files/test_valid.xml b/lttng/org.eclipse.linuxtools.tmf.analysis.xml.core.tests/test_xml_files/test_valid.xml index 4c821070e1..46911776a5 100644 --- a/lttng/org.eclipse.linuxtools.tmf.analysis.xml.core.tests/test_xml_files/test_valid.xml +++ b/lttng/org.eclipse.linuxtools.tmf.analysis.xml.core.tests/test_xml_files/test_valid.xml @@ -13,6 +13,35 @@ + + + + + diff --git a/lttng/org.eclipse.linuxtools.tmf.analysis.xml.core/src/org/eclipse/linuxtools/tmf/analysis/xml/core/module/xmlDefinition.xsd b/lttng/org.eclipse.linuxtools.tmf.analysis.xml.core/src/org/eclipse/linuxtools/tmf/analysis/xml/core/module/xmlDefinition.xsd index f464c1df5a..1783836f20 100644 --- a/lttng/org.eclipse.linuxtools.tmf.analysis.xml.core/src/org/eclipse/linuxtools/tmf/analysis/xml/core/module/xmlDefinition.xsd +++ b/lttng/org.eclipse.linuxtools.tmf.analysis.xml.core/src/org/eclipse/linuxtools/tmf/analysis/xml/core/module/xmlDefinition.xsd @@ -15,9 +15,11 @@ + + diff --git a/lttng/org.eclipse.linuxtools.tmf.analysis.xml.core/src/org/eclipse/linuxtools/tmf/analysis/xml/core/module/xmlStateSystemView.xsd b/lttng/org.eclipse.linuxtools.tmf.analysis.xml.core/src/org/eclipse/linuxtools/tmf/analysis/xml/core/module/xmlStateSystemView.xsd new file mode 100644 index 0000000000..7064a9a48f --- /dev/null +++ b/lttng/org.eclipse.linuxtools.tmf.analysis.xml.core/src/org/eclipse/linuxtools/tmf/analysis/xml/core/module/xmlStateSystemView.xsd @@ -0,0 +1,76 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + \ No newline at end of file -- cgit v1.2.3