diff options
author | Alexander Kurtakov | 2019-05-23 07:37:21 +0000 |
---|---|---|
committer | Alexander Kurtakov | 2019-05-23 08:20:48 +0000 |
commit | 580d96e6cbdac2e14d24620676b5073a6fd0e20f (patch) | |
tree | bc91366a0e0016b97d97425b6efc8cc29ed709cc /valgrind | |
parent | 5c190198ba49a9e6cb03a0b4c233c1223f65e410 (diff) | |
download | org.eclipse.linuxtools-580d96e6cbdac2e14d24620676b5073a6fd0e20f.tar.gz org.eclipse.linuxtools-580d96e6cbdac2e14d24620676b5073a6fd0e20f.tar.xz org.eclipse.linuxtools-580d96e6cbdac2e14d24620676b5073a6fd0e20f.zip |
Use StringBuilder instead of StringBuffer where possible.
Change-Id: Ib62a825af23774e09f51c50113aded3e9e2b8695
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
Reviewed-on: https://git.eclipse.org/r/142647
Tested-by: Linux Tools Bot <linuxtools-bot@eclipse.org>
Diffstat (limited to 'valgrind')
4 files changed, 9 insertions, 9 deletions
diff --git a/valgrind/org.eclipse.linuxtools.valgrind.core/src/org/eclipse/linuxtools/internal/valgrind/core/ValgrindCommand.java b/valgrind/org.eclipse.linuxtools.valgrind.core/src/org/eclipse/linuxtools/internal/valgrind/core/ValgrindCommand.java index 8fc5b922f8..79063affab 100644 --- a/valgrind/org.eclipse.linuxtools.valgrind.core/src/org/eclipse/linuxtools/internal/valgrind/core/ValgrindCommand.java +++ b/valgrind/org.eclipse.linuxtools.valgrind.core/src/org/eclipse/linuxtools/internal/valgrind/core/ValgrindCommand.java @@ -51,7 +51,7 @@ public class ValgrindCommand { Process p = RuntimeProcessFactory.getFactory() .exec(new String[] { getValgrindCommand(), CommandLineConstants.OPT_VERSION }, project); try { - StringBuffer out = new StringBuffer(); + StringBuilder out = new StringBuilder(); readIntoBuffer(out, p); return out.toString().trim(); } catch (IOException e) { @@ -94,7 +94,7 @@ public class ValgrindCommand { * @return process */ public String getCommandLine() { - StringBuffer ret = new StringBuffer(); + StringBuilder ret = new StringBuilder(); for (String arg : args) { ret.append(arg).append(" "); //$NON-NLS-1$ } @@ -112,7 +112,7 @@ public class ValgrindCommand { } } - private void readIntoBuffer(StringBuffer out, Process p) throws IOException { + private void readIntoBuffer(StringBuilder out, Process p) throws IOException { if (p == null) { throw new IOException("Null Process object: unabled to read input into buffer"); //$NON-NLS-1$ } diff --git a/valgrind/org.eclipse.linuxtools.valgrind.massif/src/org/eclipse/linuxtools/internal/valgrind/massif/MassifHeapTreeNode.java b/valgrind/org.eclipse.linuxtools.valgrind.massif/src/org/eclipse/linuxtools/internal/valgrind/massif/MassifHeapTreeNode.java index 6b3b275bd7..15a6a04db2 100644 --- a/valgrind/org.eclipse.linuxtools.valgrind.massif/src/org/eclipse/linuxtools/internal/valgrind/massif/MassifHeapTreeNode.java +++ b/valgrind/org.eclipse.linuxtools.valgrind.massif/src/org/eclipse/linuxtools/internal/valgrind/massif/MassifHeapTreeNode.java @@ -30,7 +30,7 @@ public class MassifHeapTreeNode { public MassifHeapTreeNode(MassifHeapTreeNode parent, double percent, long bytes, String address, String function, String filename, int line) { this.parent = parent; - StringBuffer nodeText = new StringBuffer(); + StringBuilder nodeText = new StringBuilder(); formatBytes(percent, bytes, nodeText); nodeText.append(address).append(":"); //$NON-NLS-1$ if (function.length() > 0) { @@ -57,7 +57,7 @@ public class MassifHeapTreeNode { public MassifHeapTreeNode(MassifHeapTreeNode parent, double percent, long bytes, String text) { this.parent = parent; - StringBuffer nodeText = new StringBuffer(); + StringBuilder nodeText = new StringBuilder(); formatBytes(percent, bytes, nodeText); nodeText.append(text); this.percent = percent; @@ -70,7 +70,7 @@ public class MassifHeapTreeNode { children = new ArrayList<>(); } - private void formatBytes(double percent, long bytes, StringBuffer buffer) { + private void formatBytes(double percent, long bytes, StringBuilder buffer) { buffer.append(new DecimalFormat("0.##").format(percent) + "%"); //$NON-NLS-1$ //$NON-NLS-2$ buffer.append(" ("); //$NON-NLS-1$ buffer.append(new DecimalFormat("#,##0").format(bytes) + "B"); //$NON-NLS-1$ //$NON-NLS-2$ diff --git a/valgrind/org.eclipse.linuxtools.valgrind.massif/src/org/eclipse/linuxtools/internal/valgrind/massif/MassifParser.java b/valgrind/org.eclipse.linuxtools.valgrind.massif/src/org/eclipse/linuxtools/internal/valgrind/massif/MassifParser.java index 9674b7b9cb..6449b2b5f5 100644 --- a/valgrind/org.eclipse.linuxtools.valgrind.massif/src/org/eclipse/linuxtools/internal/valgrind/massif/MassifParser.java +++ b/valgrind/org.eclipse.linuxtools.valgrind.massif/src/org/eclipse/linuxtools/internal/valgrind/massif/MassifParser.java @@ -155,7 +155,7 @@ public class MassifParser { node = new MassifHeapTreeNode(parent, percentage, numBytes, address, function, filename, lineNo); } else { // concatenate the rest - StringBuffer text = new StringBuffer(); + StringBuilder text = new StringBuilder(); for (int i = 2; i < parts.length; i++) { text.append(parts[i]); text.append(" "); //$NON-NLS-1$ diff --git a/valgrind/org.eclipse.linuxtools.valgrind.ui.editor/src/org/eclipse/linuxtools/internal/valgrind/ui/editor/SuppressionKindRule.java b/valgrind/org.eclipse.linuxtools.valgrind.ui.editor/src/org/eclipse/linuxtools/internal/valgrind/ui/editor/SuppressionKindRule.java index b50e0bba6e..1b3fb33d10 100644 --- a/valgrind/org.eclipse.linuxtools.valgrind.ui.editor/src/org/eclipse/linuxtools/internal/valgrind/ui/editor/SuppressionKindRule.java +++ b/valgrind/org.eclipse.linuxtools.valgrind.ui.editor/src/org/eclipse/linuxtools/internal/valgrind/ui/editor/SuppressionKindRule.java @@ -68,8 +68,8 @@ public class SuppressionKindRule implements IRule { @Override public IToken evaluate(ICharacterScanner scanner) { IToken result = subrule.evaluate(scanner); - StringBuffer tool = new StringBuffer(); - StringBuffer kind = new StringBuffer(); + StringBuilder tool = new StringBuilder(); + StringBuilder kind = new StringBuilder(); if (!result.isUndefined()) { boolean match = true; |