diff options
| author | Andrew Ferrazzutti | 2013-11-12 15:24:54 +0000 |
|---|---|---|
| committer | Jeff Johnston | 2013-11-25 23:03:40 +0000 |
| commit | 64bbd5261020b9fe4f3297e7781133270962180d (patch) | |
| tree | 986df9573d5701933df4ccb32fdd3d79d6f516e3 /profiling/org.eclipse.linuxtools.dataviewers.charts/src/org | |
| parent | c4dde12d9db197c4bd39edc15b45ea5594f907bb (diff) | |
| download | org.eclipse.linuxtools-64bbd5261020b9fe4f3297e7781133270962180d.tar.gz org.eclipse.linuxtools-64bbd5261020b9fe4f3297e7781133270962180d.tar.xz org.eclipse.linuxtools-64bbd5261020b9fe4f3297e7781133270962180d.zip | |
Systemtap: Make improvents to graph display.
1) When capturing a script's output to display it in a graph,
don't attempt to plot null or invalid values so as to
avoid causing an error.
2) Add labels on individual pie charts to signify which series
each pie represents. Also show a "No data" label when all pie
charts are empty.
Change-Id: I326f583ae7924c397e4771f2cc49fb605ff548a8
Signed-off-by: Andrew Ferrazzutti <aferrazz@redhat.com>
Reviewed-on: https://git.eclipse.org/r/18297
Tested-by: Hudson CI
Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
IP-Clean: Jeff Johnston <jjohnstn@redhat.com>
Tested-by: Jeff Johnston <jjohnstn@redhat.com>
Diffstat (limited to 'profiling/org.eclipse.linuxtools.dataviewers.charts/src/org')
2 files changed, 8 insertions, 7 deletions
diff --git a/profiling/org.eclipse.linuxtools.dataviewers.charts/src/org/eclipse/linuxtools/dataviewers/charts/provider/ChartFactory.java b/profiling/org.eclipse.linuxtools.dataviewers.charts/src/org/eclipse/linuxtools/dataviewers/charts/provider/ChartFactory.java index e1c577b3a4..5bc1fed245 100755 --- a/profiling/org.eclipse.linuxtools.dataviewers.charts/src/org/eclipse/linuxtools/dataviewers/charts/provider/ChartFactory.java +++ b/profiling/org.eclipse.linuxtools.dataviewers.charts/src/org/eclipse/linuxtools/dataviewers/charts/provider/ChartFactory.java @@ -60,7 +60,13 @@ public class ChartFactory { view = (ChartView) PlatformUI.getWorkbench().getActiveWorkbenchWindow().getActivePage() .showView(ChartView.VIEW_ID, String.valueOf(ChartView.getSecId()), IWorkbenchPage.VIEW_ACTIVATE); - PieChart chart = new PieChart(view.getParent(), SWT.NONE); + + String[] pieChartNames = new String [valFields.size()]; + for (int i = 0; i < valFields.size(); i++) { + pieChartNames[i] = valFields.get(i).getColumnHeaderText(); + } + + PieChart chart = new PieChart(view.getParent(), SWT.NONE, pieChartNames); chart.setBackground(WHITE); chart.setBackgroundInPlotArea(GRAD); @@ -75,11 +81,6 @@ public class ChartFactory { valueLabels[i] = nameField.getValue(objects[i]); } - /* - * String [] pieChartNames = new String [valFields.size()]; for (int i = 0; i < valFields.size(); i++) { - * pieChartNames[i] = valFields.get(i).getColumnHeaderText(); } - */ - // pie chart data is grouped by columns // row size is the number of pie charts // column size is the number of data per pie chart diff --git a/profiling/org.eclipse.linuxtools.dataviewers.charts/src/org/eclipse/linuxtools/internal/dataviewers/charts/dialogs/ChartDialog.java b/profiling/org.eclipse.linuxtools.dataviewers.charts/src/org/eclipse/linuxtools/internal/dataviewers/charts/dialogs/ChartDialog.java index c0f8e7fc91..697701b703 100755 --- a/profiling/org.eclipse.linuxtools.dataviewers.charts/src/org/eclipse/linuxtools/internal/dataviewers/charts/dialogs/ChartDialog.java +++ b/profiling/org.eclipse.linuxtools.dataviewers.charts/src/org/eclipse/linuxtools/internal/dataviewers/charts/dialogs/ChartDialog.java @@ -43,7 +43,7 @@ import org.eclipse.swt.widgets.Text; import org.swtchart.Chart; /** - * The dialog used to customize the chart before cerating it. + * The dialog used to customize the chart before creating it. */ public class ChartDialog extends Dialog { |