perf.tests: Simplifications.

* drop unused methods/fields
* drop unused bundle requires
* use foreach
* initialize arrays with needed size
* equals("") replaced with isEmpty
* use assertArrayEquals instead of iterating and checking
* remove empty fail() calls on exception - better to throw and let junit
give us the exception info than plain hiding it


Change-Id: I3eadb1fed16b6bd0675a7c2178878a05e8a97c65

1 files changed, 3 insertions, 16 deletions

diff --git a/perf/org.eclipse.linuxtools.perf.swtbot.tests/src/org/eclipse/linuxtools/internal/perf/swtbot/tests/AbstractSWTBotTest.java b/perf/org.eclipse.linuxtools.perf.swtbot.tests/src/org/eclipse/linuxtools/internal/perf/swtbot/tests/AbstractSWTBotTest.java
index bd02d3acff..dd08195fd4 100644
--- a/perf/org.eclipse.linuxtools.perf.swtbot.tests/src/org/eclipse/linuxtools/internal/perf/swtbot/tests/AbstractSWTBotTest.java
+++ b/perf/org.eclipse.linuxtools.perf.swtbot.tests/src/org/eclipse/linuxtools/internal/perf/swtbot/tests/AbstractSWTBotTest.java
@@ -187,28 +187,15 @@ public abstract class AbstractSWTBotTest extends AbstractTest {
 	/**
 	 * Stub data for use in case the Perf tool is not installed.
 	 */
-	protected class StubPerfData implements IPerfData {
-		private String data;
-		private String title;
-
-		public StubPerfData() {
-			data = "stub_perf_data";
-			title = "stub_perf_title";
-		}
-
-		public StubPerfData(String heading, String datum) {
-			title = heading;
-			data = datum;
-		}
-
+	protected static class StubPerfData implements IPerfData {
 		@Override
 		public String getPerfData() {
-			return data;
+			return "stub_perf_data";
 		}
 
 		@Override
 		public String getTitle() {
-			return title;
+			return "stub_perf_title";
 		}
 
 	}