diff options
| author | Xavier Coulon | 2016-06-06 09:11:48 +0000 |
|---|---|---|
| committer | Jeff Johnston | 2016-06-06 15:59:22 +0000 |
| commit | 9e9872d3fdcbc8e0ee3f2544ef687d5b7eef597b (patch) | |
| tree | db542dde694f4cea2d4b75624bb0713bfe8fa91d | |
| parent | e5cc77960c4dd16b56ce767d6b2a2d154c945985 (diff) | |
| download | org.eclipse.linuxtools-9e9872d3fdcbc8e0ee3f2544ef687d5b7eef597b.tar.gz org.eclipse.linuxtools-9e9872d3fdcbc8e0ee3f2544ef687d5b7eef597b.tar.xz org.eclipse.linuxtools-9e9872d3fdcbc8e0ee3f2544ef687d5b7eef597b.zip | |
Bug 495518 - SWTException below ContainerDataVolumeDialog$7$1.run
Checking if the dialog's shell was disposed before validating
and updating the controls
Change-Id: I225183148bfae7e2289f99bdac835d2f4111d7f1
Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
Reviewed-on: https://git.eclipse.org/r/74631
Tested-by: Hudson CI
Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
| -rw-r--r-- | containers/org.eclipse.linuxtools.docker.ui/src/org/eclipse/linuxtools/internal/docker/ui/wizards/ContainerDataVolumeDialog.java | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/containers/org.eclipse.linuxtools.docker.ui/src/org/eclipse/linuxtools/internal/docker/ui/wizards/ContainerDataVolumeDialog.java b/containers/org.eclipse.linuxtools.docker.ui/src/org/eclipse/linuxtools/internal/docker/ui/wizards/ContainerDataVolumeDialog.java index 755cead13d..a72a41cc8a 100644 --- a/containers/org.eclipse.linuxtools.docker.ui/src/org/eclipse/linuxtools/internal/docker/ui/wizards/ContainerDataVolumeDialog.java +++ b/containers/org.eclipse.linuxtools.docker.ui/src/org/eclipse/linuxtools/internal/docker/ui/wizards/ContainerDataVolumeDialog.java @@ -396,10 +396,11 @@ public class ContainerDataVolumeDialog extends Dialog { final Label errorMessageIcon, final Label errorMessageLabel) { return event -> { - final IStatus status = validateInput(); - if (Display.getCurrent() == null) { + // skip if dialog has been closed + if (Display.getCurrent() == null || getShell().isDisposed()) { return; } + final IStatus status = validateInput(); Display.getCurrent().syncExec(() -> { if (status.isOK()) { errorMessageIcon.setVisible(false); |