Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJeff Johnston2019-06-04 09:35:51 -0400
committerJeff Johnston2019-06-04 13:32:01 -0400
commit5ea635d75719d9f6e1226fb3efdbb941c5df336a (patch)
treeef773516b643079ec91fd93813df07ef399f445d
parent4e15a953cede020aaa8017763e2b95696411253e (diff)
downloadorg.eclipse.linuxtools-5ea635d75719d9f6e1226fb3efdbb941c5df336a.tar.gz
org.eclipse.linuxtools-5ea635d75719d9f6e1226fb3efdbb941c5df336a.tar.xz
org.eclipse.linuxtools-5ea635d75719d9f6e1226fb3efdbb941c5df336a.zip
Bug 547909 - CoreException: for hasMultipleTags property
- remove tag action was specifying a property test for hasMultiple tags for a hierarchy node but was specifying that the input be adaptable to IDockerImage, but there is already a hasMultipleTags property test for IDockerImage and the property tester for hierarchy node should be IDockerImageHierarchyImageNode - do similar for IDockerImageHierarchyContainerNode actions and specify instanceof instead of adapt for these so there are separate properties for IDockerContainer and IDockerImageHierarchyContainerNode inputs Change-Id: I0f47438e18fdde0538164256a754baa620ca3758 Reviewed-on: https://git.eclipse.org/r/143272 Tested-by: Linux Tools Bot <linuxtools-bot@eclipse.org> Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
-rw-r--r--containers/org.eclipse.linuxtools.docker.ui/plugin.xml35
1 files changed, 18 insertions, 17 deletions
diff --git a/containers/org.eclipse.linuxtools.docker.ui/plugin.xml b/containers/org.eclipse.linuxtools.docker.ui/plugin.xml
index 940ef37ee6..8ea77cd2b8 100644
--- a/containers/org.eclipse.linuxtools.docker.ui/plugin.xml
+++ b/containers/org.eclipse.linuxtools.docker.ui/plugin.xml
@@ -432,8 +432,8 @@
property="org.eclipse.linuxtools.docker.propertytesters.container.isStopped" value="true"/>
</and>
<and>
- <adapt
- type="org.eclipse.linuxtools.docker.core.IDockerContainer" />
+ <instanceof
+ value="org.eclipse.linuxtools.docker.core.IDockerImageHierarchyContainerNode" />
<test
forcePluginActivation="true"
property="org.eclipse.linuxtools.docker.propertytesters.imageHierarchyContainerNode.isStopped" value="true"/>
@@ -458,8 +458,8 @@
property="org.eclipse.linuxtools.docker.propertytesters.container.isRunning" value="true"/>
</and>
<and>
- <adapt
- type="org.eclipse.linuxtools.docker.core.IDockerContainer" />
+ <instanceof
+ value="org.eclipse.linuxtools.docker.core.IDockerImageHierarchyContainerNode" />
<test
forcePluginActivation="true"
property="org.eclipse.linuxtools.docker.propertytesters.imageHierarchyContainerNode.isRunning" value="true"/>
@@ -484,8 +484,8 @@
property="org.eclipse.linuxtools.docker.propertytesters.container.isPaused" value="true"/>
</and>
<and>
- <adapt
- type="org.eclipse.linuxtools.docker.core.IDockerContainer" />
+ <instanceof
+ value="org.eclipse.linuxtools.docker.core.IDockerImageHierarchyContainerNode" />
<test
forcePluginActivation="true"
property="org.eclipse.linuxtools.docker.propertytesters.imageHierarchyContainerNode.isPaused" value="true"/>
@@ -522,8 +522,8 @@
</or>
</and>
<and>
- <adapt
- type="org.eclipse.linuxtools.docker.core.IDockerContainer" />
+ <instanceof
+ value="org.eclipse.linuxtools.docker.core.IDockerImageHierarchyContainerNode" />
<or>
<and>
<test
@@ -570,8 +570,8 @@
</or>
</and>
<and>
- <adapt
- type="org.eclipse.linuxtools.docker.core.IDockerContainer" />
+ <instanceof
+ value="org.eclipse.linuxtools.docker.core.IDockerImageHierarchyContainerNode" />
<or>
<and>
<test
@@ -600,8 +600,8 @@
ifEmpty="false">
<or>
<and>
- <adapt
- type="org.eclipse.linuxtools.docker.core.IDockerContainer" />
+ <instanceof
+ value="org.eclipse.linuxtools.docker.core.IDockerContainer" />
<or>
<test
forcePluginActivation="true"
@@ -612,8 +612,8 @@
</or>
</and>
<and>
- <adapt
- type="org.eclipse.linuxtools.docker.core.IDockerContainer" />
+ <instanceof
+ value="org.eclipse.linuxtools.docker.core.IDockerImageHierarchyContainerNode" />
<or>
<test
forcePluginActivation="true"
@@ -643,8 +643,8 @@
property="org.eclipse.linuxtools.docker.propertytesters.container.isRemovable" value="true"/>
</and>
<and>
- <adapt
- type="org.eclipse.linuxtools.docker.core.IDockerContainer" />
+ <instanceof
+ value="org.eclipse.linuxtools.docker.core.IDockerImageHierarchyContainerNode" />
<test
forcePluginActivation="true"
property="org.eclipse.linuxtools.docker.propertytesters.imageHierarchyContainerNode.isRemovable" value="true"/>
@@ -823,6 +823,7 @@
property="org.eclipse.linuxtools.docker.propertytesters.image.canBeTagged" value="true"/>
</and>
<and>
+ <instanceof value="org.eclipse.linuxtools.docker.core.IDockerImageHierarchyImageNode"></instanceof>
<adapt type="org.eclipse.linuxtools.docker.core.IDockerImage"></adapt>
<test
forcePluginActivation="true"
@@ -848,7 +849,7 @@
property="org.eclipse.linuxtools.docker.propertytesters.image.hasMultipleTags" value="true"/>
</and>
<and>
- <adapt type="org.eclipse.linuxtools.docker.core.IDockerImage"></adapt>
+ <instanceof value="org.eclipse.linuxtools.docker.core.IDockerImageHierarchyImageNode"></instanceof>
<test
forcePluginActivation="true"
property="org.eclipse.linuxtools.docker.propertytesters.imageHierarchyImageNode.hasMultipleTags" value="true"/>

Back to the top