Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRoland Grunberg2016-06-20 15:43:08 -0400
committerJeff Johnston2016-06-20 17:02:43 -0400
commit05d5e4706558aa3a408621023b26cef601c01578 (patch)
tree496b4acba10a335e893b64b6ef37306b9e2c9966
parentacae4c484160f0f8d4ee2a6e1a460001fe2fac71 (diff)
downloadorg.eclipse.linuxtools-05d5e4706558aa3a408621023b26cef601c01578.tar.gz
org.eclipse.linuxtools-05d5e4706558aa3a408621023b26cef601c01578.tar.xz
org.eclipse.linuxtools-05d5e4706558aa3a408621023b26cef601c01578.zip
Bug 496432: static ICON reference should not be disposed.
The static ICON reference in IconColumnLabelProvider is used for all icon measurement and rendering. If it's disposed by any specific instance, it will be unusable going forward. Since only one instance should exist for the entire runtime, it should be safe to leave it. Change-Id: Id3d947138bb3de737d33b0af46fef8524f92570a Reviewed-on: https://git.eclipse.org/r/75587 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
-rw-r--r--containers/org.eclipse.linuxtools.docker.ui/src/org/eclipse/linuxtools/internal/docker/ui/wizards/ImageSearchPage.java1
1 files changed, 0 insertions, 1 deletions
diff --git a/containers/org.eclipse.linuxtools.docker.ui/src/org/eclipse/linuxtools/internal/docker/ui/wizards/ImageSearchPage.java b/containers/org.eclipse.linuxtools.docker.ui/src/org/eclipse/linuxtools/internal/docker/ui/wizards/ImageSearchPage.java
index 3c0a0e2dd7..4ebdffe5ad 100644
--- a/containers/org.eclipse.linuxtools.docker.ui/src/org/eclipse/linuxtools/internal/docker/ui/wizards/ImageSearchPage.java
+++ b/containers/org.eclipse.linuxtools.docker.ui/src/org/eclipse/linuxtools/internal/docker/ui/wizards/ImageSearchPage.java
@@ -454,7 +454,6 @@ public class ImageSearchPage extends WizardPage {
@Override
public void dispose() {
- ICON.dispose();
super.dispose();
}

Back to the top