Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRoland Grunberg2015-06-02 17:35:32 -0400
committerRoland Grunberg2015-06-02 19:05:25 -0400
commit4f3cdb83564c1ba898fba88b41793d3c43cc6b31 (patch)
treea66694d2a6b4d0f3f3c1690f1c770efa8a02b731
parent6641512e5cf08a3deaf82f2db216b5d31fbb034a (diff)
downloadorg.eclipse.linuxtools-4f3cdb83564c1ba898fba88b41793d3c43cc6b31.tar.gz
org.eclipse.linuxtools-4f3cdb83564c1ba898fba88b41793d3c43cc6b31.tar.xz
org.eclipse.linuxtools-4f3cdb83564c1ba898fba88b41793d3c43cc6b31.zip
Remove some print statements and fix typo in property tester.
Such errors happen when there is access to a stream the underlying libraries have closed. We try to avoid this by checking the state of the container but this may not be enough. Change-Id: Ia23d71b8c8124ea289e8b37201629e5a8b983a91 Reviewed-on: https://git.eclipse.org/r/49262 Tested-by: Hudson CI Reviewed-by: Roland Grunberg <rgrunber@redhat.com> Reviewed-on: https://git.eclipse.org/r/49270
-rw-r--r--containers/org.eclipse.linuxtools.docker.core/src/org/eclipse/linuxtools/internal/docker/core/DockerConnection.java8
-rw-r--r--containers/org.eclipse.linuxtools.docker.ui/src/org/eclipse/linuxtools/internal/docker/ui/RunConsole.java2
-rw-r--r--containers/org.eclipse.linuxtools.docker.ui/src/org/eclipse/linuxtools/internal/docker/ui/propertytesters/ContainerPropertyTester.java2
3 files changed, 4 insertions, 8 deletions
diff --git a/containers/org.eclipse.linuxtools.docker.core/src/org/eclipse/linuxtools/internal/docker/core/DockerConnection.java b/containers/org.eclipse.linuxtools.docker.core/src/org/eclipse/linuxtools/internal/docker/core/DockerConnection.java
index e6b090d954..623d7e8b3e 100644
--- a/containers/org.eclipse.linuxtools.docker.core/src/org/eclipse/linuxtools/internal/docker/core/DockerConnection.java
+++ b/containers/org.eclipse.linuxtools.docker.core/src/org/eclipse/linuxtools/internal/docker/core/DockerConnection.java
@@ -39,6 +39,9 @@ import java.util.Map.Entry;
import java.util.Properties;
import java.util.Set;
+import jnr.unixsocket.UnixSocketAddress;
+import jnr.unixsocket.UnixSocketChannel;
+
import org.eclipse.core.runtime.IPath;
import org.eclipse.core.runtime.IStatus;
import org.eclipse.core.runtime.ListenerList;
@@ -98,9 +101,6 @@ import com.spotify.docker.client.messages.Info;
import com.spotify.docker.client.messages.PortBinding;
import com.spotify.docker.client.messages.Version;
-import jnr.unixsocket.UnixSocketAddress;
-import jnr.unixsocket.UnixSocketChannel;
-
/**
* A connection to a Docker daemon. The connection may rely on Unix Socket or TCP connection (using the REST API).
* All low-level communication is delegated to a wrapped {@link DockerClient}.
@@ -1503,7 +1503,6 @@ public class DockerConnection implements IDockerConnection {
buff = new byte[1024];
}
} catch (Exception e) {
- e.printStackTrace();
}
}
});
@@ -1569,7 +1568,6 @@ public class DockerConnection implements IDockerConnection {
}
}
} catch (Exception e) {
- e.printStackTrace();
}
}
});
diff --git a/containers/org.eclipse.linuxtools.docker.ui/src/org/eclipse/linuxtools/internal/docker/ui/RunConsole.java b/containers/org.eclipse.linuxtools.docker.ui/src/org/eclipse/linuxtools/internal/docker/ui/RunConsole.java
index 85e196ac95..33e7fa9424 100644
--- a/containers/org.eclipse.linuxtools.docker.ui/src/org/eclipse/linuxtools/internal/docker/ui/RunConsole.java
+++ b/containers/org.eclipse.linuxtools.docker.ui/src/org/eclipse/linuxtools/internal/docker/ui/RunConsole.java
@@ -273,7 +273,6 @@ public class RunConsole extends IOConsole {
break;
}
} catch (IOException e1) {
- e1.printStackTrace();
}
}
}
@@ -301,7 +300,6 @@ public class RunConsole extends IOConsole {
break;
}
} catch (IOException e1) {
- e1.printStackTrace();
}
}
}
diff --git a/containers/org.eclipse.linuxtools.docker.ui/src/org/eclipse/linuxtools/internal/docker/ui/propertytesters/ContainerPropertyTester.java b/containers/org.eclipse.linuxtools.docker.ui/src/org/eclipse/linuxtools/internal/docker/ui/propertytesters/ContainerPropertyTester.java
index 31beb7e7c3..db11188b59 100644
--- a/containers/org.eclipse.linuxtools.docker.ui/src/org/eclipse/linuxtools/internal/docker/ui/propertytesters/ContainerPropertyTester.java
+++ b/containers/org.eclipse.linuxtools.docker.ui/src/org/eclipse/linuxtools/internal/docker/ui/propertytesters/ContainerPropertyTester.java
@@ -39,7 +39,7 @@ public class ContainerPropertyTester extends PropertyTester {
/**
* Property name to check if a given {@link IDockerContainer} is unknown.
*/
- public static final String IS_UNKNOWN = "isUnknwon";
+ public static final String IS_UNKNOWN = "isUnknown";
@Override
public boolean test(final Object receiver, final String property, final Object[] args, final Object expectedValue) {

Back to the top