Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJeff Johnston2014-08-21 18:29:15 +0000
committerJeff Johnston2014-08-27 19:32:11 +0000
commit5e5080f55237775b162ae213cb51303f37e218a2 (patch)
treeade84f78c20bfcd62d71d7623a8843a19ad1f7de
parent0dee14cd268e3dc96f9f8a8626759bb18117ef9c (diff)
downloadorg.eclipse.linuxtools-5e5080f55237775b162ae213cb51303f37e218a2.tar.gz
org.eclipse.linuxtools-5e5080f55237775b162ae213cb51303f37e218a2.tar.xz
org.eclipse.linuxtools-5e5080f55237775b162ae213cb51303f37e218a2.zip
Restore interfaces as public to avoid a major release bump.
Change-Id: Icaec40ff33856f7bb6b8673cfc2b5201d906f492 Reviewed-on: https://git.eclipse.org/r/32095 Tested-by: Hudson CI Reviewed-by: Alexander Kurtakov <akurtako@redhat.com> Tested-by: Alexander Kurtakov <akurtako@redhat.com> (cherry picked from commit 5bc3c61eccb879752f46d1d89e213a046f2a3531) Reviewed-on: https://git.eclipse.org/r/32416 Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> Tested-by: Jeff Johnston <jjohnstn@redhat.com>
-rw-r--r--valgrind/org.eclipse.linuxtools.valgrind.launch/src/org/eclipse/linuxtools/valgrind/launch/IValgrindLaunchDelegate.java3
-rw-r--r--valgrind/org.eclipse.linuxtools.valgrind.launch/src/org/eclipse/linuxtools/valgrind/launch/IValgrindOutputDirectoryProvider.java2
-rw-r--r--valgrind/org.eclipse.linuxtools.valgrind.launch/src/org/eclipse/linuxtools/valgrind/launch/IValgrindToolPage.java2
3 files changed, 5 insertions, 2 deletions
diff --git a/valgrind/org.eclipse.linuxtools.valgrind.launch/src/org/eclipse/linuxtools/valgrind/launch/IValgrindLaunchDelegate.java b/valgrind/org.eclipse.linuxtools.valgrind.launch/src/org/eclipse/linuxtools/valgrind/launch/IValgrindLaunchDelegate.java
index 600fa943e4..07b3973773 100644
--- a/valgrind/org.eclipse.linuxtools.valgrind.launch/src/org/eclipse/linuxtools/valgrind/launch/IValgrindLaunchDelegate.java
+++ b/valgrind/org.eclipse.linuxtools.valgrind.launch/src/org/eclipse/linuxtools/valgrind/launch/IValgrindLaunchDelegate.java
@@ -34,6 +34,7 @@ public interface IValgrindLaunchDelegate {
* @param logDir - directory to store Valgrind log output files
* @param monitor - to report progress
* @throws CoreException - if this method fails
+ * @since 3.0
*/
void handleLaunch(ILaunchConfiguration config, ILaunch launch, IPath logDir, IProgressMonitor monitor) throws CoreException;
@@ -46,6 +47,7 @@ public interface IValgrindLaunchDelegate {
* @param contentDescription - String describing the launch that populated the view
* @param monitor - to report progress
* @throws CoreException - if this method fails
+ * @since 3.0
*/
void initializeView(IValgrindToolView view, String contentDescription, IProgressMonitor monitor) throws CoreException;
@@ -57,6 +59,7 @@ public interface IValgrindLaunchDelegate {
* @param logDir - directory to store Valgrind log output files
* @return an array of arguments that can appended to a <code>valgrind</code> command
* @throws CoreException - retrieving attributes from config failed
+ * @since 3.0
*/
String[] getCommandArray(ILaunchConfiguration config, Version ver, IPath logDir) throws CoreException;
diff --git a/valgrind/org.eclipse.linuxtools.valgrind.launch/src/org/eclipse/linuxtools/valgrind/launch/IValgrindOutputDirectoryProvider.java b/valgrind/org.eclipse.linuxtools.valgrind.launch/src/org/eclipse/linuxtools/valgrind/launch/IValgrindOutputDirectoryProvider.java
index e6569221cf..6b87d40522 100644
--- a/valgrind/org.eclipse.linuxtools.valgrind.launch/src/org/eclipse/linuxtools/valgrind/launch/IValgrindOutputDirectoryProvider.java
+++ b/valgrind/org.eclipse.linuxtools.valgrind.launch/src/org/eclipse/linuxtools/valgrind/launch/IValgrindOutputDirectoryProvider.java
@@ -24,6 +24,6 @@ public interface IValgrindOutputDirectoryProvider {
* Obtains a directory to store Valgrind output files.
* @return the absolute path to this directory
*/
- IPath getOutputPath() throws IOException;
+ public IPath getOutputPath() throws IOException;
} \ No newline at end of file
diff --git a/valgrind/org.eclipse.linuxtools.valgrind.launch/src/org/eclipse/linuxtools/valgrind/launch/IValgrindToolPage.java b/valgrind/org.eclipse.linuxtools.valgrind.launch/src/org/eclipse/linuxtools/valgrind/launch/IValgrindToolPage.java
index 47574c0855..90f19e3f47 100644
--- a/valgrind/org.eclipse.linuxtools.valgrind.launch/src/org/eclipse/linuxtools/valgrind/launch/IValgrindToolPage.java
+++ b/valgrind/org.eclipse.linuxtools.valgrind.launch/src/org/eclipse/linuxtools/valgrind/launch/IValgrindToolPage.java
@@ -26,6 +26,6 @@ public interface IValgrindToolPage extends ILaunchConfigurationTab {
* checking should not be performed.
* @param ver - the version of Valgrind, or null
*/
- void setValgrindVersion(Version ver);
+ public void setValgrindVersion(Version ver);
}

Back to the top