Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAndrew Ferrazzutti2014-05-29 09:49:16 -0400
committerJeff Johnston2014-05-29 13:43:07 -0400
commitcd2199e57810987ec949fb04369a17e62917d40a (patch)
treeffa410fc99904d1cdd6369c77da1c3400756111d
parent6eac30219f5fad7521e970079cbc3e6028453486 (diff)
downloadorg.eclipse.linuxtools-cd2199e57810987ec949fb04369a17e62917d40a.tar.gz
org.eclipse.linuxtools-cd2199e57810987ec949fb04369a17e62917d40a.tar.xz
org.eclipse.linuxtools-cd2199e57810987ec949fb04369a17e62917d40a.zip
Systemtap: Stop BrowserView crashes on re-open.
Prevent BrowserViews from disposing their content trees when they are closed. This disposal caused TapsetLibrary trees to be disposed, which are not rebuilt the the next time the views are opened. This resulted in the NPEs that prevented the views from being re-opened after being closed. Resolves EBZ #435979. Change-Id: I4428340898c5943970e105d4de8ad33e5ba8e0fa Signed-off-by: Andrew Ferrazzutti <aferrazz@redhat.com> Reviewed-on: https://git.eclipse.org/r/27534 Tested-by: Hudson CI Reviewed-by: Jeff Johnston <jjohnstn@redhat.com> Tested-by: Jeff Johnston <jjohnstn@redhat.com>
-rw-r--r--systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/internal/systemtap/ui/ide/views/BrowserView.java4
1 files changed, 0 insertions, 4 deletions
diff --git a/systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/internal/systemtap/ui/ide/views/BrowserView.java b/systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/internal/systemtap/ui/ide/views/BrowserView.java
index 3890fc7248..acedd5bfe2 100644
--- a/systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/internal/systemtap/ui/ide/views/BrowserView.java
+++ b/systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/internal/systemtap/ui/ide/views/BrowserView.java
@@ -154,10 +154,6 @@ public abstract class BrowserView extends ViewPart {
collapseHandler.dispose();
collapseHandler = null;
}
- if (tree != null) {
- tree.dispose();
- tree = null;
- }
if (viewer != null) {
if (doubleClickAction != null) {
viewer.removeDoubleClickListener(doubleClickAction);

Back to the top